All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jiebing Chen <jiebing.chen@amlogic.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
	jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com
Subject: Re: [PATCH v6 1/5] dt-bindings: clock: meson: Add audio power domain for S4 soc
Date: Thu, 29 Jan 2026 10:07:02 -0600	[thread overview]
Message-ID: <20260129160702.GA1111873-robh@kernel.org> (raw)
In-Reply-To: <20260126-audio_drvier-v6-1-99e350855bc2@amlogic.com>

On Mon, Jan 26, 2026 at 06:01:42AM +0000, Jiebing Chen wrote:
> The audio power domain has been found on S4 device.
> It must be enabled prior to audio operations.
> 
> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
> ---
>  .../bindings/clock/amlogic,axg-audio-clkc.yaml         | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
> index fd7982dd4cea..1cd9a99e5ff3 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
> +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
> @@ -20,6 +20,7 @@ properties:
>      enum:
>        - amlogic,axg-audio-clkc
>        - amlogic,g12a-audio-clkc
> +      - amlogic,s4-audio-clkc
>        - amlogic,sm1-audio-clkc
>  
>    '#clock-cells':
> @@ -99,7 +100,8 @@ properties:
>  
>    resets:
>      description: internal reset line
> -
> +  power-domains:
> +    maxItems: 1

blank line

Looks fine otherwise except for the DTB warning, so something here 
doesn't match.

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jiebing Chen <jiebing.chen@amlogic.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
	jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com
Subject: Re: [PATCH v6 1/5] dt-bindings: clock: meson: Add audio power domain for S4 soc
Date: Thu, 29 Jan 2026 10:07:02 -0600	[thread overview]
Message-ID: <20260129160702.GA1111873-robh@kernel.org> (raw)
In-Reply-To: <20260126-audio_drvier-v6-1-99e350855bc2@amlogic.com>

On Mon, Jan 26, 2026 at 06:01:42AM +0000, Jiebing Chen wrote:
> The audio power domain has been found on S4 device.
> It must be enabled prior to audio operations.
> 
> Signed-off-by: Jiebing Chen <jiebing.chen@amlogic.com>
> ---
>  .../bindings/clock/amlogic,axg-audio-clkc.yaml         | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
> index fd7982dd4cea..1cd9a99e5ff3 100644
> --- a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
> +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml
> @@ -20,6 +20,7 @@ properties:
>      enum:
>        - amlogic,axg-audio-clkc
>        - amlogic,g12a-audio-clkc
> +      - amlogic,s4-audio-clkc
>        - amlogic,sm1-audio-clkc
>  
>    '#clock-cells':
> @@ -99,7 +100,8 @@ properties:
>  
>    resets:
>      description: internal reset line
> -
> +  power-domains:
> +    maxItems: 1

blank line

Looks fine otherwise except for the DTB warning, so something here 
doesn't match.


  reply	other threads:[~2026-01-29 16:07 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26  6:01 [PATCH v6 0/5] Add support for S4 audio Jiebing Chen
2026-01-26  6:01 ` Jiebing Chen via B4 Relay
2026-01-26  6:01 ` Jiebing Chen via B4 Relay
2026-01-26  6:01 ` [PATCH v6 1/5] dt-bindings: clock: meson: Add audio power domain for S4 soc Jiebing Chen
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-29 16:07   ` Rob Herring [this message]
2026-01-29 16:07     ` Rob Herring
2026-01-26  6:01 ` [PATCH v6 2/5] dt-bindings: Asoc: axg-audio: Add S4 audio tocodec Jiebing Chen
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-29 16:07   ` Rob Herring
2026-01-29 16:07     ` Rob Herring
2026-01-26  6:01 ` [PATCH v6 3/5] ASoC: meson: g12a-toacodec: Add S4 tocodec driver Jiebing Chen
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-26 11:04   ` Jerome Brunet
2026-01-26 11:04     ` Jerome Brunet
2026-01-26 13:26     ` Jiebing Chen
2026-01-26 13:26       ` Jiebing Chen
2026-01-26  6:01 ` [PATCH v6 4/5] clk: meson: axg_audio: add S4 support Jiebing Chen
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-26  6:01 ` [PATCH v6 5/5] arm64: dts: amlogic: Add Amlogic S4 Audio Jiebing Chen
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-26  6:01   ` Jiebing Chen via B4 Relay
2026-01-26 11:19   ` Jerome Brunet
2026-01-26 11:19     ` Jerome Brunet
2026-01-26 13:20     ` Jiebing Chen
2026-01-26 13:20       ` Jiebing Chen
2026-01-26 14:57       ` Jerome Brunet
2026-01-26 14:57         ` Jerome Brunet
2026-01-27  2:19         ` Jiebing Chen
2026-01-27  2:19           ` Jiebing Chen
2026-01-27  9:20 ` [PATCH v6 0/5] Add support for S4 audio Piotr Oniszczuk
2026-01-27  9:20   ` Piotr Oniszczuk
2026-01-27 15:56 ` Rob Herring
2026-01-27 15:56   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129160702.GA1111873-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=jian.xu@amlogic.com \
    --cc=jiebing.chen@amlogic.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=mturquette@baylibre.com \
    --cc=neil.armstrong@linaro.org \
    --cc=perex@perex.cz \
    --cc=sboyd@kernel.org \
    --cc=shuai.li@amlogic.com \
    --cc=tiwai@suse.com \
    --cc=zhe.wang@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.