All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Guodong Xu <guodong@riscstar.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Alex Elder <elder@riscstar.com>, Lee Jones <lee@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties
Date: Thu, 29 Jan 2026 12:16:04 -0600	[thread overview]
Message-ID: <20260129181604.GA1398997-robh@kernel.org> (raw)
In-Reply-To: <20260124-spacemit-p1-v2-2-2c86b06694ba@riscstar.com>

On Sat, Jan 24, 2026 at 08:20:17AM +0800, Guodong Xu wrote:
> Add supply properties that match the P1 PMIC's actual hardware topology
> where each buck converter has its own VIN pin and LDO groups share
> common input pins. Supply names are defined according to the pinout
> names in the P1 datasheet.
> 
> This allows different boards to describe their actual power tree
> connections in devicetree rather than hardcoding supply relationships
> in the driver.

You are breaking both forward and backwards compatibility changing both 
the dts and the driver. If that is fine to do, then explicitly say so. 

A secondary issue is the binding and dts go via differ trees and we end 
up with intermittent warnings.

> 
> Signed-off-by: Guodong Xu <guodong@riscstar.com>
> ---
> v2: Remove providers from the dts example.
>     Pass the 'make dt_binding_check' test.
> ---
>  .../devicetree/bindings/mfd/spacemit,p1.yaml       | 49 +++++++++++++++++++++-
>  1 file changed, 47 insertions(+), 2 deletions(-)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Guodong Xu <guodong@riscstar.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Alex Elder <elder@riscstar.com>, Lee Jones <lee@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties
Date: Thu, 29 Jan 2026 12:16:04 -0600	[thread overview]
Message-ID: <20260129181604.GA1398997-robh@kernel.org> (raw)
In-Reply-To: <20260124-spacemit-p1-v2-2-2c86b06694ba@riscstar.com>

On Sat, Jan 24, 2026 at 08:20:17AM +0800, Guodong Xu wrote:
> Add supply properties that match the P1 PMIC's actual hardware topology
> where each buck converter has its own VIN pin and LDO groups share
> common input pins. Supply names are defined according to the pinout
> names in the P1 datasheet.
> 
> This allows different boards to describe their actual power tree
> connections in devicetree rather than hardcoding supply relationships
> in the driver.

You are breaking both forward and backwards compatibility changing both 
the dts and the driver. If that is fine to do, then explicitly say so. 

A secondary issue is the binding and dts go via differ trees and we end 
up with intermittent warnings.

> 
> Signed-off-by: Guodong Xu <guodong@riscstar.com>
> ---
> v2: Remove providers from the dts example.
>     Pass the 'make dt_binding_check' test.
> ---
>  .../devicetree/bindings/mfd/spacemit,p1.yaml       | 49 +++++++++++++++++++++-
>  1 file changed, 47 insertions(+), 2 deletions(-)

  parent reply	other threads:[~2026-01-29 18:16 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-24  0:20 [PATCH v2 0/4] regulator: spacemit-p1: Fix voltage ranges and support board power tree Guodong Xu
2026-01-24  0:20 ` Guodong Xu
2026-01-24  0:20 ` [PATCH v2 1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators Guodong Xu
2026-01-24  0:20   ` Guodong Xu
2026-01-28 13:28   ` Alex Elder
2026-01-28 13:28     ` Alex Elder
2026-01-28 15:26     ` Guodong Xu
2026-01-28 15:26       ` Guodong Xu
2026-01-29  0:48       ` Alex Elder
2026-01-29  0:48         ` Alex Elder
2026-01-24  0:20 ` [PATCH v2 2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties Guodong Xu
2026-01-24  0:20   ` Guodong Xu
2026-01-28 13:28   ` Alex Elder
2026-01-28 13:28     ` Alex Elder
2026-01-29 18:16   ` Rob Herring [this message]
2026-01-29 18:16     ` Rob Herring
2026-01-31 12:25     ` Guodong Xu
2026-01-31 12:25       ` Guodong Xu
2026-01-24  0:20 ` [PATCH v2 3/4] regulator: spacemit-p1: Update supply names Guodong Xu
2026-01-24  0:20   ` Guodong Xu
2026-01-28 13:28   ` Alex Elder
2026-01-28 13:28     ` Alex Elder
2026-01-28 14:47     ` Guodong Xu
2026-01-28 14:47       ` Guodong Xu
2026-01-28 14:53       ` Alex Elder
2026-01-28 14:53         ` Alex Elder
2026-01-24  0:20 ` [PATCH v2 4/4] riscv: dts: spacemit: Update PMIC supply properties for BPI-F3 and Jupiter Guodong Xu
2026-01-24  0:20   ` Guodong Xu
2026-01-28 13:29   ` Alex Elder
2026-01-28 13:29     ` Alex Elder
2026-01-24  6:24 ` [PATCH v2 0/4] regulator: spacemit-p1: Fix voltage ranges and support board power tree Vivian Wang
2026-01-24  6:24   ` Vivian Wang
2026-01-25  4:18   ` Guodong Xu
2026-01-25  4:18     ` Guodong Xu
2026-01-25  4:27     ` Guodong Xu
2026-01-25  4:27       ` Guodong Xu
2026-01-25 11:03       ` Yixun Lan
2026-01-25 11:03         ` Yixun Lan
2026-01-25 13:02         ` Vivian Wang
2026-01-25 13:02           ` Vivian Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129181604.GA1398997-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=elder@riscstar.com \
    --cc=guodong@riscstar.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=spacemit@lists.linux.dev \
    --cc=troy.mitchell@linux.spacemit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.