* [PATCH] gpib: remove unnecessary module_init/exit functions
@ 2026-01-31 1:41 Ethan Nelson-Moore
0 siblings, 0 replies; 3+ messages in thread
From: Ethan Nelson-Moore @ 2026-01-31 1:41 UTC (permalink / raw)
To: linux-kernel
Cc: Ethan Nelson-Moore, Dave Penkler, Greg Kroah-Hartman,
Michael Rubin
Two GPIB drivers have unnecessary empty module_init and module_exit
functions. Remove them. Note that if a module_init function exists, a
module_exit function must also exist; otherwise, the module cannot be
unloaded.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/gpib/nec7210/nec7210.c | 12 ------------
drivers/gpib/tms9914/tms9914.c | 13 -------------
2 files changed, 25 deletions(-)
diff --git a/drivers/gpib/nec7210/nec7210.c b/drivers/gpib/nec7210/nec7210.c
index bbf39367f5e4..f15d38dfa4cc 100644
--- a/drivers/gpib/nec7210/nec7210.c
+++ b/drivers/gpib/nec7210/nec7210.c
@@ -1107,15 +1107,3 @@ void nec7210_locking_iomem_write_byte(struct nec7210_priv *priv, u8 data,
spin_unlock_irqrestore(&priv->register_page_lock, flags);
}
EXPORT_SYMBOL(nec7210_locking_iomem_write_byte);
-
-static int __init nec7210_init_module(void)
-{
- return 0;
-}
-
-static void __exit nec7210_exit_module(void)
-{
-}
-
-module_init(nec7210_init_module);
-module_exit(nec7210_exit_module);
diff --git a/drivers/gpib/tms9914/tms9914.c b/drivers/gpib/tms9914/tms9914.c
index 72a11596a35e..1411297e6217 100644
--- a/drivers/gpib/tms9914/tms9914.c
+++ b/drivers/gpib/tms9914/tms9914.c
@@ -899,16 +899,3 @@ void tms9914_iomem_write_byte(struct tms9914_priv *priv, u8 data, unsigned int r
udelay(1);
}
EXPORT_SYMBOL_GPL(tms9914_iomem_write_byte);
-
-static int __init tms9914_init_module(void)
-{
- return 0;
-}
-
-static void __exit tms9914_exit_module(void)
-{
-}
-
-module_init(tms9914_init_module);
-module_exit(tms9914_exit_module);
-
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] gpib: remove unnecessary module_init/exit functions
@ 2026-01-31 1:55 Ethan Nelson-Moore
2026-01-31 1:57 ` Ethan Nelson-Moore
0 siblings, 1 reply; 3+ messages in thread
From: Ethan Nelson-Moore @ 2026-01-31 1:55 UTC (permalink / raw)
To: linux-kernel
Cc: Ethan Nelson-Moore, Dave Penkler, Greg Kroah-Hartman,
Michael Rubin
Two GPIB drivers have unnecessary empty module_init and module_exit
functions. Remove them. Note that if a module_init function exists, a
module_exit function must also exist; otherwise, the module cannot be
unloaded.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/gpib/nec7210/nec7210.c | 12 ------------
drivers/gpib/tms9914/tms9914.c | 13 -------------
2 files changed, 25 deletions(-)
diff --git a/drivers/gpib/nec7210/nec7210.c b/drivers/gpib/nec7210/nec7210.c
index bbf39367f5e4..f15d38dfa4cc 100644
--- a/drivers/gpib/nec7210/nec7210.c
+++ b/drivers/gpib/nec7210/nec7210.c
@@ -1107,15 +1107,3 @@ void nec7210_locking_iomem_write_byte(struct nec7210_priv *priv, u8 data,
spin_unlock_irqrestore(&priv->register_page_lock, flags);
}
EXPORT_SYMBOL(nec7210_locking_iomem_write_byte);
-
-static int __init nec7210_init_module(void)
-{
- return 0;
-}
-
-static void __exit nec7210_exit_module(void)
-{
-}
-
-module_init(nec7210_init_module);
-module_exit(nec7210_exit_module);
diff --git a/drivers/gpib/tms9914/tms9914.c b/drivers/gpib/tms9914/tms9914.c
index 72a11596a35e..1411297e6217 100644
--- a/drivers/gpib/tms9914/tms9914.c
+++ b/drivers/gpib/tms9914/tms9914.c
@@ -899,16 +899,3 @@ void tms9914_iomem_write_byte(struct tms9914_priv *priv, u8 data, unsigned int r
udelay(1);
}
EXPORT_SYMBOL_GPL(tms9914_iomem_write_byte);
-
-static int __init tms9914_init_module(void)
-{
- return 0;
-}
-
-static void __exit tms9914_exit_module(void)
-{
-}
-
-module_init(tms9914_init_module);
-module_exit(tms9914_exit_module);
-
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpib: remove unnecessary module_init/exit functions
2026-01-31 1:55 Ethan Nelson-Moore
@ 2026-01-31 1:57 ` Ethan Nelson-Moore
0 siblings, 0 replies; 3+ messages in thread
From: Ethan Nelson-Moore @ 2026-01-31 1:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Dave Penkler, Greg Kroah-Hartman, Michael Rubin
On Fri, Jan 30, 2026 at 5:56 PM Ethan Nelson-Moore
<enelsonmoore@gmail.com> wrote:
> Two GPIB drivers have unnecessary empty module_init and module_exit
> functions. Remove them. Note that if a module_init function exists, a
> module_exit function must also exist; otherwise, the module cannot be
> unloaded.
Sorry, I accidentally sent this again since it was still in my folder
of patches to send. It's the same as the first patch.
Ethan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-31 1:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-31 1:41 [PATCH] gpib: remove unnecessary module_init/exit functions Ethan Nelson-Moore
-- strict thread matches above, loose matches on Subject: below --
2026-01-31 1:55 Ethan Nelson-Moore
2026-01-31 1:57 ` Ethan Nelson-Moore
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.