All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: Vinod Koul <vkoul@kernel.org>,
	Joy Chakraborty <joychakr@google.com>,
	Naveen Kumar <mnkumar@google.com>, Roy Luo <royluo@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Alex Elder <elder@riscstar.com>,
	Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Inochi Amaoto <inochiama@gmail.com>, Sven Peter <sven@kernel.org>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] phy: GOOGLE_USB: add TYPEC dependency
Date: Mon,  2 Feb 2026 10:56:52 +0100	[thread overview]
Message-ID: <20260202095655.1289973-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

With CONFIG_TYPEC=m, this driver cannot be built-in:

arm-linux-gnueabi/bin/arm-linux-gnueabi-ld: drivers/phy/phy-google-usb.o: in function `google_usb_phy_remove':
phy-google-usb.c:(.text+0x24): undefined reference to `typec_switch_unregister'

Add CONFIG_TYPEC as a hard dependency here to force a clean build.
In theory, compile-testing with CONFIG_TYPEC=n would also work, but
that seems pointless.

Fixes: cbce66669c82 ("phy: Add Google Tensor SoC USB PHY driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 142e7b0ef2ef..02467dfd4fb0 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -50,6 +50,7 @@ config GENERIC_PHY_MIPI_DPHY
 config PHY_GOOGLE_USB
 	tristate "Google Tensor SoC USB PHY driver"
 	select GENERIC_PHY
+	depends on TYPEC
 	help
 	  Enable support for the USB PHY on Google Tensor SoCs, starting with
 	  the G5 generation (Laguna). This driver provides the PHY interfaces
-- 
2.39.5


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Vinod Koul <vkoul@kernel.org>,
	Joy Chakraborty <joychakr@google.com>,
	Naveen Kumar <mnkumar@google.com>, Roy Luo <royluo@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Alex Elder <elder@riscstar.com>,
	Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Inochi Amaoto <inochiama@gmail.com>, Sven Peter <sven@kernel.org>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] phy: GOOGLE_USB: add TYPEC dependency
Date: Mon,  2 Feb 2026 10:56:52 +0100	[thread overview]
Message-ID: <20260202095655.1289973-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb.de>

With CONFIG_TYPEC=m, this driver cannot be built-in:

arm-linux-gnueabi/bin/arm-linux-gnueabi-ld: drivers/phy/phy-google-usb.o: in function `google_usb_phy_remove':
phy-google-usb.c:(.text+0x24): undefined reference to `typec_switch_unregister'

Add CONFIG_TYPEC as a hard dependency here to force a clean build.
In theory, compile-testing with CONFIG_TYPEC=n would also work, but
that seems pointless.

Fixes: cbce66669c82 ("phy: Add Google Tensor SoC USB PHY driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/phy/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 142e7b0ef2ef..02467dfd4fb0 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -50,6 +50,7 @@ config GENERIC_PHY_MIPI_DPHY
 config PHY_GOOGLE_USB
 	tristate "Google Tensor SoC USB PHY driver"
 	select GENERIC_PHY
+	depends on TYPEC
 	help
 	  Enable support for the USB PHY on Google Tensor SoCs, starting with
 	  the G5 generation (Laguna). This driver provides the PHY interfaces
-- 
2.39.5


             reply	other threads:[~2026-02-02  9:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  9:56 Arnd Bergmann [this message]
2026-02-02  9:56 ` [PATCH] phy: GOOGLE_USB: add TYPEC dependency Arnd Bergmann
2026-02-04 12:41 ` Neil Armstrong
2026-02-04 12:41   ` Neil Armstrong
2026-02-04 15:44 ` Vinod Koul
2026-02-04 15:44   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260202095655.1289973-1-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=elder@riscstar.com \
    --cc=inochiama@gmail.com \
    --cc=ivo.ivanov.ivanov1@gmail.com \
    --cc=joychakr@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mnkumar@google.com \
    --cc=neil.armstrong@linaro.org \
    --cc=royluo@google.com \
    --cc=sven@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.