From: Altan Hacigumus <ahacigu.linux@gmail.com>
To: akpm@linux-foundation.org, david@fromorbit.com
Cc: ahacigu.linux@gmail.com, zhengqi.arch@bytedance.com,
roman.gushchin@linux.dev, muchun.song@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] mm/shrinker: Fix refcount leak in shrink_slab_memcg()
Date: Tue, 3 Feb 2026 19:35:53 -0800 [thread overview]
Message-ID: <20260204033553.50039-1-ahacigu.linux@gmail.com> (raw)
In-Reply-To: <20260203073757.135088-1-ahacigu.linux@gmail.com>
When kmem is disabled for memcg, slab-backed shrinkers are skipped.
However, shrink_slab_memcg() doesn't drop the reference acquired via
shrinker_try_get() before continuing.
Add the missing shrinker_put().
Also, since memcg_kmem_online() and shrinker flags cannot change
dynamically, remove the shrinker from the bitmap to avoid unnecessary
future scans.
Fixes: 50d09da8e119 ("mm: shrinker: make memcg slab shrink lockless")
Suggested-by: Qi Zheng <zhengqi.arch@bytedance.com>
Acked-by: Qi Zheng <zhengqi.arch@bytedance.com>
Link: https://lore.kernel.org/r/20260203073757.135088-1-ahacigu.linux@gmail.com
Signed-off-by: Altan Hacigumus <ahacigu.linux@gmail.com>
---
Changes in v2:
- Use clear_bit() to remove shrinker from bitmap instead of just skipping
---
mm/shrinker.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/mm/shrinker.c b/mm/shrinker.c
index 4a93fd433689..68dc7b4242f2 100644
--- a/mm/shrinker.c
+++ b/mm/shrinker.c
@@ -544,8 +544,11 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid,
/* Call non-slab shrinkers even though kmem is disabled */
if (!memcg_kmem_online() &&
- !(shrinker->flags & SHRINKER_NONSLAB))
+ !(shrinker->flags & SHRINKER_NONSLAB)) {
+ clear_bit(offset, unit->map);
+ shrinker_put(shrinker);
continue;
+ }
ret = do_shrink_slab(&sc, shrinker, priority);
if (ret == SHRINK_EMPTY) {
--
2.43.0
next prev parent reply other threads:[~2026-02-04 3:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 7:37 [PATCH] mm/shrinker: Fix refcount leak in shrink_slab_memcg() Altan Hacigumus
2026-02-03 8:17 ` Qi Zheng
2026-02-03 8:43 ` Altan Hacigumus
2026-02-03 9:10 ` Altan Hacigumus
2026-02-04 3:35 ` Altan Hacigumus [this message]
2026-02-04 3:55 ` [PATCH v2] " Qi Zheng
2026-02-04 4:00 ` Muchun Song
2026-04-15 21:27 ` Suren Baghdasaryan
2026-04-16 1:10 ` Altan Hacigumus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204033553.50039-1-ahacigu.linux@gmail.com \
--to=ahacigu.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.