All of lore.kernel.org
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Altan Hacigumus <ahacigu.linux@gmail.com>
Cc: akpm@linux-foundation.org, david@fromorbit.com,
	zhengqi.arch@bytedance.com, roman.gushchin@linux.dev,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm/shrinker: Fix refcount leak in shrink_slab_memcg()
Date: Wed, 4 Feb 2026 12:00:15 +0800	[thread overview]
Message-ID: <4FEDFC64-4EE4-4FC5-98DB-FAF9182FDFAB@linux.dev> (raw)
In-Reply-To: <20260204033553.50039-1-ahacigu.linux@gmail.com>



> On Feb 4, 2026, at 11:35, Altan Hacigumus <ahacigu.linux@gmail.com> wrote:
> 
> When kmem is disabled for memcg, slab-backed shrinkers are skipped.
> However, shrink_slab_memcg() doesn't drop the reference acquired via
> shrinker_try_get() before continuing.
> 
> Add the missing shrinker_put().
> 
> Also, since memcg_kmem_online() and shrinker flags cannot change
> dynamically, remove the shrinker from the bitmap to avoid unnecessary
> future scans.
> 
> Fixes: 50d09da8e119 ("mm: shrinker: make memcg slab shrink lockless")
> Suggested-by: Qi Zheng <zhengqi.arch@bytedance.com>
> Acked-by: Qi Zheng <zhengqi.arch@bytedance.com>
> Link: https://lore.kernel.org/r/20260203073757.135088-1-ahacigu.linux@gmail.com
> Signed-off-by: Altan Hacigumus <ahacigu.linux@gmail.com>

Reviewed-by: Muchun Song <muchun.song@linux.dev>




  parent reply	other threads:[~2026-02-04  4:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  7:37 [PATCH] mm/shrinker: Fix refcount leak in shrink_slab_memcg() Altan Hacigumus
2026-02-03  8:17 ` Qi Zheng
2026-02-03  8:43   ` Altan Hacigumus
2026-02-03  9:10   ` Altan Hacigumus
2026-02-04  3:35 ` [PATCH v2] " Altan Hacigumus
2026-02-04  3:55   ` Qi Zheng
2026-02-04  4:00   ` Muchun Song [this message]
2026-04-15 21:27     ` Suren Baghdasaryan
2026-04-16  1:10       ` Altan Hacigumus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEDFC64-4EE4-4FC5-98DB-FAF9182FDFAB@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=ahacigu.linux@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=roman.gushchin@linux.dev \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.