Re: [PATCH] [v2] i3c, iio: fix i3c driver dependencies

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Guenter Roeck" <linux@roeck-us.net>,
	"Arnd Bergmann" <arnd@kernel.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Adrian Fluturel" <fluturel.adrian@gmail.com>,
	"Carlos Song" <carlos.song@nxp.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Jean Delvare" <jdelvare@suse.de>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-i3c@lists.infradead.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] [v2] i3c, iio: fix i3c driver dependencies
Date: Wed, 4 Feb 2026 17:26:04 +0100	[thread overview]
Message-ID: <20260204162604f55a84b5@mail.local> (raw)
In-Reply-To: <20260202205011.221c1359@jic23-huawei>

On 02/02/2026 20:50:11+0000, Jonathan Cameron wrote:
> On Mon, 2 Feb 2026 09:50:58 -0800
> Guenter Roeck <linux@roeck-us.net> wrote:
> 
> > On 2/2/26 08:04, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > > 
> > > All combined i2c/i3c drivers appear to suffer from the same link
> > > time problem when CONFIG_I3C is set to 'm':
> > > 
> > > arm-linux-gnueabi-ld: drivers/iio/magnetometer/mmc5633.o: in function `mmc5633_i3c_driver_init':
> > > mmc5633.c:(.init.text+0x30): undefined reference to `i3c_driver_register_with_owner'
> > > 
> > > This was previously fixed several times by marking individual
> > > drivers as 'depends on I2C; depends on I3C || !I3C', but this gets
> > > tedious and is somewhat confusing.
> > > 
> > > Add a Kconfig symbol 'I3C_OR_I2C' to help replace those dependencies,
> > > and use this in all the existing drivers that had already fixed it
> > > as well as the new mmc5633 driver.
> > > 
> > > Fixes: 6e5f6bf2e3f0 ("iio: magnetometer: Add mmc5633 sensor")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > > v2: restore accidentally deleted lines
> > > ---
> > >   drivers/hwmon/Kconfig            |  6 ++----  
> > 
> > For hwmon:
> > 
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> > 
> Hi Arnd / All,
> 
> I applied a less good fix and the pull request has gone to Greg for
> the IIO bug. I copied the hwmon config you have below.
> 
> So I'm absolutely in favour of this improvement but it's
> probably a case of rebase after rc1 and it goes in next cycle.
> Or maybe Greg could pick a rebased version up on top of char-misc-next?
> 
> So with it rebased,
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>

I guess I can pick this up after rc1.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com