From: Eric Biggers <ebiggers@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
David Sterba <dsterba@suse.com>, Theodore Ts'o <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
Andrey Albershteyn <aalbersh@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, fsverity@lists.linux.dev
Subject: Re: fsverity speedup and memory usage optimization v5
Date: Wed, 4 Feb 2026 11:37:22 -0800 [thread overview]
Message-ID: <20260204193722.GB2193@sol> (raw)
In-Reply-To: <aYOZdUTrvIjq82AE@casper.infradead.org>
On Wed, Feb 04, 2026 at 07:09:41PM +0000, Matthew Wilcox wrote:
> On Wed, Feb 04, 2026 at 11:02:18AM -0800, Eric Biggers wrote:
> > Aligning to the opening bracket is the usual style as agreed on by the
> > kernel community.
>
> Says who? I've been part of the kernel community since 1997. I've
> never heard of such a thing.
>
> > It's 2026. We generally shouldn't be formatting code manually. We have
> > better things to do.
>
> I agree! Stop changing it unnecessarily.
>
> > If you're going to insist on ad-hoc formatting of argument lists, you'll
> > need to be more specific about where and how you want it to be done. It
>
> Two tabs. That's it.
I've changed ext4_mpage_readpages() and f2fs_mpage_readpages() to use
your requested ad-hoc formatting. What else you want, I'm not sure. In
the code I maintain I just do it the standard way.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Matthew Wilcox <willy@infradead.org>
Cc: fsverity@lists.linux.dev, Christian Brauner <brauner@kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
Andrey Albershteyn <aalbersh@redhat.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Jaegeuk Kim <jaegeuk@kernel.org>, David Sterba <dsterba@suse.com>,
Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] fsverity speedup and memory usage optimization v5
Date: Wed, 4 Feb 2026 11:37:22 -0800 [thread overview]
Message-ID: <20260204193722.GB2193@sol> (raw)
In-Reply-To: <aYOZdUTrvIjq82AE@casper.infradead.org>
On Wed, Feb 04, 2026 at 07:09:41PM +0000, Matthew Wilcox wrote:
> On Wed, Feb 04, 2026 at 11:02:18AM -0800, Eric Biggers wrote:
> > Aligning to the opening bracket is the usual style as agreed on by the
> > kernel community.
>
> Says who? I've been part of the kernel community since 1997. I've
> never heard of such a thing.
>
> > It's 2026. We generally shouldn't be formatting code manually. We have
> > better things to do.
>
> I agree! Stop changing it unnecessarily.
>
> > If you're going to insist on ad-hoc formatting of argument lists, you'll
> > need to be more specific about where and how you want it to be done. It
>
> Two tabs. That's it.
I've changed ext4_mpage_readpages() and f2fs_mpage_readpages() to use
your requested ad-hoc formatting. What else you want, I'm not sure. In
the code I maintain I just do it the standard way.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-02-04 19:37 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 6:06 fsverity speedup and memory usage optimization v5 Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 6:06 ` [PATCH 01/11] fsverity: don't issue readahead for non-ENOENT errors from __filemap_get_folio Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 13:23 ` Jan Kara
2026-02-02 13:23 ` [f2fs-dev] " Jan Kara
2026-02-17 21:14 ` patchwork-bot+f2fs
2026-02-17 21:14 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
2026-02-02 6:06 ` [PATCH 02/11] readahead: push invalidate_lock out of page_cache_ra_unbounded Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 13:36 ` Jan Kara
2026-02-02 13:36 ` [f2fs-dev] " Jan Kara
2026-02-02 15:11 ` Matthew Wilcox
2026-02-02 15:11 ` [f2fs-dev] " Matthew Wilcox
2026-02-02 15:17 ` Christoph Hellwig
2026-02-02 15:17 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 21:04 ` Eric Biggers
2026-02-02 21:04 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-02 6:06 ` [PATCH 03/11] ext4: move ->read_folio and ->readahead to readahead.c Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 13:32 ` Jan Kara
2026-02-02 13:32 ` [f2fs-dev] " Jan Kara
2026-02-03 0:57 ` Theodore Tso
2026-02-03 0:57 ` [f2fs-dev] " Theodore Tso
2026-02-02 6:06 ` [PATCH 04/11] fsverity: kick off hash readahead at data I/O submission time Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 6:06 ` [PATCH 05/11] fsverity: deconstify the inode pointer in struct fsverity_info Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 6:06 ` [PATCH 06/11] fsverity: push out fsverity_info lookup Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 6:06 ` [PATCH 07/11] fs: consolidate fsverity_info lookup in buffer.c Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 13:38 ` Jan Kara
2026-02-02 13:38 ` [f2fs-dev] " Jan Kara
2026-02-02 6:06 ` [PATCH 08/11] ext4: consolidate fsverity_info lookup Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 6:06 ` [PATCH 09/11] f2fs: " Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 6:06 ` [PATCH 10/11] btrfs: " Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 6:06 ` [PATCH 11/11] fsverity: use a hashtable to find the fsverity_info Christoph Hellwig
2026-02-02 6:06 ` [f2fs-dev] " Christoph Hellwig
2026-02-02 21:14 ` fsverity speedup and memory usage optimization v5 Eric Biggers
2026-02-02 21:14 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-02 22:34 ` Eric Biggers
2026-02-02 22:34 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-03 5:36 ` Christoph Hellwig
2026-02-03 5:36 ` [f2fs-dev] " Christoph Hellwig
2026-02-04 14:54 ` Matthew Wilcox
2026-02-04 14:54 ` [f2fs-dev] " Matthew Wilcox
2026-02-04 19:02 ` Eric Biggers
2026-02-04 19:02 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-02-04 19:09 ` Matthew Wilcox
2026-02-04 19:09 ` [f2fs-dev] " Matthew Wilcox
2026-02-04 19:37 ` Eric Biggers [this message]
2026-02-04 19:37 ` Eric Biggers via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204193722.GB2193@sol \
--to=ebiggers@kernel.org \
--cc=aalbersh@redhat.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=dsterba@suse.com \
--cc=fsverity@lists.linux.dev \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.