* [merged mm-stable] mm-memory-handle-non-split-locks-correctly-in-zap_empty_pte_table.patch removed from -mm tree
@ 2026-02-06 23:48 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-02-06 23:48 UTC (permalink / raw)
To: mm-commits, zhengqi.arch, vbabka, surenb, rppt, mhocko,
lorenzo.stoakes, liam.howlett, david, akpm
The quilt patch titled
Subject: mm/memory: handle non-split locks correctly in zap_empty_pte_table()
has been removed from the -mm tree. Its filename was
mm-memory-handle-non-split-locks-correctly-in-zap_empty_pte_table.patch
This patch was dropped because it was merged into the mm-stable branch
of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: "David Hildenbrand (Red Hat)" <david@kernel.org>
Subject: mm/memory: handle non-split locks correctly in zap_empty_pte_table()
Date: Mon, 19 Jan 2026 23:07:08 +0100
While we handle pte_lockptr() == pmd_lockptr() correctly in
zap_pte_table_if_empty(), we don't handle it in zap_empty_pte_table(),
making the spin_trylock() always fail and forcing us onto the slow path.
So let's handle the scenario where pte_lockptr() == pmd_lockptr() better,
which can only happen if CONFIG_SPLIT_PTE_PTLOCKS is not set.
This is only relevant once we unlock CONFIG_PT_RECLAIM on architectures
that are not x86-64.
Link: https://lkml.kernel.org/r/20260119220708.3438514-3-david@kernel.org
Signed-off-by: David Hildenbrand (Red Hat) <david@kernel.org>
Reviewed-by: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/memory.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
--- a/mm/memory.c~mm-memory-handle-non-split-locks-correctly-in-zap_empty_pte_table
+++ a/mm/memory.c
@@ -1830,16 +1830,18 @@ static bool pte_table_reclaim_possible(u
return details && details->reclaim_pt && (end - start >= PMD_SIZE);
}
-static bool zap_empty_pte_table(struct mm_struct *mm, pmd_t *pmd, pmd_t *pmdval)
+static bool zap_empty_pte_table(struct mm_struct *mm, pmd_t *pmd,
+ spinlock_t *ptl, pmd_t *pmdval)
{
spinlock_t *pml = pmd_lockptr(mm, pmd);
- if (!spin_trylock(pml))
+ if (ptl != pml && !spin_trylock(pml))
return false;
*pmdval = pmdp_get(pmd);
pmd_clear(pmd);
- spin_unlock(pml);
+ if (ptl != pml)
+ spin_unlock(pml);
return true;
}
@@ -1931,7 +1933,7 @@ retry:
* from being repopulated by another thread.
*/
if (can_reclaim_pt && direct_reclaim && addr == end)
- direct_reclaim = zap_empty_pte_table(mm, pmd, &pmdval);
+ direct_reclaim = zap_empty_pte_table(mm, pmd, ptl, &pmdval);
add_mm_rss_vec(mm, rss);
lazy_mmu_mode_disable();
_
Patches currently in -mm which might be from david@kernel.org are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-02-06 23:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-06 23:48 [merged mm-stable] mm-memory-handle-non-split-locks-correctly-in-zap_empty_pte_table.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.