All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH v3 0/6] objtool: Fixup alternate feature relative addresses
@ 2026-02-09  8:48 Sathvika Vasireddy
  2026-02-09  8:48 ` [RFC PATCH v3 1/6] objtool/powerpc: Add build-time fixup of alternate feature branch targets Sathvika Vasireddy
                   ` (5 more replies)
  0 siblings, 6 replies; 10+ messages in thread
From: Sathvika Vasireddy @ 2026-02-09  8:48 UTC (permalink / raw)
  To: linux-kernel, linux-kbuild, linuxppc-dev
  Cc: nathan, masahiroy, kees, naveen, jpoimboe, peterz, npiggin, maddy,
	segher, christophe.leroy, mingo, mpe, sv, nsc

This patch series implements build-time fixup of alternate feature
relative addresses for powerpc.

Previously, Nicholas Piggin proposed a build-time solution using a
custom PowerPC tool [1], which provided the foundation for this approach.
The current implementation leverages objtool's existing ELF parsing
infrastructure to do the same.

This patchset applies atop powerpc/merge branch.

Links and History:
[1] Original PowerPC tool approach:
    http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170521010130.13552-1-npiggin@gmail.com/
[2] Initial RFC v1:
    https://lore.kernel.org/linuxppc-dev/20240422092206.147078-1-sv@linux.ibm.com/T/#t
[3] PowerPC instruction decoder borrowed from:
    https://lore.kernel.org/linuxppc-dev/bfa8364da047d8610a09458a1cd924a0566aedbb.1736955567.git.christophe.leroy@csgroup.eu/#Z31tools:objtool:arch:powerpc:decode.c

Testing:
Build and Boot tested on ppc64le, ppc64be, and ppc32be configs.

Changes in V3:
- Split code into individual patches
- Put objtool call into cmd_link_vmlinux
- Move HAVE_OBJTOOL_FEATURE_FIXUP from arch/Kconfig to 
  arch/powerpc/Kconfig 

Changes in V2:
- Added implementation support for ppc64 LE, BE, ppc32 BE.

Sathvika Vasireddy (6):
  objtool/powerpc: Add build-time fixup of alternate feature branch
    targets
  objtool: Set ELF_F_LAYOUT flag to preserve vmlinux segment layout
  objtool: Fix "can't find starting instruction" warnings on vmlinux
  objtool/powerpc: Skip jump destination analysis and unnanotated
    intra-function call warnings for --ftr-fixup
  kbuild: Add objtool integration for PowerPC feature fixups
  powerpc: Enable build-time feature fixup processing by default

 Makefile                                  |   7 +
 arch/powerpc/Kconfig                      |   3 +
 arch/powerpc/Makefile                     |   5 +
 arch/powerpc/include/asm/feature-fixups.h |   2 +-
 arch/powerpc/kernel/vmlinux.lds.S         |   8 +-
 arch/powerpc/lib/feature-fixups.c         |  12 -
 scripts/Makefile.lib                      |   4 +-
 scripts/Makefile.vmlinux                  |   8 +-
 tools/objtool/arch/powerpc/decode.c       |  15 +-
 tools/objtool/arch/powerpc/special.c      | 437 ++++++++++++++++++++++
 tools/objtool/builtin-check.c             |   2 +
 tools/objtool/check.c                     |  42 ++-
 tools/objtool/elf.c                       |   4 +
 tools/objtool/include/objtool/builtin.h   |   1 +
 tools/objtool/include/objtool/special.h   |  56 +++
 tools/objtool/special.c                   |  29 ++
 16 files changed, 611 insertions(+), 24 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [RFC PATCH v3 1/6] objtool/powerpc: Add build-time fixup of alternate feature branch targets
@ 2026-02-10  7:55 kernel test robot
  0 siblings, 0 replies; 10+ messages in thread
From: kernel test robot @ 2026-02-10  7:55 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp

:::::: 
:::::: Manual check reason: "only suspicious fbc files changed"
:::::: 

BCC: lkp@intel.com
CC: llvm@lists.linux.dev
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260209084820.57298-2-sv@linux.ibm.com>
References: <20260209084820.57298-2-sv@linux.ibm.com>
TO: Sathvika Vasireddy <sv@linux.ibm.com>

Hi Sathvika,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes linus/master v6.19 next-20260209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sathvika-Vasireddy/objtool-powerpc-Add-build-time-fixup-of-alternate-feature-branch-targets/20260209-165156
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20260209084820.57298-2-sv%40linux.ibm.com
patch subject: [RFC PATCH v3 1/6] objtool/powerpc: Add build-time fixup of alternate feature branch targets
:::::: branch date: 23 hours ago
:::::: commit date: 23 hours ago
config: powerpc-randconfig-002-20260210 (https://download.01.org/0day-ci/archive/20260210/202602101507.3iIWJO45-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260210/202602101507.3iIWJO45-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202602101507.3iIWJO45-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/powerpc/special.c:289:9: error: variable 'n' set but not used [-Werror,-Wunused-but-set-variable]
     289 |         size_t n = 0;
         |                ^
   1 error generated.
   make[6]: *** [tools/build/Makefile.build:86: tools/objtool/arch/powerpc/special.o] Error 1 shuffle=3996209845
   make[6]: Target '__build' not remade because of errors.
   make[5]: *** [tools/build/Makefile.build:142: arch/powerpc] Error 2 shuffle=3996209845
   make[5]: Target '__build' not remade because of errors.
   make[4]: *** [Makefile:104: tools/objtool/objtool-in.o] Error 2 shuffle=3996209845
   make[4]: Target 'all' not remade because of errors.
   make[3]: *** [Makefile:74: objtool] Error 2 shuffle=3996209845
   make[2]: *** [Makefile:1483: tools/objtool] Error 2 shuffle=3996209845
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:248: __sub-make] Error 2 shuffle=3996209845
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:248: __sub-make] Error 2 shuffle=3996209845
   make: Target 'prepare' not remade because of errors.

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-02-10 21:20 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-09  8:48 [RFC PATCH v3 0/6] objtool: Fixup alternate feature relative addresses Sathvika Vasireddy
2026-02-09  8:48 ` [RFC PATCH v3 1/6] objtool/powerpc: Add build-time fixup of alternate feature branch targets Sathvika Vasireddy
2026-02-10  8:13   ` kernel test robot
2026-02-09  8:48 ` [RFC PATCH v3 2/6] objtool: Set ELF_F_LAYOUT flag to preserve vmlinux segment layout Sathvika Vasireddy
2026-02-09  8:48 ` [RFC PATCH v3 3/6] objtool: Fix "can't find starting instruction" warnings on vmlinux Sathvika Vasireddy
2026-02-09  8:48 ` [RFC PATCH v3 4/6] objtool/powerpc: Skip jump destination analysis and unnanotated intra-function call warnings for --ftr-fixup Sathvika Vasireddy
2026-02-09  8:48 ` [RFC PATCH v3 5/6] kbuild: Add objtool integration for PowerPC feature fixups Sathvika Vasireddy
2026-02-09  8:48 ` [RFC PATCH v3 6/6] powerpc: Enable build-time feature fixup processing by default Sathvika Vasireddy
2026-02-10 21:20   ` Nathan Chancellor
  -- strict thread matches above, loose matches on Subject: below --
2026-02-10  7:55 [RFC PATCH v3 1/6] objtool/powerpc: Add build-time fixup of alternate feature branch targets kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.