From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>,
Troy Lee <troy_lee@aspeedtech.com>,
Kane Chen <kane_chen@aspeedtech.com>,
"nabihestefan@google.com" <nabihestefan@google.com>,
Joe Komlodi <komlodi@google.com>,
Patrick Venture <venture@google.com>,
Titus Rwantare <titusr@google.com>
Subject: [PATCH v4 10/20] hw/i3c/dw-i3c: Use 32 bits on MMIO writes
Date: Mon, 9 Feb 2026 09:16:45 +0000 [thread overview]
Message-ID: <20260209091629.823457-11-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260209091629.823457-1-jamin_lin@aspeedtech.com>
The registers are only 32 bits wide, so we should cast the 64-bit value
passed in to only be 32 bits wide.
Signed-off-by: Joe Komlodi <komlodi@google.com>
Reviewed-by: Patrick Venture <venture@google.com>
Reviewed-by: Titus Rwantare <titusr@google.com>
Reviewed-by: Jamin Lin <jamin_lin@aspeedtech.com>
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/i3c/dw-i3c.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i3c/dw-i3c.c b/hw/i3c/dw-i3c.c
index e20244de2c..9dc71aa3d8 100644
--- a/hw/i3c/dw-i3c.c
+++ b/hw/i3c/dw-i3c.c
@@ -363,10 +363,11 @@ static void dw_i3c_write(void *opaque, hwaddr offset, uint64_t value,
{
DWI3C *s = DW_I3C(opaque);
uint32_t addr = offset >> 2;
+ uint32_t val32 = (uint32_t)value;
trace_dw_i3c_write(s->id, offset, value);
- value &= ~dw_i3c_ro[addr];
+ val32 &= ~dw_i3c_ro[addr];
switch (addr) {
case R_HW_CAPABILITY:
case R_RESPONSE_QUEUE_PORT:
@@ -392,7 +393,7 @@ static void dw_i3c_write(void *opaque, hwaddr offset, uint64_t value,
case R_RESET_CTRL:
break;
default:
- s->regs[addr] = value;
+ s->regs[addr] = val32;
break;
}
}
--
2.43.0
next prev parent reply other threads:[~2026-02-09 9:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 9:16 [PATCH v4 00/20] i3c: aspeed: Add I3C support Jamin Lin
2026-02-09 9:16 ` [PATCH v4 01/20] hw/misc/aspeed_i3c: Move to i3c directory Jamin Lin
2026-02-09 9:16 ` [PATCH v4 02/20] hw/i3c: Add bus support Jamin Lin
2026-02-09 9:49 ` Mark Cave-Ayland
2026-02-10 5:57 ` Jamin Lin
2026-02-10 9:16 ` Mark Cave-Ayland
2026-02-10 9:21 ` Jamin Lin
2026-02-09 9:16 ` [PATCH v4 03/20] hw/i3c: Split DesignWare I3C out of Aspeed I3C Jamin Lin
2026-02-09 9:57 ` Mark Cave-Ayland
2026-02-10 6:22 ` Jamin Lin
2026-02-09 9:16 ` [PATCH v4 04/20] hw/i3c/dw-i3c: Add more register fields Jamin Lin
2026-02-09 9:16 ` [PATCH v4 05/20] hw/i3c/aspeed_i3c: " Jamin Lin
2026-02-09 9:16 ` [PATCH v4 06/20] hw/i3c/dw-i3c: Add more reset values Jamin Lin
2026-02-09 9:16 ` [PATCH v4 07/20] hw/i3c/aspeed_i3c: Add register RO field masks Jamin Lin
2026-02-09 9:16 ` [PATCH v4 08/20] hw/i3c/dw-i3c: " Jamin Lin
2026-02-09 9:16 ` [PATCH v4 09/20] hw/i3c/dw-i3c: Treat more registers as read-as-zero Jamin Lin
2026-02-09 9:16 ` Jamin Lin [this message]
2026-02-09 9:16 ` [PATCH v4 11/20] hw/i3c/dw-i3c: Add IRQ MMIO behavior Jamin Lin
2026-02-09 9:16 ` [PATCH v4 12/20] hw/i3c/dw-i3c: Add data TX and RX Jamin Lin
2026-02-09 9:16 ` [PATCH v4 13/20] hw/i3c/dw-i3c: Add IBI handling Jamin Lin
2026-02-09 9:16 ` [PATCH v4 14/20] hw/i3c/dw-i3c: Add ctrl MMIO handling Jamin Lin
2026-02-09 9:16 ` [PATCH v4 15/20] hw/i3c/dw-i3c: Add controller resets Jamin Lin
2026-02-09 9:16 ` [PATCH v4 16/20] hw/i3c/aspeed: Add I3C bus get function Jamin Lin
2026-02-09 9:16 ` [PATCH v4 17/20] hw/i3c: Add Mock target Jamin Lin
2026-02-09 10:01 ` Mark Cave-Ayland
2026-02-10 7:45 ` Jamin Lin
2026-02-09 9:16 ` [PATCH v4 18/20] hw/arm/aspeed: Build with I3C_DEVICES Jamin Lin
2026-02-09 9:16 ` [PATCH v4 19/20] hw/i3c: Add hotplug support Jamin Lin
2026-02-09 9:16 ` [PATCH v4 20/20] tests/functional/arm/test_aspeed_ast2600_sdk: Add i3c functional test Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260209091629.823457-11-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=berrange@redhat.com \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=komlodi@google.com \
--cc=leetroy@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=nabihestefan@google.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=titusr@google.com \
--cc=troy_lee@aspeedtech.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.