All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] fat: Add FS_IOC_GETFSLABEL / FS_IOC_SETFSLABEL ioctls
@ 2026-02-10 22:23 Ethan Ferguson
  2026-02-10 22:23 ` [PATCH 1/2] fat: Add FS_IOC_GETFSLABEL ioctl Ethan Ferguson
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Ethan Ferguson @ 2026-02-10 22:23 UTC (permalink / raw)
  To: hirofumi; +Cc: linux-fsdevel, linux-kernel, Ethan Ferguson

Add support for reading / writing to the volume label of a FAT filesystem
via the FS_IOC_GETFSLABEL and FS_IOC_SETFSLABEL ioctls.

Volume label changes are persisted in the volume label dentry in the root
directory as well as the bios parameter block.

Some notes about possile deficiencies with this patch:
1. If there is no current volume label directory entry present, one is not
created.
2. Changes to the volume label are not checked for validity against the
current codepage.

Ethan Ferguson (2):
  fat: Add FS_IOC_GETFSLABEL ioctl
  fat: Add FS_IOC_SETFSLABEL ioctl

 fs/fat/dir.c   | 22 ++++++++++++++++++++++
 fs/fat/fat.h   |  2 ++
 fs/fat/file.c  | 28 ++++++++++++++++++++++++++++
 fs/fat/inode.c | 26 ++++++++++++++++++++++++--
 4 files changed, 76 insertions(+), 2 deletions(-)


base-commit: 9f2693489ef8558240d9e80bfad103650daed0af
-- 
2.53.0


^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] fat: Add FS_IOC_GETFSLABEL ioctl
  2026-02-10 22:23 ` [PATCH 1/2] fat: Add FS_IOC_GETFSLABEL ioctl Ethan Ferguson
@ 2026-02-11 10:57 ` Dan Carpenter
  -1 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2026-02-11  9:15 UTC (permalink / raw)
  To: oe-kbuild; +Cc: lkp, Dan Carpenter

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20260210222310.357755-2-ethan.ferguson@zetier.com>
References: <20260210222310.357755-2-ethan.ferguson@zetier.com>
TO: Ethan Ferguson <ethan.ferguson@zetier.com>
TO: hirofumi@mail.parknet.co.jp
CC: linux-fsdevel@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Ethan Ferguson <ethan.ferguson@zetier.com>

Hi Ethan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 9f2693489ef8558240d9e80bfad103650daed0af]

url:    https://github.com/intel-lab-lkp/linux/commits/Ethan-Ferguson/fat-Add-FS_IOC_GETFSLABEL-ioctl/20260211-062606
base:   9f2693489ef8558240d9e80bfad103650daed0af
patch link:    https://lore.kernel.org/r/20260210222310.357755-2-ethan.ferguson%40zetier.com
patch subject: [PATCH 1/2] fat: Add FS_IOC_GETFSLABEL ioctl
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: riscv-randconfig-r071-20260211 (https://download.01.org/0day-ci/archive/20260211/202602111747.QIBXIwpw-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 9.5.0
smatch version: v0.5.0-8994-gd50c5a4c

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202602111747.QIBXIwpw-lkp@intel.com/

smatch warnings:
fs/fat/file.c:160 fat_ioctl_get_volume_label() warn: maybe return -EFAULT instead of the bytes remaining?

vim +160 fs/fat/file.c

f663b5b38fffeb Wentao Wang    2018-08-21  155  
5fc1746d68b8fb Ethan Ferguson 2026-02-10  156  static int fat_ioctl_get_volume_label(struct inode *inode, char __user *arg)
5fc1746d68b8fb Ethan Ferguson 2026-02-10  157  {
5fc1746d68b8fb Ethan Ferguson 2026-02-10  158  	struct msdos_sb_info *sbi = MSDOS_SB(inode->i_sb);
5fc1746d68b8fb Ethan Ferguson 2026-02-10  159  
5fc1746d68b8fb Ethan Ferguson 2026-02-10 @160  	return copy_to_user(arg, sbi->vol_label, MSDOS_NAME);
5fc1746d68b8fb Ethan Ferguson 2026-02-10  161  }
5fc1746d68b8fb Ethan Ferguson 2026-02-10  162  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-02-11 13:25 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-10 22:23 [PATCH 0/2] fat: Add FS_IOC_GETFSLABEL / FS_IOC_SETFSLABEL ioctls Ethan Ferguson
2026-02-10 22:23 ` [PATCH 1/2] fat: Add FS_IOC_GETFSLABEL ioctl Ethan Ferguson
2026-02-10 22:23 ` [PATCH 2/2] fat: Add FS_IOC_SETFSLABEL ioctl Ethan Ferguson
2026-02-11  2:26   ` kernel test robot
2026-02-11  9:21 ` [syzbot ci] Re: fat: Add FS_IOC_GETFSLABEL / FS_IOC_SETFSLABEL ioctls syzbot ci
2026-02-11 13:25 ` [PATCH 0/2] " OGAWA Hirofumi
  -- strict thread matches above, loose matches on Subject: below --
2026-02-11  9:15 [PATCH 1/2] fat: Add FS_IOC_GETFSLABEL ioctl kernel test robot
2026-02-11 10:57 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.