All of lore.kernel.org
 help / color / mirror / Atom feed
From: MidG971 <midgy971@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	heiko@sntech.de, jonas@kwiboo.se, MidG971 <midgy971@gmail.com>,
	Claude <noreply@anthropic.com>
Subject: [PATCH] arm64: dts: rockchip: rock-3b: Add phy-supply to pcie30phy
Date: Fri, 13 Feb 2026 16:14:52 +0100	[thread overview]
Message-ID: <20260213151452.535527-1-midgy971@gmail.com> (raw)

The PCIe 3.0 PHY requires its power supply regulator to be enabled
before initialization. Without the phy-supply property, the PHY
driver does not ensure the regulator is enabled, causing SRAM
initialization to timeout with "lock failed" errors:

  phy phy-fe8c0000.phy.1: phy poweron failed --> -110
  rockchip-snps-pcie3-phy fe8c0000.phy: PCIe3PHY lock failed 0x6890000
  rockchip-pcie fe280000.pcie: phy init failed: -110

This results in NVMe devices in the M.2 slot not being detected.

Add phy-supply referencing vcc3v3_pi6c_03 regulator (which controls
the PI6C PCIe clock generator power via GPIO0_D4) to ensure proper
power sequencing during PHY initialization.

Fixes: 846ef7748fa9 ("arm64: dts: rockchip: Add Radxa ROCK 3B")
Signed-off-by: MidG971 <midgy971@gmail.com>
Co-developed-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
---
 arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
index c5f67dd6dfd9..a1b2c3d4e5f6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
@@ -404,6 +404,7 @@ &pcie2x1 {
 };

 &pcie30phy {
+	phy-supply = <&vcc3v3_pi6c_03>;
 	status = "okay";
 };

--
2.39.5


WARNING: multiple messages have this Message-ID (diff)
From: MidG971 <midgy971@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	heiko@sntech.de, jonas@kwiboo.se, MidG971 <midgy971@gmail.com>,
	Claude <noreply@anthropic.com>
Subject: [PATCH] arm64: dts: rockchip: rock-3b: Add phy-supply to pcie30phy
Date: Fri, 13 Feb 2026 16:14:52 +0100	[thread overview]
Message-ID: <20260213151452.535527-1-midgy971@gmail.com> (raw)

The PCIe 3.0 PHY requires its power supply regulator to be enabled
before initialization. Without the phy-supply property, the PHY
driver does not ensure the regulator is enabled, causing SRAM
initialization to timeout with "lock failed" errors:

  phy phy-fe8c0000.phy.1: phy poweron failed --> -110
  rockchip-snps-pcie3-phy fe8c0000.phy: PCIe3PHY lock failed 0x6890000
  rockchip-pcie fe280000.pcie: phy init failed: -110

This results in NVMe devices in the M.2 slot not being detected.

Add phy-supply referencing vcc3v3_pi6c_03 regulator (which controls
the PI6C PCIe clock generator power via GPIO0_D4) to ensure proper
power sequencing during PHY initialization.

Fixes: 846ef7748fa9 ("arm64: dts: rockchip: Add Radxa ROCK 3B")
Signed-off-by: MidG971 <midgy971@gmail.com>
Co-developed-by: Claude <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
---
 arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
index c5f67dd6dfd9..a1b2c3d4e5f6 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
@@ -404,6 +404,7 @@ &pcie2x1 {
 };

 &pcie30phy {
+	phy-supply = <&vcc3v3_pi6c_03>;
 	status = "okay";
 };

--
2.39.5

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

             reply	other threads:[~2026-02-13 15:14 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 15:14 MidG971 [this message]
2026-02-13 15:14 ` [PATCH] arm64: dts: rockchip: rock-3b: Add phy-supply to pcie30phy MidG971
2026-02-13 16:10 ` Shawn Lin
2026-02-13 16:10   ` Shawn Lin
2026-02-13 17:19   ` Jonas Karlman
2026-02-13 17:19     ` Jonas Karlman
2026-03-04 13:29 ` [PATCH v2] arm64: dts: rockchip: rock-3b: Model PI6C20100 as gated-fixed-clock MidG971
2026-03-04 13:29   ` MidG971
2026-03-04 13:57   ` Shawn Lin
2026-03-04 13:57     ` Shawn Lin
     [not found]     ` <shawn-reply-message-id>
2026-03-19 10:19       ` MidG971
2026-03-19 10:19         ` MidG971
2026-03-19 12:27         ` Shawn Lin
2026-03-19 12:27           ` Shawn Lin
2026-03-19 14:51   ` [PATCH v4] " MidG971
2026-03-19 14:51     ` MidG971
2026-03-20  8:48     ` Heiko Stuebner
2026-03-20  8:48       ` Heiko Stuebner
2026-03-20  9:44       ` [PATCH v5] " MidG971
2026-03-20  9:44         ` MidG971
2026-03-24 17:04         ` Heiko Stuebner
2026-03-24 17:04           ` Heiko Stuebner
2026-03-24 17:15           ` Jonas Karlman
2026-03-24 17:15             ` Jonas Karlman
2026-03-24 22:27             ` Heiko Stuebner
2026-03-24 22:27               ` Heiko Stuebner
2026-03-27  9:07               ` Midgy Balon
2026-03-27  9:07                 ` Midgy Balon
2026-03-20 10:28       ` [PATCH v4] " Midgy Balon
2026-03-20 10:28         ` Midgy Balon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260213151452.535527-1-midgy971@gmail.com \
    --to=midgy971@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jonas@kwiboo.se \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=noreply@anthropic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.