[PATCH v1] configs: visionfive2: Fix the name of VisionFive 2 Lite DT

[PATCH v1] configs: visionfive2: Fix the name of VisionFive 2 Lite DT

[Hal Feng]

The name of VisionFive 2 Lite DT was set incorrectly. Fix it.

Fixes: 4ea3acc000a7 ("configs: visionfive2: Add VisionFive 2 Lite DT to OF_LIST")
Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
---
 configs/starfive_visionfive2_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig
index ef4acf7c1db..614a003c971 100644
--- a/configs/starfive_visionfive2_defconfig
+++ b/configs/starfive_visionfive2_defconfig
@@ -80,7 +80,7 @@ CONFIG_WGET_HTTPS=y
 CONFIG_CMD_BOOTSTAGE=y
 CONFIG_OF_BOARD=y
 CONFIG_DEVICE_TREE_INCLUDES="starfive-visionfive2-u-boot.dtsi"
-CONFIG_OF_LIST="starfive/jh7110-deepcomputing-fml13v01 starfive/jh7110-milkv-mars starfive/jh7110-milkv-marscm-emmc starfive/jh7110-milkv-marscm-lite starfive/jh7110-pine64-star64 starfive/jh7110-starfive-visionfive-2-v1.2a starfive/jh7110-starfive-visionfive-2-v1.3b configs/starfive_visionfive2_defconfig"
+CONFIG_OF_LIST="starfive/jh7110-deepcomputing-fml13v01 starfive/jh7110-milkv-mars starfive/jh7110-milkv-marscm-emmc starfive/jh7110-milkv-marscm-lite starfive/jh7110-pine64-star64 starfive/jh7110-starfive-visionfive-2-lite starfive/jh7110-starfive-visionfive-2-v1.2a starfive/jh7110-starfive-visionfive-2-v1.3b"
 CONFIG_MULTI_DTB_FIT=y
 CONFIG_ENV_OVERWRITE=y
 CONFIG_ENV_IS_IN_SPI_FLASH=y
-- 
2.43.2

Re: [PATCH v1] configs: visionfive2: Fix the name of VisionFive 2 Lite DT

[E Shattow]

Hi Hal,

On 2/14/26 01:14, Hal Feng wrote:
> The name of VisionFive 2 Lite DT was set incorrectly. Fix it.
> 
> Fixes: 4ea3acc000a7 ("configs: visionfive2: Add VisionFive 2 Lite DT to OF_LIST")
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
>  configs/starfive_visionfive2_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig
> index ef4acf7c1db..614a003c971 100644
> --- a/configs/starfive_visionfive2_defconfig
> +++ b/configs/starfive_visionfive2_defconfig
> @@ -80,7 +80,7 @@ CONFIG_WGET_HTTPS=y
>  CONFIG_CMD_BOOTSTAGE=y
>  CONFIG_OF_BOARD=y
>  CONFIG_DEVICE_TREE_INCLUDES="starfive-visionfive2-u-boot.dtsi"
> -CONFIG_OF_LIST="starfive/jh7110-deepcomputing-fml13v01 starfive/jh7110-milkv-mars starfive/jh7110-milkv-marscm-emmc starfive/jh7110-milkv-marscm-lite starfive/jh7110-pine64-star64 starfive/jh7110-starfive-visionfive-2-v1.2a starfive/jh7110-starfive-visionfive-2-v1.3b configs/starfive_visionfive2_defconfig"
> +CONFIG_OF_LIST="starfive/jh7110-deepcomputing-fml13v01 starfive/jh7110-milkv-mars starfive/jh7110-milkv-marscm-emmc starfive/jh7110-milkv-marscm-lite starfive/jh7110-pine64-star64 starfive/jh7110-starfive-visionfive-2-lite starfive/jh7110-starfive-visionfive-2-v1.2a starfive/jh7110-starfive-visionfive-2-v1.3b"
>  CONFIG_MULTI_DTB_FIT=y
>  CONFIG_ENV_OVERWRITE=y
>  CONFIG_ENV_IS_IN_SPI_FLASH=y

NAK

That fixes tag is not valid because the problem is responsibility of Leo
to revert and re-apply. Your series does not have this defect. I care
about this because I am listed as a reviewer.

Leo: fix this error with revert of all affected commits and do it again
correctly instead of authors having to submit a "fix" to a bad merge.

I would like to know why this happened?

Further, when there are ANY changes I would say that the person making
that change MUST add their tag to take responsibility;  it is not
acceptable to me to be tagged on a commit that has been silently
altered. The "forge" (gitlab) lists who committed the series but there
is no indication or comment about what happened here where it matters in
the git repository log.

-E

Re: [PATCH v1] configs: visionfive2: Fix the name of VisionFive 2 Lite DT

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 3047 bytes --]

On Sat, Feb 14, 2026 at 03:02:38AM -0800, E Shattow wrote:
> Hi Hal,
> 
> On 2/14/26 01:14, Hal Feng wrote:
> > The name of VisionFive 2 Lite DT was set incorrectly. Fix it.
> > 
> > Fixes: 4ea3acc000a7 ("configs: visionfive2: Add VisionFive 2 Lite DT to OF_LIST")
> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> > ---
> >  configs/starfive_visionfive2_defconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig
> > index ef4acf7c1db..614a003c971 100644
> > --- a/configs/starfive_visionfive2_defconfig
> > +++ b/configs/starfive_visionfive2_defconfig
> > @@ -80,7 +80,7 @@ CONFIG_WGET_HTTPS=y
> >  CONFIG_CMD_BOOTSTAGE=y
> >  CONFIG_OF_BOARD=y
> >  CONFIG_DEVICE_TREE_INCLUDES="starfive-visionfive2-u-boot.dtsi"
> > -CONFIG_OF_LIST="starfive/jh7110-deepcomputing-fml13v01 starfive/jh7110-milkv-mars starfive/jh7110-milkv-marscm-emmc starfive/jh7110-milkv-marscm-lite starfive/jh7110-pine64-star64 starfive/jh7110-starfive-visionfive-2-v1.2a starfive/jh7110-starfive-visionfive-2-v1.3b configs/starfive_visionfive2_defconfig"
> > +CONFIG_OF_LIST="starfive/jh7110-deepcomputing-fml13v01 starfive/jh7110-milkv-mars starfive/jh7110-milkv-marscm-emmc starfive/jh7110-milkv-marscm-lite starfive/jh7110-pine64-star64 starfive/jh7110-starfive-visionfive-2-lite starfive/jh7110-starfive-visionfive-2-v1.2a starfive/jh7110-starfive-visionfive-2-v1.3b"
> >  CONFIG_MULTI_DTB_FIT=y
> >  CONFIG_ENV_OVERWRITE=y
> >  CONFIG_ENV_IS_IN_SPI_FLASH=y
> 
> NAK
> 
> That fixes tag is not valid because the problem is responsibility of Leo
> to revert and re-apply. Your series does not have this defect. I care
> about this because I am listed as a reviewer.
> 
> Leo: fix this error with revert of all affected commits and do it again
> correctly instead of authors having to submit a "fix" to a bad merge.
> 
> I would like to know why this happened?
> 
> Further, when there are ANY changes I would say that the person making
> that change MUST add their tag to take responsibility;  it is not
> acceptable to me to be tagged on a commit that has been silently
> altered. The "forge" (gitlab) lists who committed the series but there
> is no indication or comment about what happened here where it matters in
> the git repository log.

This final paragraph is what I want to stress. If something needs to be
reworked to apply, review tags should be dropped. It really should get
posted again for review (or ask the submitter to rebase) as well if it
wasn't trivial. With b4 you can make sure that if there's problems with
the merge, you instead have the merge resolution in its own commit, for
example:
b4 shazam -S -M series-message-id --merge-base old-commit-series-is-based-on
This will in turn apply the whole series in its own branch on top of the
commit passed to --merge-base, and then merge that commit to the top of
tree. And then you resolve the merge errors there.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]