From: Stephen Hemminger <stephen@networkplumber.org>
To: spinler@cesnet.cz
Cc: dev@dpdk.org
Subject: Re: [PATCH 5/7] net/nfb: support setting Rx MTU
Date: Wed, 18 Feb 2026 10:20:58 -0800 [thread overview]
Message-ID: <20260218102058.53296e9e@phoenix.local> (raw)
In-Reply-To: <20260206170435.302184-6-spinler@cesnet.cz>
On Fri, 6 Feb 2026 18:04:33 +0100
spinler@cesnet.cz wrote:
> +static int
> +nfb_eth_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> +{
> + unsigned int i;
> + struct nc_rxmac_status status;
> + struct pmd_internals *intl = dev->process_private;
> + uint16_t frame_length_max_capable;
> +
> + mtu += RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
> +
Since mtu is 16 bit value, you need to use uint32_t to avoid
overflow.
Something like:
+ uint32_t frame_len = (uint32_t)mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
+ if (frame_len > priv->frame_len_max_cap)
+ return -EINVAL;
+ for (i = 0; i < intl->max_rxmac; ++i)
+ nc_rxmac_set_frame_length(intl->rxmac[i], frame_len, RXMAC_FRAME_LENGTH_MAX);
next prev parent reply other threads:[~2026-02-18 18:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 17:04 [PATCH 0/7] net/nfb: ethernet enhancements spinler
2026-02-06 17:04 ` [PATCH 1/7] net/nfb: use MAC address assigned to card spinler
2026-02-06 17:04 ` [PATCH 2/7] net/nfb: get correct link speed spinler
2026-02-06 17:04 ` [PATCH 3/7] net/nfb: support real link-up/down config spinler
2026-02-06 17:04 ` [PATCH 4/7] net/nfb: support setting RS-FEC mode spinler
2026-02-06 17:04 ` [PATCH 5/7] net/nfb: support setting Rx MTU spinler
2026-02-18 18:20 ` Stephen Hemminger [this message]
2026-02-19 6:20 ` Martin Spinler
2026-02-06 17:04 ` [PATCH 6/7] net/nfb: read total stats from macs spinler
2026-02-06 17:04 ` [PATCH 7/7] doc/nfb: update release notes for nfb driver spinler
2026-02-17 4:37 ` Stephen Hemminger
2026-02-10 0:33 ` [PATCH 0/7] net/nfb: ethernet enhancements Stephen Hemminger
2026-02-12 18:52 ` Stephen Hemminger
2026-02-17 11:03 ` [PATCH v2 0/6] " spinler
2026-02-17 11:03 ` [PATCH v2 1/6] net/nfb: use MAC address assigned to card spinler
2026-02-17 11:03 ` [PATCH v2 2/6] net/nfb: get correct link speed spinler
2026-02-17 11:03 ` [PATCH v2 3/6] net/nfb: support real link-up/down config spinler
2026-02-17 11:03 ` [PATCH v2 4/6] net/nfb: support setting RS-FEC mode spinler
2026-02-17 11:03 ` [PATCH v2 5/6] net/nfb: support setting Rx MTU spinler
2026-02-17 11:03 ` [PATCH v2 6/6] net/nfb: read total stats from macs spinler
2026-02-18 18:21 ` [PATCH v2 0/6] net/nfb: ethernet enhancements Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260218102058.53296e9e@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=spinler@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.