* [norov:for-620 5/15] drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3711:26: error: 'flow_id' undeclared; did you mean 'flowi'?
@ 2026-02-21 7:18 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-02-21 7:18 UTC (permalink / raw)
To: Yury Norov; +Cc: oe-kbuild-all
tree: https://github.com/norov/linux for-620
head: 3b794289e60f9e1cc26d239bef32c93543213772
commit: d40765a7bbafbae8f4c7546d5ffdb1f97408f1ab [5/15] i40e: drop useless bitmap_weight() call
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20260221/202602211503.PyHhbyEt-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260221/202602211503.PyHhbyEt-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602211503.PyHhbyEt-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/bitmap.h:11,
from include/linux/linkmode.h:4,
from drivers/net/ethernet/intel/i40e/i40e.h:7,
from drivers/net/ethernet/intel/i40e/i40e_txrx_common.h:7,
from drivers/net/ethernet/intel/i40e/i40e_ethtool.c:9:
drivers/net/ethernet/intel/i40e/i40e_ethtool.c: In function 'i40e_set_rxfh_fields':
>> drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3711:26: error: 'flow_id' undeclared (first use in this function); did you mean 'flowi'?
3711 | for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) {
| ^~~~~~~
include/linux/find.h:586:15: note: in definition of macro 'for_each_set_bit'
586 | for ((bit) = 0; (bit) = find_next_bit((addr), (size), (bit)), (bit) < (size); (bit)++)
| ^~~
drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3711:26: note: each undeclared identifier is reported only once for each function it appears in
3711 | for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) {
| ^~~~~~~
include/linux/find.h:586:15: note: in definition of macro 'for_each_set_bit'
586 | for ((bit) = 0; (bit) = find_next_bit((addr), (size), (bit)), (bit) < (size); (bit)++)
| ^~~
include/linux/find.h:586:69: warning: left-hand operand of comma expression has no effect [-Wunused-value]
586 | for ((bit) = 0; (bit) = find_next_bit((addr), (size), (bit)), (bit) < (size); (bit)++)
| ^
drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3711:9: note: in expansion of macro 'for_each_set_bit'
3711 | for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) {
| ^~~~~~~~~~~~~~~~
vim +3711 drivers/net/ethernet/intel/i40e/i40e_ethtool.c
eb0dd6e4a3b3df5 Carolyn Wyborny 2016-07-27 3614
3b32c9932853e11 Slawomir Laba 2022-10-24 3615 #define FLOW_PCTYPES_SIZE 64
5a28983710b7396 Jakub Kicinski 2025-06-14 3616 static int i40e_set_rxfh_fields(struct net_device *netdev,
5a28983710b7396 Jakub Kicinski 2025-06-14 3617 const struct ethtool_rxfh_fields *nfc,
5a28983710b7396 Jakub Kicinski 2025-06-14 3618 struct netlink_ext_ack *extack)
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3619 {
5a28983710b7396 Jakub Kicinski 2025-06-14 3620 struct i40e_netdev_priv *np = netdev_priv(netdev);
5a28983710b7396 Jakub Kicinski 2025-06-14 3621 struct i40e_vsi *vsi = np->vsi;
5a28983710b7396 Jakub Kicinski 2025-06-14 3622 struct i40e_pf *pf = vsi->back;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3623 struct i40e_hw *hw = &pf->hw;
272cdaf2472ab77 Shannon Nelson 2016-02-17 3624 u64 hena = (u64)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(0)) |
272cdaf2472ab77 Shannon Nelson 2016-02-17 3625 ((u64)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(1)) << 32);
3b32c9932853e11 Slawomir Laba 2022-10-24 3626 DECLARE_BITMAP(flow_pctypes, FLOW_PCTYPES_SIZE);
eb0dd6e4a3b3df5 Carolyn Wyborny 2016-07-27 3627 u64 i_set, i_setc;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3628
3b32c9932853e11 Slawomir Laba 2022-10-24 3629 bitmap_zero(flow_pctypes, FLOW_PCTYPES_SIZE);
3b32c9932853e11 Slawomir Laba 2022-10-24 3630
70756d0a4727fe8 Ivan Vecera 2023-11-13 3631 if (test_bit(I40E_FLAG_MFP_ENA, pf->flags)) {
83d14c595e011f9 Carolyn Wyborny 2017-06-07 3632 dev_err(&pf->pdev->dev,
83d14c595e011f9 Carolyn Wyborny 2017-06-07 3633 "Change of RSS hash input set is not supported when MFP mode is enabled\n");
83d14c595e011f9 Carolyn Wyborny 2017-06-07 3634 return -EOPNOTSUPP;
83d14c595e011f9 Carolyn Wyborny 2017-06-07 3635 }
83d14c595e011f9 Carolyn Wyborny 2017-06-07 3636
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3637 /* RSS does not support anything other than hashing
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3638 * to queues on src and dst IPs and ports
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3639 */
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3640 if (nfc->data & ~(RXH_IP_SRC | RXH_IP_DST |
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3641 RXH_L4_B_0_1 | RXH_L4_B_2_3))
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3642 return -EINVAL;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3643
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3644 switch (nfc->flow_type) {
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3645 case TCP_V4_FLOW:
141d0c9037ca57d Jacob Keller 2025-05-05 3646 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV4_TCP, flow_pctypes);
0e8b9fdd40fe65b Ivan Vecera 2023-11-13 3647 if (test_bit(I40E_HW_CAP_MULTI_TCP_UDP_RSS_PCTYPE,
0e8b9fdd40fe65b Ivan Vecera 2023-11-13 3648 pf->hw.caps))
141d0c9037ca57d Jacob Keller 2025-05-05 3649 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV4_TCP_SYN_NO_ACK,
3b32c9932853e11 Slawomir Laba 2022-10-24 3650 flow_pctypes);
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3651 break;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3652 case TCP_V6_FLOW:
141d0c9037ca57d Jacob Keller 2025-05-05 3653 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV6_TCP, flow_pctypes);
0e8b9fdd40fe65b Ivan Vecera 2023-11-13 3654 if (test_bit(I40E_HW_CAP_MULTI_TCP_UDP_RSS_PCTYPE,
0e8b9fdd40fe65b Ivan Vecera 2023-11-13 3655 pf->hw.caps))
141d0c9037ca57d Jacob Keller 2025-05-05 3656 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV6_TCP_SYN_NO_ACK,
3b32c9932853e11 Slawomir Laba 2022-10-24 3657 flow_pctypes);
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3658 break;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3659 case UDP_V4_FLOW:
141d0c9037ca57d Jacob Keller 2025-05-05 3660 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV4_UDP, flow_pctypes);
0e8b9fdd40fe65b Ivan Vecera 2023-11-13 3661 if (test_bit(I40E_HW_CAP_MULTI_TCP_UDP_RSS_PCTYPE,
0e8b9fdd40fe65b Ivan Vecera 2023-11-13 3662 pf->hw.caps)) {
141d0c9037ca57d Jacob Keller 2025-05-05 3663 set_bit(LIBIE_FILTER_PCTYPE_NONF_UNICAST_IPV4_UDP,
3b32c9932853e11 Slawomir Laba 2022-10-24 3664 flow_pctypes);
141d0c9037ca57d Jacob Keller 2025-05-05 3665 set_bit(LIBIE_FILTER_PCTYPE_NONF_MULTICAST_IPV4_UDP,
3b32c9932853e11 Slawomir Laba 2022-10-24 3666 flow_pctypes);
3b32c9932853e11 Slawomir Laba 2022-10-24 3667 }
141d0c9037ca57d Jacob Keller 2025-05-05 3668 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_FRAG_IPV4);
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3669 break;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3670 case UDP_V6_FLOW:
141d0c9037ca57d Jacob Keller 2025-05-05 3671 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV6_UDP, flow_pctypes);
0e8b9fdd40fe65b Ivan Vecera 2023-11-13 3672 if (test_bit(I40E_HW_CAP_MULTI_TCP_UDP_RSS_PCTYPE,
0e8b9fdd40fe65b Ivan Vecera 2023-11-13 3673 pf->hw.caps)) {
141d0c9037ca57d Jacob Keller 2025-05-05 3674 set_bit(LIBIE_FILTER_PCTYPE_NONF_UNICAST_IPV6_UDP,
3b32c9932853e11 Slawomir Laba 2022-10-24 3675 flow_pctypes);
141d0c9037ca57d Jacob Keller 2025-05-05 3676 set_bit(LIBIE_FILTER_PCTYPE_NONF_MULTICAST_IPV6_UDP,
3b32c9932853e11 Slawomir Laba 2022-10-24 3677 flow_pctypes);
3b32c9932853e11 Slawomir Laba 2022-10-24 3678 }
141d0c9037ca57d Jacob Keller 2025-05-05 3679 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_FRAG_IPV6);
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3680 break;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3681 case AH_ESP_V4_FLOW:
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3682 case AH_V4_FLOW:
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3683 case ESP_V4_FLOW:
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3684 case SCTP_V4_FLOW:
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3685 if ((nfc->data & RXH_L4_B_0_1) ||
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3686 (nfc->data & RXH_L4_B_2_3))
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3687 return -EINVAL;
141d0c9037ca57d Jacob Keller 2025-05-05 3688 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_NONF_IPV4_OTHER);
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3689 break;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3690 case AH_ESP_V6_FLOW:
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3691 case AH_V6_FLOW:
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3692 case ESP_V6_FLOW:
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3693 case SCTP_V6_FLOW:
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3694 if ((nfc->data & RXH_L4_B_0_1) ||
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3695 (nfc->data & RXH_L4_B_2_3))
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3696 return -EINVAL;
141d0c9037ca57d Jacob Keller 2025-05-05 3697 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_NONF_IPV6_OTHER);
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3698 break;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3699 case IPV4_FLOW:
141d0c9037ca57d Jacob Keller 2025-05-05 3700 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_NONF_IPV4_OTHER) |
141d0c9037ca57d Jacob Keller 2025-05-05 3701 BIT_ULL(LIBIE_FILTER_PCTYPE_FRAG_IPV4);
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3702 break;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3703 case IPV6_FLOW:
141d0c9037ca57d Jacob Keller 2025-05-05 3704 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_NONF_IPV6_OTHER) |
141d0c9037ca57d Jacob Keller 2025-05-05 3705 BIT_ULL(LIBIE_FILTER_PCTYPE_FRAG_IPV6);
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3706 break;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3707 default:
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3708 return -EINVAL;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3709 }
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3710
3b32c9932853e11 Slawomir Laba 2022-10-24 @3711 for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) {
3b32c9932853e11 Slawomir Laba 2022-10-24 3712 i_setc = (u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id)) |
3b32c9932853e11 Slawomir Laba 2022-10-24 3713 ((u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id)) << 32);
54b5af5a4380760 Slawomir Laba 2022-10-24 3714 i_set = i40e_get_rss_hash_bits(&pf->hw, nfc, i_setc);
3b32c9932853e11 Slawomir Laba 2022-10-24 3715
3b32c9932853e11 Slawomir Laba 2022-10-24 3716 i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id),
eb0dd6e4a3b3df5 Carolyn Wyborny 2016-07-27 3717 (u32)i_set);
3b32c9932853e11 Slawomir Laba 2022-10-24 3718 i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id),
eb0dd6e4a3b3df5 Carolyn Wyborny 2016-07-27 3719 (u32)(i_set >> 32));
3b32c9932853e11 Slawomir Laba 2022-10-24 3720 hena |= BIT_ULL(flow_id);
3b32c9932853e11 Slawomir Laba 2022-10-24 3721 }
eb0dd6e4a3b3df5 Carolyn Wyborny 2016-07-27 3722
272cdaf2472ab77 Shannon Nelson 2016-02-17 3723 i40e_write_rx_ctl(hw, I40E_PFQF_HENA(0), (u32)hena);
272cdaf2472ab77 Shannon Nelson 2016-02-17 3724 i40e_write_rx_ctl(hw, I40E_PFQF_HENA(1), (u32)(hena >> 32));
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3725 i40e_flush(hw);
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3726
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3727 return 0;
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3728 }
c7d05ca89f8e40d Jesse Brandeburg 2013-09-11 3729
:::::: The code at line 3711 was first introduced by commit
:::::: 3b32c9932853e11d71f9db012d69e92e4669ba23 i40e: Fix flow-type by setting GL_HASH_INSET registers
:::::: TO: Slawomir Laba <slawomirx.laba@intel.com>
:::::: CC: Jakub Kicinski <kuba@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* [norov:for-620 5/15] drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3711:26: error: 'flow_id' undeclared; did you mean 'flowi'?
@ 2026-02-21 8:06 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2026-02-21 8:06 UTC (permalink / raw)
To: Yury Norov; +Cc: oe-kbuild-all
tree: https://github.com/norov/linux for-620
head: 3b794289e60f9e1cc26d239bef32c93543213772
commit: d40765a7bbafbae8f4c7546d5ffdb1f97408f1ab [5/15] i40e: drop useless bitmap_weight() call
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260221/202602210938.K7qvXxT7-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260221/202602210938.K7qvXxT7-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602210938.K7qvXxT7-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/bitmap.h:11,
from include/linux/linkmode.h:4,
from drivers/net/ethernet/intel/i40e/i40e.h:7,
from drivers/net/ethernet/intel/i40e/i40e_txrx_common.h:7,
from drivers/net/ethernet/intel/i40e/i40e_ethtool.c:9:
drivers/net/ethernet/intel/i40e/i40e_ethtool.c: In function 'i40e_set_rxfh_fields':
>> drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3711:26: error: 'flow_id' undeclared (first use in this function); did you mean 'flowi'?
3711 | for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) {
| ^~~~~~~
include/linux/find.h:586:15: note: in definition of macro 'for_each_set_bit'
586 | for ((bit) = 0; (bit) = find_next_bit((addr), (size), (bit)), (bit) < (size); (bit)++)
| ^~~
drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3711:26: note: each undeclared identifier is reported only once for each function it appears in
3711 | for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) {
| ^~~~~~~
include/linux/find.h:586:15: note: in definition of macro 'for_each_set_bit'
586 | for ((bit) = 0; (bit) = find_next_bit((addr), (size), (bit)), (bit) < (size); (bit)++)
| ^~~
include/linux/find.h:586:69: warning: left-hand operand of comma expression has no effect [-Wunused-value]
586 | for ((bit) = 0; (bit) = find_next_bit((addr), (size), (bit)), (bit) < (size); (bit)++)
| ^
drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3711:9: note: in expansion of macro 'for_each_set_bit'
3711 | for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) {
| ^~~~~~~~~~~~~~~~
vim +3711 drivers/net/ethernet/intel/i40e/i40e_ethtool.c
eb0dd6e4a3b3df Carolyn Wyborny 2016-07-27 3614
3b32c9932853e1 Slawomir Laba 2022-10-24 3615 #define FLOW_PCTYPES_SIZE 64
5a28983710b739 Jakub Kicinski 2025-06-14 3616 static int i40e_set_rxfh_fields(struct net_device *netdev,
5a28983710b739 Jakub Kicinski 2025-06-14 3617 const struct ethtool_rxfh_fields *nfc,
5a28983710b739 Jakub Kicinski 2025-06-14 3618 struct netlink_ext_ack *extack)
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3619 {
5a28983710b739 Jakub Kicinski 2025-06-14 3620 struct i40e_netdev_priv *np = netdev_priv(netdev);
5a28983710b739 Jakub Kicinski 2025-06-14 3621 struct i40e_vsi *vsi = np->vsi;
5a28983710b739 Jakub Kicinski 2025-06-14 3622 struct i40e_pf *pf = vsi->back;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3623 struct i40e_hw *hw = &pf->hw;
272cdaf2472ab7 Shannon Nelson 2016-02-17 3624 u64 hena = (u64)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(0)) |
272cdaf2472ab7 Shannon Nelson 2016-02-17 3625 ((u64)i40e_read_rx_ctl(hw, I40E_PFQF_HENA(1)) << 32);
3b32c9932853e1 Slawomir Laba 2022-10-24 3626 DECLARE_BITMAP(flow_pctypes, FLOW_PCTYPES_SIZE);
eb0dd6e4a3b3df Carolyn Wyborny 2016-07-27 3627 u64 i_set, i_setc;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3628
3b32c9932853e1 Slawomir Laba 2022-10-24 3629 bitmap_zero(flow_pctypes, FLOW_PCTYPES_SIZE);
3b32c9932853e1 Slawomir Laba 2022-10-24 3630
70756d0a4727fe Ivan Vecera 2023-11-13 3631 if (test_bit(I40E_FLAG_MFP_ENA, pf->flags)) {
83d14c595e011f Carolyn Wyborny 2017-06-07 3632 dev_err(&pf->pdev->dev,
83d14c595e011f Carolyn Wyborny 2017-06-07 3633 "Change of RSS hash input set is not supported when MFP mode is enabled\n");
83d14c595e011f Carolyn Wyborny 2017-06-07 3634 return -EOPNOTSUPP;
83d14c595e011f Carolyn Wyborny 2017-06-07 3635 }
83d14c595e011f Carolyn Wyborny 2017-06-07 3636
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3637 /* RSS does not support anything other than hashing
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3638 * to queues on src and dst IPs and ports
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3639 */
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3640 if (nfc->data & ~(RXH_IP_SRC | RXH_IP_DST |
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3641 RXH_L4_B_0_1 | RXH_L4_B_2_3))
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3642 return -EINVAL;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3643
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3644 switch (nfc->flow_type) {
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3645 case TCP_V4_FLOW:
141d0c9037ca57 Jacob Keller 2025-05-05 3646 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV4_TCP, flow_pctypes);
0e8b9fdd40fe65 Ivan Vecera 2023-11-13 3647 if (test_bit(I40E_HW_CAP_MULTI_TCP_UDP_RSS_PCTYPE,
0e8b9fdd40fe65 Ivan Vecera 2023-11-13 3648 pf->hw.caps))
141d0c9037ca57 Jacob Keller 2025-05-05 3649 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV4_TCP_SYN_NO_ACK,
3b32c9932853e1 Slawomir Laba 2022-10-24 3650 flow_pctypes);
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3651 break;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3652 case TCP_V6_FLOW:
141d0c9037ca57 Jacob Keller 2025-05-05 3653 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV6_TCP, flow_pctypes);
0e8b9fdd40fe65 Ivan Vecera 2023-11-13 3654 if (test_bit(I40E_HW_CAP_MULTI_TCP_UDP_RSS_PCTYPE,
0e8b9fdd40fe65 Ivan Vecera 2023-11-13 3655 pf->hw.caps))
141d0c9037ca57 Jacob Keller 2025-05-05 3656 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV6_TCP_SYN_NO_ACK,
3b32c9932853e1 Slawomir Laba 2022-10-24 3657 flow_pctypes);
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3658 break;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3659 case UDP_V4_FLOW:
141d0c9037ca57 Jacob Keller 2025-05-05 3660 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV4_UDP, flow_pctypes);
0e8b9fdd40fe65 Ivan Vecera 2023-11-13 3661 if (test_bit(I40E_HW_CAP_MULTI_TCP_UDP_RSS_PCTYPE,
0e8b9fdd40fe65 Ivan Vecera 2023-11-13 3662 pf->hw.caps)) {
141d0c9037ca57 Jacob Keller 2025-05-05 3663 set_bit(LIBIE_FILTER_PCTYPE_NONF_UNICAST_IPV4_UDP,
3b32c9932853e1 Slawomir Laba 2022-10-24 3664 flow_pctypes);
141d0c9037ca57 Jacob Keller 2025-05-05 3665 set_bit(LIBIE_FILTER_PCTYPE_NONF_MULTICAST_IPV4_UDP,
3b32c9932853e1 Slawomir Laba 2022-10-24 3666 flow_pctypes);
3b32c9932853e1 Slawomir Laba 2022-10-24 3667 }
141d0c9037ca57 Jacob Keller 2025-05-05 3668 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_FRAG_IPV4);
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3669 break;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3670 case UDP_V6_FLOW:
141d0c9037ca57 Jacob Keller 2025-05-05 3671 set_bit(LIBIE_FILTER_PCTYPE_NONF_IPV6_UDP, flow_pctypes);
0e8b9fdd40fe65 Ivan Vecera 2023-11-13 3672 if (test_bit(I40E_HW_CAP_MULTI_TCP_UDP_RSS_PCTYPE,
0e8b9fdd40fe65 Ivan Vecera 2023-11-13 3673 pf->hw.caps)) {
141d0c9037ca57 Jacob Keller 2025-05-05 3674 set_bit(LIBIE_FILTER_PCTYPE_NONF_UNICAST_IPV6_UDP,
3b32c9932853e1 Slawomir Laba 2022-10-24 3675 flow_pctypes);
141d0c9037ca57 Jacob Keller 2025-05-05 3676 set_bit(LIBIE_FILTER_PCTYPE_NONF_MULTICAST_IPV6_UDP,
3b32c9932853e1 Slawomir Laba 2022-10-24 3677 flow_pctypes);
3b32c9932853e1 Slawomir Laba 2022-10-24 3678 }
141d0c9037ca57 Jacob Keller 2025-05-05 3679 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_FRAG_IPV6);
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3680 break;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3681 case AH_ESP_V4_FLOW:
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3682 case AH_V4_FLOW:
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3683 case ESP_V4_FLOW:
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3684 case SCTP_V4_FLOW:
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3685 if ((nfc->data & RXH_L4_B_0_1) ||
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3686 (nfc->data & RXH_L4_B_2_3))
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3687 return -EINVAL;
141d0c9037ca57 Jacob Keller 2025-05-05 3688 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_NONF_IPV4_OTHER);
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3689 break;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3690 case AH_ESP_V6_FLOW:
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3691 case AH_V6_FLOW:
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3692 case ESP_V6_FLOW:
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3693 case SCTP_V6_FLOW:
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3694 if ((nfc->data & RXH_L4_B_0_1) ||
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3695 (nfc->data & RXH_L4_B_2_3))
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3696 return -EINVAL;
141d0c9037ca57 Jacob Keller 2025-05-05 3697 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_NONF_IPV6_OTHER);
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3698 break;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3699 case IPV4_FLOW:
141d0c9037ca57 Jacob Keller 2025-05-05 3700 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_NONF_IPV4_OTHER) |
141d0c9037ca57 Jacob Keller 2025-05-05 3701 BIT_ULL(LIBIE_FILTER_PCTYPE_FRAG_IPV4);
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3702 break;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3703 case IPV6_FLOW:
141d0c9037ca57 Jacob Keller 2025-05-05 3704 hena |= BIT_ULL(LIBIE_FILTER_PCTYPE_NONF_IPV6_OTHER) |
141d0c9037ca57 Jacob Keller 2025-05-05 3705 BIT_ULL(LIBIE_FILTER_PCTYPE_FRAG_IPV6);
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3706 break;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3707 default:
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3708 return -EINVAL;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3709 }
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3710
3b32c9932853e1 Slawomir Laba 2022-10-24 @3711 for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) {
3b32c9932853e1 Slawomir Laba 2022-10-24 3712 i_setc = (u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id)) |
3b32c9932853e1 Slawomir Laba 2022-10-24 3713 ((u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id)) << 32);
54b5af5a438076 Slawomir Laba 2022-10-24 3714 i_set = i40e_get_rss_hash_bits(&pf->hw, nfc, i_setc);
3b32c9932853e1 Slawomir Laba 2022-10-24 3715
3b32c9932853e1 Slawomir Laba 2022-10-24 3716 i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id),
eb0dd6e4a3b3df Carolyn Wyborny 2016-07-27 3717 (u32)i_set);
3b32c9932853e1 Slawomir Laba 2022-10-24 3718 i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id),
eb0dd6e4a3b3df Carolyn Wyborny 2016-07-27 3719 (u32)(i_set >> 32));
3b32c9932853e1 Slawomir Laba 2022-10-24 3720 hena |= BIT_ULL(flow_id);
3b32c9932853e1 Slawomir Laba 2022-10-24 3721 }
eb0dd6e4a3b3df Carolyn Wyborny 2016-07-27 3722
272cdaf2472ab7 Shannon Nelson 2016-02-17 3723 i40e_write_rx_ctl(hw, I40E_PFQF_HENA(0), (u32)hena);
272cdaf2472ab7 Shannon Nelson 2016-02-17 3724 i40e_write_rx_ctl(hw, I40E_PFQF_HENA(1), (u32)(hena >> 32));
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3725 i40e_flush(hw);
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3726
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3727 return 0;
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3728 }
c7d05ca89f8e40 Jesse Brandeburg 2013-09-11 3729
:::::: The code at line 3711 was first introduced by commit
:::::: 3b32c9932853e11d71f9db012d69e92e4669ba23 i40e: Fix flow-type by setting GL_HASH_INSET registers
:::::: TO: Slawomir Laba <slawomirx.laba@intel.com>
:::::: CC: Jakub Kicinski <kuba@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-21 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-21 7:18 [norov:for-620 5/15] drivers/net/ethernet/intel/i40e/i40e_ethtool.c:3711:26: error: 'flow_id' undeclared; did you mean 'flowi'? kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-02-21 8:06 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.