From: Priit Laes <plaes@plaes.org>
Cc: "Priit Laes" <plaes@plaes.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Archit Anant" <architanant5@gmail.com>,
"Minu Jin" <s9430939@naver.com>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"JJ Strnad" <strnad.jj@gmail.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Ethan Tidmore" <ethantidmore06@gmail.com>,
"William Hansen-Baird" <william.hansen.baird@gmail.com>,
"Navaneeth K" <knavaneeth786@gmail.com>,
"Tanjim Kamal" <tanjimkamal1@gmail.com>,
"Artur Stupa" <arthur.stupa@gmail.com>,
"Abraham Samuel Adekunle" <abrahamadekunle50@gmail.com>,
"Michael Straube" <straube.linux@gmail.com>,
"Hans de Goede" <hansg@kernel.org>,
"Vivek BalachandharTN" <vivek.balachandhar@gmail.com>,
"Zhuoheng Li" <lizhuoheng@kylinos.cn>,
"Michael Huang" <tehsiu.huang@gmail.com>,
"Nino Zhang" <ninozhang001@gmail.com>,
"Rogério Fernandes Pereira" <rfp2005@gmail.com>,
"Ingo Molnar" <mingo@kernel.org>,
"Diksha Kumari" <dikshakdevgan@gmail.com>,
"Milos Puric" <milospuric856@gmail.com>,
"Karthikey D Kadati" <karthikey3608@gmail.com>,
"Khushal Chitturi" <khushalchitturi@gmail.com>,
"Akiyoshi Kurita" <weibu@redadmin.org>,
"SeungJu Cheon" <suunj1331@gmail.com>,
"Erick Karanja" <karanja99erick@gmail.com>,
"Sun Jian" <sun.jian.kdev@gmail.com>,
"Yuvraj Singh Chauhan" <ysinghcin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 03/11] staging: rtl8723bs: Drop empty rtw_bug_check function
Date: Sat, 21 Feb 2026 21:01:33 +0200 [thread overview]
Message-ID: <20260221190628.50273-4-plaes@plaes.org> (raw)
In-Reply-To: <20260221190628.50273-1-plaes@plaes.org>
The rtw_bug_check was no-op returing true, so get rid of it
and remove calls to it.
Signed-off-by: Priit Laes <plaes@plaes.org>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 ----------
drivers/staging/rtl8723bs/include/osdep_service.h | 8 --------
2 files changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 22dc36e8e38a..7a346cbf2708 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -358,9 +358,6 @@ int is_same_network(struct wlan_bssid_ex *src, struct wlan_bssid_ex *dst, u8 fea
u16 s_cap, d_cap;
__le16 tmps, tmpd;
- if (rtw_bug_check(dst, src, &s_cap, &d_cap) == false)
- return false;
-
memcpy((u8 *)&tmps, rtw_get_capability_from_ie(src->ies), 2);
memcpy((u8 *)&tmpd, rtw_get_capability_from_ie(dst->ies), 2);
@@ -464,11 +461,6 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex
{
struct mlme_priv *pmlmepriv = &adapter->mlmepriv;
- rtw_bug_check(&pmlmepriv->cur_network.network,
- &pmlmepriv->cur_network.network,
- &pmlmepriv->cur_network.network,
- &pmlmepriv->cur_network.network);
-
if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) {
update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true);
rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie),
@@ -493,8 +485,6 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
list_for_each(plist, phead) {
pnetwork = list_entry(plist, struct wlan_network, list);
- rtw_bug_check(pnetwork, pnetwork, pnetwork, pnetwork);
-
if (is_same_network(&pnetwork->network, target, feature)) {
target_find = 1;
break;
diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index f7b647db1a75..d6710e5835f0 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -65,14 +65,6 @@ static inline void flush_signals_thread(void)
#define rtw_warn_on(condition) WARN_ON(condition)
-static inline int rtw_bug_check(void *parg1, void *parg2, void *parg3, void *parg4)
-{
- int ret = true;
-
- return ret;
-
-}
-
extern void rtw_free_netdev(struct net_device *netdev);
/* Macros for handling unaligned memory accesses */
--
2.53.0
next prev parent reply other threads:[~2026-02-21 19:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 19:01 [PATCH v2 00/11] staging: stl8723bs: Various cleanups Priit Laes
2026-02-21 19:01 ` [PATCH v2 01/11] staging: stl8723bs: Use common round_up macro Priit Laes
2026-02-21 19:41 ` Vivek BalachandharTN
2026-02-23 7:09 ` Dan Carpenter
2026-02-23 10:43 ` Priit Laes
2026-02-23 11:40 ` Julia Lawall
2026-02-23 11:50 ` Andy Shevchenko
2026-02-23 12:16 ` Julia Lawall
2026-02-23 13:48 ` Andy Shevchenko
2026-02-23 14:43 ` Dan Carpenter
2026-02-21 19:01 ` [PATCH v2 02/11] staging: rtl8723bs: Remove unused BIT32..BIT36 definitions Priit Laes
2026-02-21 19:01 ` Priit Laes [this message]
2026-02-21 19:01 ` [PATCH v2 04/11] staging: rtl8723bs: Remove unused rtw_sprintf macro Priit Laes
2026-02-21 19:01 ` [PATCH v2 05/11] staging: rtl8723bs: Drop unused _kfree(...) declaration Priit Laes
2026-02-21 19:01 ` [PATCH v2 06/11] staging: rtl8723bs: Get rid of unused _rtw_init_queue Priit Laes
2026-02-21 19:01 ` [PATCH v2 07/11] staging: rtl8723bs: Drop unused NDEV-related formatting macros Priit Laes
2026-02-21 19:01 ` [PATCH v2 08/11] staging: rtl8723bs: Drop workqueue wrapper functions Priit Laes
2026-02-21 19:01 ` [PATCH v2 09/11] staging: rtl8273bs: Simplify regulatory initialization functions Priit Laes
2026-02-23 7:17 ` Dan Carpenter
2026-02-21 19:01 ` [PATCH v2 10/11] staging: rtl8723bs: Clean up wrapper functions Priit Laes
2026-02-21 20:20 ` Vivek BalachandharTN
2026-02-23 7:25 ` Dan Carpenter
[not found] ` <CAPsOcukZNc3oR=FmAjCdC6NrUV=1CaggQNGPoC2oxuH_P2R0hQ@mail.gmail.com>
2026-02-23 7:50 ` Andy Shevchenko
2026-02-21 19:01 ` [PATCH v2 11/11] staging: rtl8723bs: rtw_ieee80211: Reduce global symbols Priit Laes
2026-02-23 7:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260221190628.50273-4-plaes@plaes.org \
--to=plaes@plaes.org \
--cc=abrahamadekunle50@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=architanant5@gmail.com \
--cc=arthur.stupa@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=dikshakdevgan@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=karanja99erick@gmail.com \
--cc=karthikey3608@gmail.com \
--cc=khushalchitturi@gmail.com \
--cc=knavaneeth786@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lizhuoheng@kylinos.cn \
--cc=milospuric856@gmail.com \
--cc=mingo@kernel.org \
--cc=ninozhang001@gmail.com \
--cc=rdunlap@infradead.org \
--cc=rfp2005@gmail.com \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=strnad.jj@gmail.com \
--cc=sun.jian.kdev@gmail.com \
--cc=suunj1331@gmail.com \
--cc=tanjimkamal1@gmail.com \
--cc=tehsiu.huang@gmail.com \
--cc=tglx@kernel.org \
--cc=vivek.balachandhar@gmail.com \
--cc=weibu@redadmin.org \
--cc=william.hansen.baird@gmail.com \
--cc=ysinghcin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.