All of lore.kernel.org
 help / color / mirror / Atom feed
From: Priit Laes <plaes@plaes.org>
Cc: "Priit Laes" <plaes@plaes.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Minu Jin" <s9430939@naver.com>,
	"Archit Anant" <architanant5@gmail.com>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Philip Thayer" <thayerscirez@gmail.com>,
	"JJ Strnad" <strnad.jj@gmail.com>,
	"Dan Carpenter" <dan.carpenter@linaro.org>,
	"Tanjim Kamal" <tanjimkamal1@gmail.com>,
	"Ethan Tidmore" <ethantidmore06@gmail.com>,
	"Abraham Samuel Adekunle" <abrahamadekunle50@gmail.com>,
	"Navaneeth K" <knavaneeth786@gmail.com>,
	"William Hansen-Baird" <william.hansen.baird@gmail.com>,
	"Artur Stupa" <arthur.stupa@gmail.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Michael Straube" <straube.linux@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Vivek BalachandharTN" <vivek.balachandhar@gmail.com>,
	"Zhuoheng Li" <lizhuoheng@kylinos.cn>,
	"Michael Huang" <tehsiu.huang@gmail.com>,
	"Nino Zhang" <ninozhang001@gmail.com>,
	"Rogério Fernandes Pereira" <rfp2005@gmail.com>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Omer El Idrissi" <omer.e.idrissi@gmail.com>,
	"Diksha Kumari" <dikshakdevgan@gmail.com>,
	yingche <zxcv2569763104@gmail.com>,
	"Milos Puric" <milospuric856@gmail.com>,
	"Khushal Chitturi" <khushalchitturi@gmail.com>,
	"Erick Karanja" <karanja99erick@gmail.com>,
	"SeungJu Cheon" <suunj1331@gmail.com>,
	"Akiyoshi Kurita" <weibu@redadmin.org>,
	"Sun Jian" <sun.jian.kdev@gmail.com>,
	"Yuvraj Singh Chauhan" <ysinghcin@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2 06/11] staging: rtl8723bs: Get rid of unused _rtw_init_queue
Date: Sat, 21 Feb 2026 21:01:36 +0200	[thread overview]
Message-ID: <20260221190628.50273-7-plaes@plaes.org> (raw)
In-Reply-To: <20260221190628.50273-1-plaes@plaes.org>

While `_rtw_init_queue` function was reworked ~4 years ago,
there were still some leftovers in commented out code and also
header file.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c         | 3 ---
 drivers/staging/rtl8723bs/core/rtw_sta_mgt.c      | 1 -
 drivers/staging/rtl8723bs/core/rtw_xmit.c         | 4 ----
 drivers/staging/rtl8723bs/include/osdep_service.h | 2 --
 4 files changed, 10 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 337671b1211f..e0c901a5459e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -21,9 +21,6 @@ void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_recvpriv)
 
 	spin_lock_init(&psta_recvpriv->lock);
 
-	/* for (i = 0; i<MAX_RX_NUMBLKS; i++) */
-	/* _rtw_init_queue(&psta_recvpriv->blk_strms[i]); */
-
 	INIT_LIST_HEAD(&psta_recvpriv->defrag_q.queue);
 	spin_lock_init(&psta_recvpriv->defrag_q.lock);
 }
diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
index bdd4b6d8fd2e..76d32ae8ac9e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c
@@ -67,7 +67,6 @@ u32 _rtw_init_sta_priv(struct	sta_priv *pstapriv)
 
 	spin_lock_init(&pstapriv->sta_hash_lock);
 
-	/* _rtw_init_queue(&pstapriv->asoc_q); */
 	pstapriv->asoc_sta_count = 0;
 	INIT_LIST_HEAD(&pstapriv->sleep_q.queue);
 	spin_lock_init(&pstapriv->sleep_q.lock);
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 222851e8d985..c2833f3cd10b 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -43,10 +43,6 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter)
 	init_completion(&pxmitpriv->xmit_comp);
 	init_completion(&pxmitpriv->terminate_xmitthread_comp);
 
-	/*
-	 * Please insert all the queue initialization using _rtw_init_queue below
-	 */
-
 	pxmitpriv->adapter = padapter;
 
 	INIT_LIST_HEAD(&pxmitpriv->be_pending.queue);
diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h
index 59fc2cdb195d..37e8ddb01dcd 100644
--- a/drivers/staging/rtl8723bs/include/osdep_service.h
+++ b/drivers/staging/rtl8723bs/include/osdep_service.h
@@ -53,8 +53,6 @@ int _rtw_netif_rx(struct net_device *ndev, struct sk_buff *skb);
 
 #define rtw_netif_rx(ndev, skb) _rtw_netif_rx(ndev, skb)
 
-extern void _rtw_init_queue(struct __queue	*pqueue);
-
 static inline void flush_signals_thread(void)
 {
 	if (signal_pending(current))
-- 
2.53.0


  parent reply	other threads:[~2026-02-21 19:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-21 19:01 [PATCH v2 00/11] staging: stl8723bs: Various cleanups Priit Laes
2026-02-21 19:01 ` [PATCH v2 01/11] staging: stl8723bs: Use common round_up macro Priit Laes
2026-02-21 19:41   ` Vivek BalachandharTN
2026-02-23  7:09     ` Dan Carpenter
2026-02-23 10:43       ` Priit Laes
2026-02-23 11:40         ` Julia Lawall
2026-02-23 11:50           ` Andy Shevchenko
2026-02-23 12:16             ` Julia Lawall
2026-02-23 13:48               ` Andy Shevchenko
2026-02-23 14:43         ` Dan Carpenter
2026-02-21 19:01 ` [PATCH v2 02/11] staging: rtl8723bs: Remove unused BIT32..BIT36 definitions Priit Laes
2026-02-21 19:01 ` [PATCH v2 03/11] staging: rtl8723bs: Drop empty rtw_bug_check function Priit Laes
2026-02-21 19:01 ` [PATCH v2 04/11] staging: rtl8723bs: Remove unused rtw_sprintf macro Priit Laes
2026-02-21 19:01 ` [PATCH v2 05/11] staging: rtl8723bs: Drop unused _kfree(...) declaration Priit Laes
2026-02-21 19:01 ` Priit Laes [this message]
2026-02-21 19:01 ` [PATCH v2 07/11] staging: rtl8723bs: Drop unused NDEV-related formatting macros Priit Laes
2026-02-21 19:01 ` [PATCH v2 08/11] staging: rtl8723bs: Drop workqueue wrapper functions Priit Laes
2026-02-21 19:01 ` [PATCH v2 09/11] staging: rtl8273bs: Simplify regulatory initialization functions Priit Laes
2026-02-23  7:17   ` Dan Carpenter
2026-02-21 19:01 ` [PATCH v2 10/11] staging: rtl8723bs: Clean up wrapper functions Priit Laes
2026-02-21 20:20   ` Vivek BalachandharTN
2026-02-23  7:25   ` Dan Carpenter
     [not found]   ` <CAPsOcukZNc3oR=FmAjCdC6NrUV=1CaggQNGPoC2oxuH_P2R0hQ@mail.gmail.com>
2026-02-23  7:50     ` Andy Shevchenko
2026-02-21 19:01 ` [PATCH v2 11/11] staging: rtl8723bs: rtw_ieee80211: Reduce global symbols Priit Laes
2026-02-23  7:32   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260221190628.50273-7-plaes@plaes.org \
    --to=plaes@plaes.org \
    --cc=abrahamadekunle50@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=architanant5@gmail.com \
    --cc=arthur.stupa@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=dikshakdevgan@gmail.com \
    --cc=ethantidmore06@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=karanja99erick@gmail.com \
    --cc=khushalchitturi@gmail.com \
    --cc=knavaneeth786@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=lizhuoheng@kylinos.cn \
    --cc=milospuric856@gmail.com \
    --cc=mingo@kernel.org \
    --cc=ninozhang001@gmail.com \
    --cc=omer.e.idrissi@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=rfp2005@gmail.com \
    --cc=s9430939@naver.com \
    --cc=straube.linux@gmail.com \
    --cc=strnad.jj@gmail.com \
    --cc=sun.jian.kdev@gmail.com \
    --cc=suunj1331@gmail.com \
    --cc=tanjimkamal1@gmail.com \
    --cc=tehsiu.huang@gmail.com \
    --cc=tglx@kernel.org \
    --cc=thayerscirez@gmail.com \
    --cc=vivek.balachandhar@gmail.com \
    --cc=weibu@redadmin.org \
    --cc=william.hansen.baird@gmail.com \
    --cc=ysinghcin@gmail.com \
    --cc=zxcv2569763104@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.