* [PATCH] hw: copy paste bug
@ 2026-02-23 9:59 Weixie Cui
2026-02-23 13:47 ` Thomas Huth
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Weixie Cui @ 2026-02-23 9:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Weixie Cui
Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
---
hw/ssi/xilinx_spips.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index a4718fb72d..f6e717bc01 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -369,7 +369,7 @@ static void xilinx_spips_reset(DeviceState *d)
memset(s->regs, 0, sizeof(s->regs));
fifo8_reset(&s->rx_fifo);
- fifo8_reset(&s->rx_fifo);
+ fifo8_reset(&s->tx_fifo);
/* non zero resets */
s->regs[R_CONFIG] |= MODEFAIL_GEN_EN;
s->regs[R_SLAVE_IDLE_COUNT] = 0xFF;
@@ -397,7 +397,7 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d)
memset(s->regs, 0, sizeof(s->regs));
fifo8_reset(&s->rx_fifo_g);
- fifo8_reset(&s->rx_fifo_g);
+ fifo8_reset(&s->tx_fifo_g);
fifo32_reset(&s->fifo_g);
s->regs[R_INTR_STATUS] = R_INTR_STATUS_RESET;
s->regs[R_GPIO] = 1;
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] hw: copy paste bug
2026-02-23 9:59 [PATCH] hw: copy paste bug Weixie Cui
@ 2026-02-23 13:47 ` Thomas Huth
2026-02-24 2:48 ` Alistair Francis
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2026-02-23 13:47 UTC (permalink / raw)
To: Weixie Cui, qemu-devel, Peter Maydell, qemu-arm
Cc: QEMU Trivial, Alistair Francis, Edgar E. Iglesias
On 23/02/2026 10.59, Weixie Cui wrote:
> Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
> ---
> hw/ssi/xilinx_spips.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index a4718fb72d..f6e717bc01 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -369,7 +369,7 @@ static void xilinx_spips_reset(DeviceState *d)
> memset(s->regs, 0, sizeof(s->regs));
>
> fifo8_reset(&s->rx_fifo);
> - fifo8_reset(&s->rx_fifo);
> + fifo8_reset(&s->tx_fifo);
> /* non zero resets */
> s->regs[R_CONFIG] |= MODEFAIL_GEN_EN;
> s->regs[R_SLAVE_IDLE_COUNT] = 0xFF;
> @@ -397,7 +397,7 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d)
> memset(s->regs, 0, sizeof(s->regs));
>
> fifo8_reset(&s->rx_fifo_g);
> - fifo8_reset(&s->rx_fifo_g);
> + fifo8_reset(&s->tx_fifo_g);
> fifo32_reset(&s->fifo_g);
> s->regs[R_INTR_STATUS] = R_INTR_STATUS_RESET;
> s->regs[R_GPIO] = 1;
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hw: copy paste bug
2026-02-23 9:59 [PATCH] hw: copy paste bug Weixie Cui
2026-02-23 13:47 ` Thomas Huth
@ 2026-02-24 2:48 ` Alistair Francis
2026-02-24 6:57 ` Markus Armbruster
2026-02-24 11:18 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2026-02-24 2:48 UTC (permalink / raw)
To: Weixie Cui; +Cc: qemu-devel
On Mon, Feb 23, 2026 at 11:39 PM Weixie Cui <cuiweixie@gmail.com> wrote:
>
> Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> hw/ssi/xilinx_spips.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index a4718fb72d..f6e717bc01 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -369,7 +369,7 @@ static void xilinx_spips_reset(DeviceState *d)
> memset(s->regs, 0, sizeof(s->regs));
>
> fifo8_reset(&s->rx_fifo);
> - fifo8_reset(&s->rx_fifo);
> + fifo8_reset(&s->tx_fifo);
> /* non zero resets */
> s->regs[R_CONFIG] |= MODEFAIL_GEN_EN;
> s->regs[R_SLAVE_IDLE_COUNT] = 0xFF;
> @@ -397,7 +397,7 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d)
> memset(s->regs, 0, sizeof(s->regs));
>
> fifo8_reset(&s->rx_fifo_g);
> - fifo8_reset(&s->rx_fifo_g);
> + fifo8_reset(&s->tx_fifo_g);
> fifo32_reset(&s->fifo_g);
> s->regs[R_INTR_STATUS] = R_INTR_STATUS_RESET;
> s->regs[R_GPIO] = 1;
> --
> 2.39.5 (Apple Git-154)
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hw: copy paste bug
2026-02-23 9:59 [PATCH] hw: copy paste bug Weixie Cui
2026-02-23 13:47 ` Thomas Huth
2026-02-24 2:48 ` Alistair Francis
@ 2026-02-24 6:57 ` Markus Armbruster
2026-02-24 11:18 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2026-02-24 6:57 UTC (permalink / raw)
To: Weixie Cui; +Cc: qemu-devel
Better:
hw/ssi/xilinx_spips: Fix copy paste bug in device reset
Still missing then: what's the bug's impact?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] hw: copy paste bug
2026-02-23 9:59 [PATCH] hw: copy paste bug Weixie Cui
` (2 preceding siblings ...)
2026-02-24 6:57 ` Markus Armbruster
@ 2026-02-24 11:18 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2026-02-24 11:18 UTC (permalink / raw)
To: Weixie Cui; +Cc: qemu-devel
On Mon, 23 Feb 2026 at 13:38, Weixie Cui <cuiweixie@gmail.com> wrote:
>
> Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
> ---
> hw/ssi/xilinx_spips.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to target-arm.next with an updated commit message,
thanks.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-02-24 11:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-23 9:59 [PATCH] hw: copy paste bug Weixie Cui
2026-02-23 13:47 ` Thomas Huth
2026-02-24 2:48 ` Alistair Francis
2026-02-24 6:57 ` Markus Armbruster
2026-02-24 11:18 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.