From: Jonathan Cameron via <qemu-arm@nongnu.org>
To: Shameer Kolothum <skolothumtho@nvidia.com>
Cc: <qemu-arm@nongnu.org>, <qemu-devel@nongnu.org>,
<eric.auger@redhat.com>, <peter.maydell@linaro.org>,
<nicolinc@nvidia.com>, <nathanc@nvidia.com>, <mochs@nvidia.com>,
<jan@nvidia.com>, <jgg@nvidia.com>, <zhangfei.gao@linaro.org>,
<zhenzhong.duan@intel.com>, <kjaju@nvidia.com>
Subject: Re: [PATCH v7 2/5] hw/arm/smmuv3-accel: Add viommu free helper
Date: Tue, 24 Feb 2026 14:13:57 +0000 [thread overview]
Message-ID: <20260224141357.000038f1@huawei.com> (raw)
In-Reply-To: <20260219090103.33697-3-skolothumtho@nvidia.com>
On Thu, 19 Feb 2026 09:01:00 +0000
Shameer Kolothum <skolothumtho@nvidia.com> wrote:
> Move viommu teardown into a helper function and use it from the
> last device removal path. No functional change.
Minor thing, but this description should really include 'why' factoring this
out makes sense. I was kind of assuming reuse, but there doesn't seem to be
any in this series. So I guess just grouping related code for readability?
>
> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> Tested-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via qemu development <qemu-devel@nongnu.org>
To: Shameer Kolothum <skolothumtho@nvidia.com>
Cc: <qemu-arm@nongnu.org>, <qemu-devel@nongnu.org>,
<eric.auger@redhat.com>, <peter.maydell@linaro.org>,
<nicolinc@nvidia.com>, <nathanc@nvidia.com>, <mochs@nvidia.com>,
<jan@nvidia.com>, <jgg@nvidia.com>, <zhangfei.gao@linaro.org>,
<zhenzhong.duan@intel.com>, <kjaju@nvidia.com>
Subject: Re: [PATCH v7 2/5] hw/arm/smmuv3-accel: Add viommu free helper
Date: Tue, 24 Feb 2026 14:13:57 +0000 [thread overview]
Message-ID: <20260224141357.000038f1@huawei.com> (raw)
In-Reply-To: <20260219090103.33697-3-skolothumtho@nvidia.com>
On Thu, 19 Feb 2026 09:01:00 +0000
Shameer Kolothum <skolothumtho@nvidia.com> wrote:
> Move viommu teardown into a helper function and use it from the
> last device removal path. No functional change.
Minor thing, but this description should really include 'why' factoring this
out makes sense. I was kind of assuming reuse, but there doesn't seem to be
any in this series. So I guess just grouping related code for readability?
>
> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
> Tested-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Shameer Kolothum <skolothumtho@nvidia.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
next prev parent reply other threads:[~2026-02-24 14:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 9:00 [PATCH v7 0/5] vEVENTQ support for accelerated SMMUv3 devices Shameer Kolothum
2026-02-19 9:00 ` [PATCH v7 1/5] backends/iommufd: Introduce iommufd_backend_alloc_veventq Shameer Kolothum
2026-02-24 14:09 ` Jonathan Cameron via
2026-02-24 14:09 ` Jonathan Cameron via qemu development
2026-02-19 9:01 ` [PATCH v7 2/5] hw/arm/smmuv3-accel: Add viommu free helper Shameer Kolothum
2026-02-24 14:13 ` Jonathan Cameron via [this message]
2026-02-24 14:13 ` Jonathan Cameron via qemu development
2026-02-24 14:45 ` Shameer Kolothum Thodi
2026-02-19 9:01 ` [PATCH v7 3/5] hw/arm/smmuv3-accel: Allocate vEVENTQ for accelerated SMMUv3 devices Shameer Kolothum
2026-02-24 14:28 ` Jonathan Cameron via
2026-02-24 14:28 ` Jonathan Cameron via qemu development
2026-02-24 14:41 ` Shameer Kolothum Thodi
2026-02-24 15:01 ` Jonathan Cameron via
2026-02-24 15:01 ` Jonathan Cameron via qemu development
2026-02-24 15:18 ` Shameer Kolothum Thodi
2026-02-24 16:02 ` Jonathan Cameron via
2026-02-24 16:02 ` Jonathan Cameron via qemu development
2026-02-19 9:01 ` [PATCH v7 4/5] hw/arm/smmuv3: Introduce a helper function for event propagation Shameer Kolothum
2026-02-24 14:30 ` Jonathan Cameron via
2026-02-24 14:30 ` Jonathan Cameron via qemu development
2026-02-19 9:01 ` [PATCH v7 5/5] hw/arm/smmuv3-accel: Read and propagate host vIOMMU events Shameer Kolothum
2026-02-24 14:33 ` Jonathan Cameron via
2026-02-24 14:33 ` Jonathan Cameron via qemu development
2026-02-24 13:52 ` [PATCH v7 0/5] vEVENTQ support for accelerated SMMUv3 devices Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224141357.000038f1@huawei.com \
--to=qemu-arm@nongnu.org \
--cc=eric.auger@redhat.com \
--cc=jan@nvidia.com \
--cc=jgg@nvidia.com \
--cc=jonathan.cameron@huawei.com \
--cc=kjaju@nvidia.com \
--cc=mochs@nvidia.com \
--cc=nathanc@nvidia.com \
--cc=nicolinc@nvidia.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=skolothumtho@nvidia.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.