Re: [RFC PATCH 6/6] mm/memcontrol: Make memory.high tier-aware

[kernel test robot <lkp@intel.com>]

Hi Joshua,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Joshua-Hahn/mm-page_counter-Introduce-tiered-memory-awareness-to-page_counter/20260224-073845
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20260223223830.586018-7-joshua.hahnjy%40gmail.com
patch subject: [RFC PATCH 6/6] mm/memcontrol: Make memory.high tier-aware
config: i386-buildonly-randconfig-002-20260224 (https://download.01.org/0day-ci/archive/20260224/202602241456.9NrcMR6n-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260224/202602241456.9NrcMR6n-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602241456.9NrcMR6n-lkp@intel.com/

All errors (new ones prefixed by >>):

>> mm/memcontrol.c:2193:23: error: use of undeclared identifier 'tier_aware_memcg_limits'
    2193 |                 toptier_high_ok = !(tier_aware_memcg_limits &&
         |                                     ^
   mm/memcontrol.c:2315:7: error: use of undeclared identifier 'tier_aware_memcg_limits'
    2315 |         if (!tier_aware_memcg_limits)
         |              ^
   mm/memcontrol.c:2640:18: error: use of undeclared identifier 'tier_aware_memcg_limits'
    2640 |                 toptier_high = tier_aware_memcg_limits &&
         |                                ^
   mm/memcontrol.c:4541:28: error: use of undeclared identifier 'tier_aware_memcg_limits'
    4541 |                 bool toptier_high_ok = !(tier_aware_memcg_limits &&
         |                                          ^
   4 errors generated.


vim +/tier_aware_memcg_limits +2193 mm/memcontrol.c

  2178	
  2179	static unsigned long reclaim_high(struct mem_cgroup *memcg,
  2180					  unsigned int nr_pages,
  2181					  gfp_t gfp_mask)
  2182	{
  2183		unsigned long nr_reclaimed = 0;
  2184	
  2185		do {
  2186			unsigned long pflags;
  2187			nodemask_t toptier_nodes, *reclaim_nodes;
  2188			bool mem_high_ok, toptier_high_ok;
  2189	
  2190			mt_get_toptier_nodemask(&toptier_nodes, NULL);
  2191			mem_high_ok = page_counter_read(&memcg->memory) <=
  2192				      READ_ONCE(memcg->memory.high);
> 2193			toptier_high_ok = !(tier_aware_memcg_limits &&
  2194					    mem_cgroup_toptier_usage(memcg) >
  2195					    page_counter_toptier_high(&memcg->memory));
  2196			if (mem_high_ok && toptier_high_ok)
  2197				continue;
  2198	
  2199			if (mem_high_ok && !toptier_high_ok)
  2200				reclaim_nodes = &toptier_nodes;
  2201			else
  2202				reclaim_nodes = NULL;
  2203	
  2204			memcg_memory_event(memcg, MEMCG_HIGH);
  2205	
  2206			psi_memstall_enter(&pflags);
  2207			nr_reclaimed += try_to_free_mem_cgroup_pages(memcg, nr_pages,
  2208								gfp_mask,
  2209								MEMCG_RECLAIM_MAY_SWAP,
  2210								NULL, reclaim_nodes);
  2211			psi_memstall_leave(&pflags);
  2212		} while ((memcg = parent_mem_cgroup(memcg)) &&
  2213			 !mem_cgroup_is_root(memcg));
  2214	
  2215		return nr_reclaimed;
  2216	}
  2217	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki