All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neel Bullywon <neelb2403@gmail.com>
To: apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
	lukas.bulwahn@gmail.com
Cc: andy@kernel.org, linux-kernel@vger.kernel.org,
	Neel Bullywon <neelb2403@gmail.com>
Subject: [PATCH v3] checkpatch: mention fsleep() in MSLEEP and USLEEP_RANGE warnings
Date: Wed, 25 Feb 2026 10:21:35 -0500	[thread overview]
Message-ID: <20260225152135.7709-1-neelb2403@gmail.com> (raw)
In-Reply-To: <20260220230555.70073-1-neelb2403@gmail.com>

Expand the USLEEP_RANGE check to recommend fsleep() as the preferred
option over both usleep_range() and udelay(), and expand the MSLEEP
warning to suggest considering fsleep() for short msleep calls.
fsleep() autoselects the best sleep mechanism based on duration,
making it the preferred choice for sleep operations.

Signed-off-by: Neel Bullywon <neelb2403@gmail.com>
---
v3:
  - USLEEP_RANGE: reword to recommend fsleep() as preferred over others
    (Andy Shevchenko)
  - MSLEEP: add "consider using fsleep()" (Andy Shevchenko)
v2:
  - Reworded to keep usleep_range as primary suggestion and add fsleep()
    as additional reference (Joe Perches)

 scripts/checkpatch.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index c0250244cf7a..fc08c780610a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -6624,7 +6624,7 @@ sub process {
 			# ignore udelay's < 10, however
 			if (! ($delay < 10) ) {
 				CHK("USLEEP_RANGE",
-				    "usleep_range is preferred over udelay; see function description of usleep_range() and udelay().\n" . $herecurr);
+				    "fsleep() is preferred over others; usleep_range() is preferred over udelay(); see function descriptions of usleep_range(), udelay(), and fsleep().\n" . $herecurr);
 			}
 			if ($delay > 2000) {
 				WARN("LONG_UDELAY",
@@ -6636,7 +6636,7 @@ sub process {
 		if ($line =~ /\bmsleep\s*\((\d+)\);/) {
 			if ($1 < 20) {
 				WARN("MSLEEP",
-				     "msleep < 20ms can sleep for up to 20ms; see function description of msleep().\n" . $herecurr);
+				     "msleep < 20ms can sleep for up to 20ms; consider using fsleep(); see function description of msleep() and fsleep().\n" . $herecurr);
 			}
 		}
 
-- 
2.44.0


       reply	other threads:[~2026-02-25 15:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260220230555.70073-1-neelb2403@gmail.com>
2026-02-25 15:21 ` Neel Bullywon [this message]
2026-02-25 15:52   ` [PATCH v3] checkpatch: mention fsleep() in MSLEEP and USLEEP_RANGE warnings Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260225152135.7709-1-neelb2403@gmail.com \
    --to=neelb2403@gmail.com \
    --cc=andy@kernel.org \
    --cc=apw@canonical.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.