From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Neel Bullywon <neelb2403@gmail.com>
Cc: apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com,
lukas.bulwahn@gmail.com, andy@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] checkpatch: mention fsleep() in MSLEEP and USLEEP_RANGE warnings
Date: Wed, 25 Feb 2026 17:52:40 +0200 [thread overview]
Message-ID: <aZ8ayPdlBZCKjtwH@smile.fi.intel.com> (raw)
In-Reply-To: <20260225152135.7709-1-neelb2403@gmail.com>
On Wed, Feb 25, 2026 at 10:21:35AM -0500, Neel Bullywon wrote:
> Expand the USLEEP_RANGE check to recommend fsleep() as the preferred
> option over both usleep_range() and udelay(), and expand the MSLEEP
> warning to suggest considering fsleep() for short msleep calls.
> fsleep() autoselects the best sleep mechanism based on duration,
> making it the preferred choice for sleep operations.
Good enough to me.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
...
> - "usleep_range is preferred over udelay; see function description of usleep_range() and udelay().\n" . $herecurr);
> + "fsleep() is preferred over others; usleep_range() is preferred over udelay(); see function descriptions of usleep_range(), udelay(), and fsleep().\n" . $herecurr);
^^^ just for the context for the below.
...
> - "msleep < 20ms can sleep for up to 20ms; see function description of msleep().\n" . $herecurr);
> + "msleep < 20ms can sleep for up to 20ms; consider using fsleep(); see function description of msleep() and fsleep().\n" . $herecurr);
I think 'descriptions' should be plural here as well.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-02-25 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260220230555.70073-1-neelb2403@gmail.com>
2026-02-25 15:21 ` [PATCH v3] checkpatch: mention fsleep() in MSLEEP and USLEEP_RANGE warnings Neel Bullywon
2026-02-25 15:52 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ8ayPdlBZCKjtwH@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=neelb2403@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.