From: Chaitanya Kulkarni <kch@nvidia.com>
To: <kbusch@kernel.org>, <hch@lst.de>, <sagi@grimberg.me>, <wagi@monom.org>
Cc: <linux-block@vger.kernel.org>, <linux-nvme@lists.infradead.org>,
"Chaitanya Kulkarni" <kch@nvidia.com>
Subject: [PATCH v2 0/2] blk/nvme: fix NULL deref in rq_qos_done_bio() on multipath failover
Date: Wed, 25 Feb 2026 19:12:41 -0800 [thread overview]
Message-ID: <20260226031243.87200-1-kch@nvidia.com> (raw)
Hi,
When a bio is processed on a path's request queue with rq_qos enabled,
it gets BIO_QOS_THROTTLED or BIO_QOS_MERGED flags set. During NVMe
multipath failover, nvme_failover_req() redirects the bio's bi_bdev to
the multipath head's disk via bio_set_dev(), but the BIO_QOS flags are
left intact.
This series moves bio queue transition code into blk_steal_bios()
and adds a patch to clears BIO_QOS_THROTTLED and BIO_QOS_MERGED flags
in blk_steal_bios().
-ck
v1->v2 https://lore.kernel.org/all/20251124070142.GA17632@lst.de/:
* Add a new patch to move the bio flag fixup loop from nvme_failover_req()
into blk_steal_bios() rather than adding it only in the NVMe multipath
path. (Christoph)
Chaitanya Kulkarni (2):
block: move bio queue-transition flag fixups into blk_steal_bios()
block: clear BIO_QOS flags in blk_steal_bios()
block/blk-mq.c | 19 +++++++++++++++++++
drivers/nvme/host/multipath.c | 15 +--------------
2 files changed, 20 insertions(+), 14 deletions(-)
--
2.39.5
next reply other threads:[~2026-02-26 3:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 3:12 Chaitanya Kulkarni [this message]
2026-02-26 3:12 ` [PATCH V2 1/2] block: move bio queue-transition flag fixups into blk_steal_bios() Chaitanya Kulkarni
2026-02-26 15:32 ` Christoph Hellwig
2026-02-26 3:12 ` [PATCH V2 2/2] block: clear BIO_QOS flags in blk_steal_bios() Chaitanya Kulkarni
2026-02-26 15:33 ` Christoph Hellwig
2026-03-10 5:43 ` [PATCH v2 0/2] blk/nvme: fix NULL deref in rq_qos_done_bio() on multipath failover Chaitanya Kulkarni
2026-03-10 13:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226031243.87200-1-kch@nvidia.com \
--to=kch@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.