From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <kch@nvidia.com>
Cc: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, wagi@monom.org,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH V2 1/2] block: move bio queue-transition flag fixups into blk_steal_bios()
Date: Thu, 26 Feb 2026 16:32:58 +0100 [thread overview]
Message-ID: <20260226153258.GA31398@lst.de> (raw)
In-Reply-To: <20260226031243.87200-2-kch@nvidia.com>
On Wed, Feb 25, 2026 at 07:12:42PM -0800, Chaitanya Kulkarni wrote:
> blk_steal_bios() transfers bios from a request to a bio_list when the
> request is requeued to a different queue. The NVMe multipath failover
> path (nvme_failover_req) currently open-codes clearing of REQ_POLLED,
> bi_cookie, and REQ_NOWAIT on each bio before calling blk_steal_bios().
>
> Move these fixups into blk_steal_bios() itself so that any caller
> automatically gets correct flag state when bios cross queue boundaries.
> Simplify nvme_failover_req() accordingly.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-02-26 15:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 3:12 [PATCH v2 0/2] blk/nvme: fix NULL deref in rq_qos_done_bio() on multipath failover Chaitanya Kulkarni
2026-02-26 3:12 ` [PATCH V2 1/2] block: move bio queue-transition flag fixups into blk_steal_bios() Chaitanya Kulkarni
2026-02-26 15:32 ` Christoph Hellwig [this message]
2026-02-26 3:12 ` [PATCH V2 2/2] block: clear BIO_QOS flags in blk_steal_bios() Chaitanya Kulkarni
2026-02-26 15:33 ` Christoph Hellwig
2026-03-10 5:43 ` [PATCH v2 0/2] blk/nvme: fix NULL deref in rq_qos_done_bio() on multipath failover Chaitanya Kulkarni
2026-03-10 13:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226153258.GA31398@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.