From: Eric Biggers <ebiggers@kernel.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: linux-crypto@vger.kernel.org, David Howells <dhowells@redhat.com>,
Blaise Boscaccy <bboscaccy@linux.microsoft.com>
Subject: Re: [PATCH v3 3/5] crypto: pkcs7: allow pkcs7_digest() to be called from pkcs7_trust
Date: Thu, 26 Feb 2026 12:31:33 -0800 [thread overview]
Message-ID: <20260226203133.GB2273@sol> (raw)
In-Reply-To: <20260225211907.7368-4-James.Bottomley@HansenPartnership.com>
On Wed, Feb 25, 2026 at 04:19:05PM -0500, James Bottomley wrote:
> + /*
> + * if we're being called immediately after parse, the
> + * signature won't have a calculated digest yet, so calculate
> + * one. This function returns immediately if a digest has
> + * already been calculated
> + */
> + pkcs7_digest(pkcs7, sinfo);
pkcs7_digest() can fail, returning an error code and leaving sig->m ==
NULL && sig->m_size == 0. Here, the error is just being ignored.
Doesn't that then cause the signature verification to proceed against an
empty message, rather than anything related to the data provided?
- Eric
next prev parent reply other threads:[~2026-02-26 20:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 21:19 [PATCH v3 0/5] pkcs7: better handling of signed attributes James Bottomley
2026-02-25 21:19 ` [PATCH v3 1/5] certs: break out pkcs7 check into its own function James Bottomley
2026-02-25 21:19 ` [PATCH v3 2/5] crypto: pkcs7: add flag for validated trust on a signed info block James Bottomley
2026-02-25 21:19 ` [PATCH v3 3/5] crypto: pkcs7: allow pkcs7_digest() to be called from pkcs7_trust James Bottomley
2026-02-26 20:31 ` Eric Biggers [this message]
2026-02-27 3:50 ` James Bottomley
2026-03-05 7:58 ` Eric Biggers
2026-03-05 14:53 ` James Bottomley
2026-03-05 18:50 ` Eric Biggers
2026-03-05 20:11 ` James Bottomley
2026-03-05 21:36 ` Eric Biggers
2026-03-05 22:06 ` James Bottomley
2026-02-25 21:19 ` [PATCH v3 4/5] crypto: pkcs7: add ability to extract signed attributes by OID James Bottomley
2026-02-25 21:19 ` [PATCH v3 5/5] crypto: pkcs7: add tests for pkcs7_get_authattr James Bottomley
2026-02-26 1:12 ` kernel test robot
2026-02-26 2:13 ` [PATCH v3 0/5] pkcs7: better handling of signed attributes Eric Biggers
2026-02-26 12:43 ` James Bottomley
2026-03-05 7:55 ` Eric Biggers
2026-03-05 14:46 ` James Bottomley
2026-03-05 18:51 ` Eric Biggers
2026-03-05 20:18 ` James Bottomley
2026-03-05 21:40 ` Eric Biggers
2026-03-05 22:11 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260226203133.GB2273@sol \
--to=ebiggers@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bboscaccy@linux.microsoft.com \
--cc=dhowells@redhat.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.