* [PATCH] smb: client: Don't log plaintext credentials in cifs_set_cifscreds
@ 2026-02-26 21:28 Thorsten Blum
2026-02-26 21:41 ` Paulo Alcantara
0 siblings, 1 reply; 3+ messages in thread
From: Thorsten Blum @ 2026-02-26 21:28 UTC (permalink / raw)
To: Steve French, Paulo Alcantara, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, Bharath SM, Jeff Layton
Cc: Thorsten Blum, stable, Steve French, linux-cifs, samba-technical,
linux-kernel
When debug logging is enabled, cifs_set_cifscreds() logs the key
payload and exposes the plaintext username and password. Remove the
debug log to avoid exposing credentials.
Fixes: 8a8798a5ff90 ("cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts")
Cc: stable@vger.kernel.org
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/smb/client/connect.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/smb/client/connect.c b/fs/smb/client/connect.c
index 33dfe116ca52..038f87062419 100644
--- a/fs/smb/client/connect.c
+++ b/fs/smb/client/connect.c
@@ -2236,7 +2236,6 @@ cifs_set_cifscreds(struct smb3_fs_context *ctx, struct cifs_ses *ses)
/* find first : in payload */
payload = upayload->data;
delim = strnchr(payload, upayload->datalen, ':');
- cifs_dbg(FYI, "payload=%s\n", payload);
if (!delim) {
cifs_dbg(FYI, "Unable to find ':' in payload (datalen=%d)\n",
upayload->datalen);
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] smb: client: Don't log plaintext credentials in cifs_set_cifscreds
2026-02-26 21:28 [PATCH] smb: client: Don't log plaintext credentials in cifs_set_cifscreds Thorsten Blum
@ 2026-02-26 21:41 ` Paulo Alcantara
2026-02-26 23:27 ` Steve French
0 siblings, 1 reply; 3+ messages in thread
From: Paulo Alcantara @ 2026-02-26 21:41 UTC (permalink / raw)
To: Thorsten Blum, Steve French, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, Bharath SM, Jeff Layton
Cc: Thorsten Blum, stable, Steve French, linux-cifs, samba-technical,
linux-kernel
Thorsten Blum <thorsten.blum@linux.dev> writes:
> When debug logging is enabled, cifs_set_cifscreds() logs the key
> payload and exposes the plaintext username and password. Remove the
> debug log to avoid exposing credentials.
>
> Fixes: 8a8798a5ff90 ("cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts")
> Cc: stable@vger.kernel.org
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> fs/smb/client/connect.c | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] smb: client: Don't log plaintext credentials in cifs_set_cifscreds
2026-02-26 21:41 ` Paulo Alcantara
@ 2026-02-26 23:27 ` Steve French
0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2026-02-26 23:27 UTC (permalink / raw)
To: Paulo Alcantara
Cc: Thorsten Blum, Steve French, Ronnie Sahlberg, Shyam Prasad N,
Tom Talpey, Bharath SM, Jeff Layton, stable, linux-cifs,
samba-technical, linux-kernel
Added to cifs-2.6.git for-next pending additional testing (also added
the Acked-by)
On Thu, Feb 26, 2026 at 3:41 PM Paulo Alcantara <pc@manguebit.org> wrote:
>
> Thorsten Blum <thorsten.blum@linux.dev> writes:
>
> > When debug logging is enabled, cifs_set_cifscreds() logs the key
> > payload and exposes the plaintext username and password. Remove the
> > debug log to avoid exposing credentials.
> >
> > Fixes: 8a8798a5ff90 ("cifs: fetch credentials out of keyring for non-krb5 auth multiuser mounts")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > ---
> > fs/smb/client/connect.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Acked-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-26 23:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 21:28 [PATCH] smb: client: Don't log plaintext credentials in cifs_set_cifscreds Thorsten Blum
2026-02-26 21:41 ` Paulo Alcantara
2026-02-26 23:27 ` Steve French
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.