All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Rutherford via Intel-wired-lan <intel-wired-lan@osuosl.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	 Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	aleksander.lobakin@intel.com,
	 "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	 Eric Dumazet <edumazet@google.com>,
	intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	 David Decotigny <decot@google.com>,
	Anjali Singhai <anjali.singhai@intel.com>,
	 Sridhar Samudrala <sridhar.samudrala@intel.com>,
	Brian Vazquez <brianvv@google.com>,  Li Li <boolli@google.com>,
	emil.s.tantilov@intel.com,
	 Steve Rutherford <srutherford@google.com>
Subject: [Intel-wired-lan] [RFC PATCHv2 0/1] idpf: IDPF + SWIOTLB Bug
Date: Fri, 27 Feb 2026 20:34:56 +0000	[thread overview]
Message-ID: <20260227203457.558196-1-srutherford@google.com> (raw)

Found an issue with the IDPF driver when SWIOTLB is enabled. The issue
results in empty headers for packets that hit the split queue workaround
path. It's caused by a spurious sync in that path. The header is synced
from the SWIOTLB even when the header was shoved into the payload.

I cooked up a sample patch, but I'm not an expert in this driver, so I have
no idea if it's the right solution. It did allow my QEMU VM to boot with a
superficially functional passed-through IDPF NIC and SWIOTLB=force.

The patch was written against COS's 6.12, so I assume that it will not
apply cleanly elsewhere, but I figured a wrong sample patch was better than
a long paragraph describing the same thing. My read of more recent kernels
is that this problem is still present, but could be mistaken.

v2 - Updated title and tags based on feedback.

Steve Rutherford (1):
  idpf: Fix header clobber in IDPF with SWIOTLB enabled

 drivers/net/ethernet/intel/idpf/idpf_txrx.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

-- 
2.53.0.473.g4a7958ca14-goog


WARNING: multiple messages have this Message-ID (diff)
From: Steve Rutherford <srutherford@google.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>,
	 Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	aleksander.lobakin@intel.com,
	 "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	 Eric Dumazet <edumazet@google.com>,
	intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	 David Decotigny <decot@google.com>,
	Anjali Singhai <anjali.singhai@intel.com>,
	 Sridhar Samudrala <sridhar.samudrala@intel.com>,
	Brian Vazquez <brianvv@google.com>,  Li Li <boolli@google.com>,
	emil.s.tantilov@intel.com,
	 Steve Rutherford <srutherford@google.com>
Subject: [RFC PATCHv2 0/1] idpf: IDPF + SWIOTLB Bug
Date: Fri, 27 Feb 2026 20:34:56 +0000	[thread overview]
Message-ID: <20260227203457.558196-1-srutherford@google.com> (raw)

Found an issue with the IDPF driver when SWIOTLB is enabled. The issue
results in empty headers for packets that hit the split queue workaround
path. It's caused by a spurious sync in that path. The header is synced
from the SWIOTLB even when the header was shoved into the payload.

I cooked up a sample patch, but I'm not an expert in this driver, so I have
no idea if it's the right solution. It did allow my QEMU VM to boot with a
superficially functional passed-through IDPF NIC and SWIOTLB=force.

The patch was written against COS's 6.12, so I assume that it will not
apply cleanly elsewhere, but I figured a wrong sample patch was better than
a long paragraph describing the same thing. My read of more recent kernels
is that this problem is still present, but could be mistaken.

v2 - Updated title and tags based on feedback.

Steve Rutherford (1):
  idpf: Fix header clobber in IDPF with SWIOTLB enabled

 drivers/net/ethernet/intel/idpf/idpf_txrx.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

-- 
2.53.0.473.g4a7958ca14-goog


             reply	other threads:[~2026-02-27 20:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 20:34 Steve Rutherford via Intel-wired-lan [this message]
2026-02-27 20:34 ` [RFC PATCHv2 0/1] idpf: IDPF + SWIOTLB Bug Steve Rutherford
2026-02-27 20:34 ` [Intel-wired-lan] [RFC PATCHv2 1/1] idpf: Fix header clobber in IDPF with SWIOTLB enabled Steve Rutherford
2026-02-27 20:34   ` Steve Rutherford
2026-03-02  7:17   ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-02  7:17     ` Loktionov, Aleksandr
2026-03-03 15:31   ` Alexander Lobakin
2026-03-03 15:31     ` Alexander Lobakin
2026-03-03 19:44     ` [Intel-wired-lan] " Steve Rutherford via Intel-wired-lan
2026-03-03 19:44       ` Steve Rutherford
2026-03-04 15:11       ` [Intel-wired-lan] " Alexander Lobakin
2026-03-04 15:11         ` Alexander Lobakin
2026-03-04 22:01         ` [Intel-wired-lan] " Steve Rutherford via Intel-wired-lan
2026-03-04 22:01           ` Steve Rutherford
2026-03-06 14:50           ` [Intel-wired-lan] " Alexander Lobakin
2026-03-06 14:50             ` Alexander Lobakin
2026-03-06 19:35             ` [Intel-wired-lan] " Steve Rutherford via Intel-wired-lan
2026-03-06 19:35               ` Steve Rutherford
2026-03-12 16:30               ` [Intel-wired-lan] " Alexander Lobakin
2026-03-12 16:30                 ` Alexander Lobakin
2026-03-23 13:31                 ` [Intel-wired-lan] " Alexander Lobakin
2026-03-23 13:31                   ` Alexander Lobakin
2026-03-25  0:44                   ` [Intel-wired-lan] " Steve Rutherford via Intel-wired-lan
2026-03-25  0:44                     ` Steve Rutherford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260227203457.558196-1-srutherford@google.com \
    --to=intel-wired-lan@osuosl.org \
    --cc=aleksander.lobakin@intel.com \
    --cc=anjali.singhai@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=boolli@google.com \
    --cc=brianvv@google.com \
    --cc=davem@davemloft.net \
    --cc=decot@google.com \
    --cc=edumazet@google.com \
    --cc=emil.s.tantilov@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=srutherford@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.