From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: "Akihiko Odaki" <odaki@rsg.ci.i.u-tokyo.ac.jp>,
"Huang Rui" <ray.huang@amd.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Yiwei Zhang" <zzyiwei@gmail.com>,
"Sergio Lopez Pascual" <slp@redhat.com>
Cc: "Gert Wollny" <gert.wollny@collabora.com>,
qemu-devel@nongnu.org,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Alyssa Ross" <hi@alyssa.is>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Stefano Stabellini" <stefano.stabellini@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Xenia Ragiadakou" <xenia.ragiadakou@amd.com>,
"Honglei Huang" <honglei1.huang@amd.com>,
"Julia Zhang" <julia.zhang@amd.com>,
"Chen Jiqian" <Jiqian.Chen@amd.com>,
"Rob Clark" <robdclark@gmail.com>,
"Robert Beckett" <bob.beckett@collabora.com>
Subject: [PATCH v20 05/21] ui/sdl2: Restore original context after new context creation
Date: Sun, 1 Mar 2026 23:48:22 +0300 [thread overview]
Message-ID: <20260301204838.596994-6-dmitry.osipenko@collabora.com> (raw)
In-Reply-To: <20260301204838.596994-1-dmitry.osipenko@collabora.com>
SDL API changes GL context to a newly created GL context, which differs
from other GL providers that don't switch context. Change SDL backend to
restore the original GL context. This allows Qemu's virtio-gpu to support
new virglrenderer async-fencing feature for Virgl contexts, otherwise
virglrenderer's vrend creates a fence-sync context on the Qemu's
main-loop thread that erroneously stays in-use by the main-loop after
creation, not allowing vrend's fence-sync thread switch to this new
context that belongs to it.
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Yiwei Zhang <zzyiwei@gmail.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
ui/sdl2-gl.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c
index 5eca0248233e..fbac3edbc09d 100644
--- a/ui/sdl2-gl.c
+++ b/ui/sdl2-gl.c
@@ -139,10 +139,12 @@ QEMUGLContext sdl2_gl_create_context(DisplayGLCtx *dgc,
QEMUGLParams *params)
{
struct sdl2_console *scon = container_of(dgc, struct sdl2_console, dgc);
- SDL_GLContext ctx;
+ SDL_GLContext ctx, current_ctx;
assert(scon->opengl);
+ current_ctx = SDL_GL_GetCurrentContext();
+
SDL_GL_MakeCurrent(scon->real_window, scon->winctx);
SDL_GL_SetAttribute(SDL_GL_SHARE_WITH_CURRENT_CONTEXT, 1);
@@ -167,6 +169,9 @@ QEMUGLContext sdl2_gl_create_context(DisplayGLCtx *dgc,
SDL_GL_CONTEXT_PROFILE_ES);
ctx = SDL_GL_CreateContext(scon->real_window);
}
+
+ SDL_GL_MakeCurrent(scon->real_window, current_ctx);
+
return (QEMUGLContext)ctx;
}
--
2.52.0
next prev parent reply other threads:[~2026-03-01 20:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 20:48 [PATCH v20 00/21] Support virtio-gpu DRM native context and MAP_FIXED API Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 01/21] ui/gtk: Don't disable scanout when display is refreshed Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 02/21] ui/gtk: Restore original context after new context creation Dmitry Osipenko
2026-03-02 5:58 ` Akihiko Odaki
2026-03-02 12:01 ` Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 03/21] ui/gdk: " Dmitry Osipenko
2026-03-02 6:17 ` Akihiko Odaki
2026-03-01 20:48 ` [PATCH v20 04/21] ui/sdl2: Don't disable scanout when display is refreshed Dmitry Osipenko
2026-03-01 20:48 ` Dmitry Osipenko [this message]
2026-03-01 20:48 ` [PATCH v20 06/21] ui/sdl2: Implement dpy dmabuf functions Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 07/21] ui/egl-headless: Restore original context after new context creation Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 08/21] ui/spice: " Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 09/21] ui/dbus: " Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 10/21] virtio-gpu: Bounce virtio_gpu_ctrl_bh() to main-loop thread Dmitry Osipenko
2026-03-02 5:57 ` Akihiko Odaki
2026-03-02 11:59 ` Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 11/21] virtio-gpu: Handle virgl fence creation errors Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 12/21] virtio-gpu: Support asynchronous fencing Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 13/21] virtio-gpu: Support DRM native context Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 14/21] docs/system: virtio-gpu: Add link to Mesa VirGL doc Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 15/21] docs/system: virtio-gpu: Update Venus link Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 16/21] docs/system: virtio-gpu: Document host/guest requirements Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 17/21] virtio-gpu: Remove superfluous memory_region_set_enabled() Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 18/21] virtio-gpu: Validate hostmem mapping offset Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 19/21] virtio-gpu: Replace finish_unmapping with mapping_state Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 20/21] virtio-gpu: Destroy virgl resources on virtio-gpu reset Dmitry Osipenko
2026-03-01 20:48 ` [PATCH v20 21/21] virtio-gpu: Support mapping hostmem blobs with map_fixed Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260301204838.596994-6-dmitry.osipenko@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=Jiqian.Chen@amd.com \
--cc=alex.bennee@linaro.org \
--cc=alexander.deucher@amd.com \
--cc=bob.beckett@collabora.com \
--cc=christian.koenig@amd.com \
--cc=gert.wollny@collabora.com \
--cc=gurchetansingh@chromium.org \
--cc=hi@alyssa.is \
--cc=honglei1.huang@amd.com \
--cc=julia.zhang@amd.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=ray.huang@amd.com \
--cc=robdclark@gmail.com \
--cc=roger.pau@citrix.com \
--cc=slp@redhat.com \
--cc=stefano.stabellini@amd.com \
--cc=xenia.ragiadakou@amd.com \
--cc=zzyiwei@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.