From: Conor Dooley <conor@kernel.org>
To: Felix Gu <ustc.gu@gmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Linus Walleij <linusw@kernel.org>,
linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: microchip-mssio: Fix missing return in probe
Date: Mon, 2 Mar 2026 22:08:44 +0000 [thread overview]
Message-ID: <20260302-mayflower-filing-e111fbcc7d30@spud> (raw)
In-Reply-To: <20260303-mssio-v1-1-ea0fdf3bf202@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
On Tue, Mar 03, 2026 at 02:13:17AM +0800, Felix Gu wrote:
> In mpfs_pinctrl_probe(), when pctrl->regmap fails, it just print out an
> error message without return, which could lead serious errors.
>
> Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Felix Gu <ustc.gu@gmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Linus Walleij <linusw@kernel.org>,
linux-riscv@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: microchip-mssio: Fix missing return in probe
Date: Mon, 2 Mar 2026 22:08:44 +0000 [thread overview]
Message-ID: <20260302-mayflower-filing-e111fbcc7d30@spud> (raw)
In-Reply-To: <20260303-mssio-v1-1-ea0fdf3bf202@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 384 bytes --]
On Tue, Mar 03, 2026 at 02:13:17AM +0800, Felix Gu wrote:
> In mpfs_pinctrl_probe(), when pctrl->regmap fails, it just print out an
> error message without return, which could lead serious errors.
>
> Fixes: 488d704ed7b7 ("pinctrl: add polarfire soc mssio pinctrl driver")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-03-02 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 18:13 [PATCH] pinctrl: microchip-mssio: Fix missing return in probe Felix Gu
2026-03-02 18:13 ` Felix Gu
2026-03-02 22:08 ` Conor Dooley [this message]
2026-03-02 22:08 ` Conor Dooley
2026-03-03 7:34 ` Linus Walleij
2026-03-03 7:34 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302-mayflower-filing-e111fbcc7d30@spud \
--to=conor@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.