All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>, Chukun Pan <amadeus@jmu.edu.cn>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: spacemit: adapt regulator node name to preferred form
Date: Mon, 2 Mar 2026 19:42:57 +0800	[thread overview]
Message-ID: <20260302114257-GKA289813@kernel.org> (raw)
In-Reply-To: <87o6l6vd7l.fsf@ocarina.mail-host-address-is-not-set>

Hi Javier,

On 09:37 Mon 02 Mar     , Javier Martinez Canillas wrote:
> Yixun Lan <dlan@kernel.org> writes:
> 
> > The preferred node name for fixed-regulators has changed to pattern [1]:
> >  '^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$'
> >
> > Adjust all SpacemiT DT regulator node names to fix this.
> >
> > Link: https://lore.kernel.org/r/20240426215147.3138211-1-robh@kernel.org [1]
> > Signed-off-by: Yixun Lan <dlan@kernel.org>
> > ---
> > In Review of adding DTS for OrangePi, Chukun mentioned fixed-regulator
> > has preferred node names [1], so let's change it now.
> >
> > This isn't strictly a bug, so I've not added the Fixes tag.
> >
> > Link: https://lore.kernel.org/r/20260123145015.1926865-1-amadeus@jmu.edu.cn [1]
> > ---
> >  arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts   | 10 +++++-----
> >  arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts |  4 ++--
> >  2 files changed, 7 insertions(+), 7 deletions(-)
> >
> 
> Looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> 
A little bit late, I just picked this patch, but I can amend the commit to
add your R-b, thanks!

> -- 
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat
> 

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>, Chukun Pan <amadeus@jmu.edu.cn>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: spacemit: adapt regulator node name to preferred form
Date: Mon, 2 Mar 2026 19:42:57 +0800	[thread overview]
Message-ID: <20260302114257-GKA289813@kernel.org> (raw)
In-Reply-To: <87o6l6vd7l.fsf@ocarina.mail-host-address-is-not-set>

Hi Javier,

On 09:37 Mon 02 Mar     , Javier Martinez Canillas wrote:
> Yixun Lan <dlan@kernel.org> writes:
> 
> > The preferred node name for fixed-regulators has changed to pattern [1]:
> >  '^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$'
> >
> > Adjust all SpacemiT DT regulator node names to fix this.
> >
> > Link: https://lore.kernel.org/r/20240426215147.3138211-1-robh@kernel.org [1]
> > Signed-off-by: Yixun Lan <dlan@kernel.org>
> > ---
> > In Review of adding DTS for OrangePi, Chukun mentioned fixed-regulator
> > has preferred node names [1], so let's change it now.
> >
> > This isn't strictly a bug, so I've not added the Fixes tag.
> >
> > Link: https://lore.kernel.org/r/20260123145015.1926865-1-amadeus@jmu.edu.cn [1]
> > ---
> >  arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts   | 10 +++++-----
> >  arch/riscv/boot/dts/spacemit/k1-milkv-jupiter.dts |  4 ++--
> >  2 files changed, 7 insertions(+), 7 deletions(-)
> >
> 
> Looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> 
A little bit late, I just picked this patch, but I can amend the commit to
add your R-b, thanks!

> -- 
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat
> 

-- 
Yixun Lan (dlan)

  reply	other threads:[~2026-03-02 11:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26  9:35 [PATCH] riscv: dts: spacemit: adapt regulator node name to preferred form Yixun Lan
2026-02-26  9:35 ` Yixun Lan
2026-03-02  3:38 ` Yixun Lan
2026-03-02  3:38   ` Yixun Lan
2026-03-02  8:37 ` Javier Martinez Canillas
2026-03-02  8:37   ` Javier Martinez Canillas
2026-03-02 11:42   ` Yixun Lan [this message]
2026-03-02 11:42     ` Yixun Lan
2026-03-02 12:23     ` Javier Martinez Canillas
2026-03-02 12:23       ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260302114257-GKA289813@kernel.org \
    --to=dlan@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=amadeus@jmu.edu.cn \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=javierm@redhat.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.