From: Leon Romanovsky <leon@kernel.org>
To: Barry Song <21cnbao@gmail.com>
Cc: Juergen Gross <jgross@suse.com>,
Tangquan Zheng <zhengtangquan@oppo.com>,
Barry Song <baohua@kernel.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
will@kernel.org, Anshuman Khandual <anshuman.khandual@arm.com>,
catalin.marinas@arm.com, Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org,
Suren Baghdasaryan <surenb@google.com>,
iommu@lists.linux.dev, Xueyuan Chen <xueyuan.chen21@gmail.com>,
Marc Zyngier <maz@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
robin.murphy@arm.com, Ard Biesheuvel <ardb@kernel.org>,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH v3 4/5] dma-mapping: Separate DMA sync issuing and completion waiting
Date: Mon, 2 Mar 2026 21:53:32 +0200 [thread overview]
Message-ID: <20260302195332.GV12611@unreal> (raw)
In-Reply-To: <20260228221316.59934-1-21cnbao@gmail.com>
On Sun, Mar 01, 2026 at 06:13:16AM +0800, Barry Song wrote:
> From: Barry Song <baohua@kernel.org>
>
> Currently, arch_sync_dma_for_cpu and arch_sync_dma_for_device
> always wait for the completion of each DMA buffer. That is,
> issuing the DMA sync and waiting for completion is done in a
> single API call.
>
> For scatter-gather lists with multiple entries, this means
> issuing and waiting is repeated for each entry, which can hurt
> performance. Architectures like ARM64 may be able to issue all
> DMA sync operations for all entries first and then wait for
> completion together.
>
> To address this, arch_sync_dma_for_* now batches DMA operations
> and performs a flush afterward. On ARM64, the flush is implemented
> with a dsb instruction in arch_sync_dma_flush(). On other
> architectures, arch_sync_dma_flush() is currently a nop.
>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Ada Couprie Diaz <ada.coupriediaz@arm.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Cc: Tangquan Zheng <zhengtangquan@oppo.com>
> Reviewed-by: Juergen Gross <jgross@suse.com> # drivers/xen/swiotlb-xen.c
> Tested-by: Xueyuan Chen <xueyuan.chen21@gmail.com>
> Signed-off-by: Barry Song <baohua@kernel.org>
> ---
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/cache.h | 5 +++++
> arch/arm64/mm/dma-mapping.c | 4 ++--
> drivers/iommu/dma-iommu.c | 35 ++++++++++++++++++++++++++--------
> drivers/xen/swiotlb-xen.c | 24 +++++++++++++++--------
> include/linux/dma-map-ops.h | 6 ++++++
> kernel/dma/Kconfig | 3 +++
> kernel/dma/direct.c | 6 +++++-
> kernel/dma/direct.h | 9 +++++++--
> kernel/dma/swiotlb.c | 7 ++++++-
> 10 files changed, 78 insertions(+), 22 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: Barry Song <21cnbao@gmail.com>
Cc: catalin.marinas@arm.com, m.szyprowski@samsung.com,
robin.murphy@arm.com, will@kernel.org, iommu@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Barry Song <baohua@kernel.org>,
Ada Couprie Diaz <ada.coupriediaz@arm.com>,
Ard Biesheuvel <ardb@kernel.org>, Marc Zyngier <maz@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Suren Baghdasaryan <surenb@google.com>,
Joerg Roedel <joro@8bytes.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
Tangquan Zheng <zhengtangquan@oppo.com>,
Juergen Gross <jgross@suse.com>,
Xueyuan Chen <xueyuan.chen21@gmail.com>
Subject: Re: [PATCH v3 4/5] dma-mapping: Separate DMA sync issuing and completion waiting
Date: Mon, 2 Mar 2026 21:53:32 +0200 [thread overview]
Message-ID: <20260302195332.GV12611@unreal> (raw)
In-Reply-To: <20260228221316.59934-1-21cnbao@gmail.com>
On Sun, Mar 01, 2026 at 06:13:16AM +0800, Barry Song wrote:
> From: Barry Song <baohua@kernel.org>
>
> Currently, arch_sync_dma_for_cpu and arch_sync_dma_for_device
> always wait for the completion of each DMA buffer. That is,
> issuing the DMA sync and waiting for completion is done in a
> single API call.
>
> For scatter-gather lists with multiple entries, this means
> issuing and waiting is repeated for each entry, which can hurt
> performance. Architectures like ARM64 may be able to issue all
> DMA sync operations for all entries first and then wait for
> completion together.
>
> To address this, arch_sync_dma_for_* now batches DMA operations
> and performs a flush afterward. On ARM64, the flush is implemented
> with a dsb instruction in arch_sync_dma_flush(). On other
> architectures, arch_sync_dma_flush() is currently a nop.
>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Ada Couprie Diaz <ada.coupriediaz@arm.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Ryan Roberts <ryan.roberts@arm.com>
> Cc: Suren Baghdasaryan <surenb@google.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> Cc: Tangquan Zheng <zhengtangquan@oppo.com>
> Reviewed-by: Juergen Gross <jgross@suse.com> # drivers/xen/swiotlb-xen.c
> Tested-by: Xueyuan Chen <xueyuan.chen21@gmail.com>
> Signed-off-by: Barry Song <baohua@kernel.org>
> ---
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/cache.h | 5 +++++
> arch/arm64/mm/dma-mapping.c | 4 ++--
> drivers/iommu/dma-iommu.c | 35 ++++++++++++++++++++++++++--------
> drivers/xen/swiotlb-xen.c | 24 +++++++++++++++--------
> include/linux/dma-map-ops.h | 6 ++++++
> kernel/dma/Kconfig | 3 +++
> kernel/dma/direct.c | 6 +++++-
> kernel/dma/direct.h | 9 +++++++--
> kernel/dma/swiotlb.c | 7 ++++++-
> 10 files changed, 78 insertions(+), 22 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2026-03-02 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 22:13 [PATCH v3 4/5] dma-mapping: Separate DMA sync issuing and completion waiting Barry Song
2026-02-28 22:13 ` Barry Song
2026-03-02 19:53 ` Leon Romanovsky [this message]
2026-03-02 19:53 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260302195332.GV12611@unreal \
--to=leon@kernel.org \
--cc=21cnbao@gmail.com \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=baohua@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux.dev \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maz@kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=robin.murphy@arm.com \
--cc=ryan.roberts@arm.com \
--cc=sstabellini@kernel.org \
--cc=surenb@google.com \
--cc=will@kernel.org \
--cc=xueyuan.chen21@gmail.com \
--cc=zhengtangquan@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.