All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: adityag@linux.ibm.com, thuth@redhat.com, berrange@redhat.com,
	peterx@redhat.com
Subject: [PATCH v3 1/5] tests/functional/migration: Use socket_dir
Date: Tue,  3 Mar 2026 10:43:44 -0300	[thread overview]
Message-ID: <20260303134348.8890-2-farosas@suse.de> (raw)
In-Reply-To: <20260303134348.8890-1-farosas@suse.de>

Use QemuBaseTest.socket_dir instead of calling tempfile directly so
all tests have consistent directory prefixes.

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 tests/functional/migration.py | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/functional/migration.py b/tests/functional/migration.py
index 2bfb1f7790..0aa873edba 100644
--- a/tests/functional/migration.py
+++ b/tests/functional/migration.py
@@ -11,7 +11,6 @@
 # This work is licensed under the terms of the GNU GPL, version 2 or
 # later.  See the COPYING file in the top-level directory.
 
-import tempfile
 import time
 
 from qemu_test import QemuSystemTest, which
@@ -65,9 +64,8 @@ def migration_with_tcp_localhost(self):
             self.do_migrate(dest_uri)
 
     def migration_with_unix(self):
-        with tempfile.TemporaryDirectory(prefix='socket_') as socket_path:
-            dest_uri = 'unix:%s/qemu-test.sock' % socket_path
-            self.do_migrate(dest_uri)
+        dest_uri = 'unix:%s/migration.sock' % self.socket_dir().name
+        self.do_migrate(dest_uri)
 
     def migration_with_exec(self):
         if not which('ncat'):
-- 
2.51.0



  reply	other threads:[~2026-03-03 13:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 13:43 [PATCH v3 0/5] tests/functional: Fix ppc64 issue with make -j Fabiano Rosas
2026-03-03 13:43 ` Fabiano Rosas [this message]
2026-03-03 13:43 ` [PATCH v3 2/5] tests/functional/migration: Add migrate_vms Fabiano Rosas
2026-03-03 14:14   ` Thomas Huth
2026-03-03 13:43 ` [PATCH v3 3/5] tests/functional/migration: Use the migrate_vms helper Fabiano Rosas
2026-03-03 14:20   ` Thomas Huth
2026-03-03 13:43 ` [PATCH v3 4/5] tests/functional/ppc64/pseries: Inherit from MigrationTest Fabiano Rosas
2026-03-03 14:38   ` Thomas Huth
2026-03-03 15:46     ` Fabiano Rosas
2026-03-03 13:43 ` [PATCH v3 5/5] tests/functional/ppc64/pseries: Remove custom migration routine Fabiano Rosas
2026-03-03 14:40   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260303134348.8890-2-farosas@suse.de \
    --to=farosas@suse.de \
    --cc=adityag@linux.ibm.com \
    --cc=berrange@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.