Re: [PATCH v3 4/5] tests/functional/ppc64/pseries: Inherit from MigrationTest

[Fabiano Rosas <farosas@suse.de>]

Thomas Huth <thuth@redhat.com> writes:

> On 03/03/2026 14.43, Fabiano Rosas wrote:
>> Make the PseriesMachine class inherit from MigrationTest so the next
>> patch can access migration routines without needing to instantiate a
>> MigrationTest object. This is just for cleanliness of the code.
>> 
>> Note that creating a separate class for migration wouldn't work quite
>> well because the class attributes of PseriesMachine would then have to
>> be exposed to that class somehow.
>> 
>> Suggested-by: Peter Xu <peterx@redhat.com>
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>>   tests/functional/ppc64/test_pseries.py | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/tests/functional/ppc64/test_pseries.py b/tests/functional/ppc64/test_pseries.py
>> index b45763c305..ce39e16a22 100755
>> --- a/tests/functional/ppc64/test_pseries.py
>> +++ b/tests/functional/ppc64/test_pseries.py
>> @@ -11,7 +11,7 @@
>>   from qemu_test import wait_for_console_pattern
>>   from test_migration import PpcMigrationTest
>>   
>> -class PseriesMachine(QemuSystemTest):
>> +class PseriesMachine(MigrationTest):
>
> This patch does not work (without the following one). You only import 
> PpcMigrationTest, but not MigrationTest, so inheriting from MigrationTest is 
> not possible here...
>

Ouch, sorry. I'll repost.