All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Maxime Coquelin <mcoqueli@redhat.com>,
	Lei Yang <leiyang@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Koushik Dutta <kdutta@redhat.com>,
	Fabiano Rosas <farosas@suse.de>, Jason Wang <jasowang@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>
Subject: [RFC PATCH 0/8] Add vhost-vdpa and Shadow Virtqueue tests
Date: Thu,  5 Mar 2026 17:39:30 +0100	[thread overview]
Message-ID: <20260305163938.3200787-1-eperezma@redhat.com> (raw)

Based on vhost-user tests, the qos register itself as a VDUSE device and
receives the events from QEMU.

The test infrastructure creates a thread that acts as a VDUSE device, while the
regular test thread is managing QEMU.

This enables automated testing of vhost-vdpa code paths that previously
required manual testing.

Changes from vhost-user test:
* Automatic cleanup of many things.
* Handle the vduse fd and timeout.
* VDPA device cannot be removed before deleting QEMU, killing QEMU in
  vhost_vdpa_test_cleanup.
* Read in enable callbacks, and the actual test_read_guest_mem is just waiting.
* Add vhost_vdpa_thread to abstract fd monitoring
* Use QemuMutex and QemuConf for scoped cleanup

RFC: I'm not sure if this is the right place to add the tests in meson. Also, a
few things are just with asserts() or g_spawn(), instead of more elegant code.
I can clean them if this result useful.

Also, I don't know how to include the libvduse.a library as meson complains
it's out of the tests/ directory, so I'm including the .c directly.  Ugly but
it works for now.

The test verifies SVQ correctly handles batched pushes where multiple elements
are filled before flushing the used ring.

With this test, gcov reported coverage is:
                   Total  Hit
Lines:     83.9 %    347  291
Functions: 90.3 %     31   28
Branches:  59.2 %    157   93

Apart from impossible banches like scoped cleanups, the missing blocks
are:
* Full queue situations, or use a full queue at once with IN_ORDER.
* Event idx.
* All SVQ CVQ handling.
* Hard to reproduce casuistics like a linear buffer in GPA that is
  split into more than one buffer in HVA, and then SVQ is saturated.
* Buggy input (no descriptors, used descriptors that are not available,
  moving indexes more than vq size).
* Unbinding device call notifier from QEMU vhost system.
* Malicious inputs.

This builds on top of
https://mail.gnu.org/archive/html/qemu-devel/2026-03/msg01366.html

Eugenio Pérez (8):
  tests: vhost-vdpa: add initial VDUSE-based vhost-vdpa tests
  tests: vhost-vdpa: parameterize VDUSE operations
  tests: vhost-vdpa: add TX packet transmission test
  tests: vhost-vdpa: test SVQ cleanup of pending buffers
  tests: vhost-vdpa: add descriptor chain tests
  tests: vhost-vdpa: test out-of-order descriptor completion
  tests: vhost-vdpa: introduce TestParameters struct
  tests: vhost-vdpa: add VIRTIO_F_IN_ORDER feature tests

 tests/qtest/meson.build       |   3 +
 tests/qtest/vhost-vdpa-test.c | 805 ++++++++++++++++++++++++++++++++++
 2 files changed, 808 insertions(+)
 create mode 100644 tests/qtest/vhost-vdpa-test.c

-- 
2.53.0



             reply	other threads:[~2026-03-05 16:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05 16:39 Eugenio Pérez [this message]
2026-03-05 16:39 ` [RFC PATCH 1/8] tests: vhost-vdpa: add initial VDUSE-based vhost-vdpa tests Eugenio Pérez
2026-03-25 21:02   ` Fabiano Rosas
2026-03-05 16:39 ` [RFC PATCH 2/8] tests: vhost-vdpa: parameterize VDUSE operations Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 3/8] tests: vhost-vdpa: add TX packet transmission test Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 4/8] tests: vhost-vdpa: test SVQ cleanup of pending buffers Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 5/8] tests: vhost-vdpa: add descriptor chain tests Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 6/8] tests: vhost-vdpa: test out-of-order descriptor completion Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 7/8] tests: vhost-vdpa: introduce TestParameters struct Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 8/8] tests: vhost-vdpa: add VIRTIO_F_IN_ORDER feature tests Eugenio Pérez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260305163938.3200787-1-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=farosas@suse.de \
    --cc=jasowang@redhat.com \
    --cc=kdutta@redhat.com \
    --cc=leiyang@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mcoqueli@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.