From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Maxime Coquelin <mcoqueli@redhat.com>,
Lei Yang <leiyang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Koushik Dutta <kdutta@redhat.com>,
Fabiano Rosas <farosas@suse.de>, Jason Wang <jasowang@redhat.com>,
Laurent Vivier <lvivier@redhat.com>
Subject: [RFC PATCH 4/8] tests: vhost-vdpa: test SVQ cleanup of pending buffers
Date: Thu, 5 Mar 2026 17:39:34 +0100 [thread overview]
Message-ID: <20260305163938.3200787-5-eperezma@redhat.com> (raw)
In-Reply-To: <20260305163938.3200787-1-eperezma@redhat.com>
Add RX buffers to the receive queue before terminating QEMU to verify
that shadow virtqueue properly cleans up unused descriptors during
shutdown.
This tests the SVQ teardown path when descriptors remain in the
available ring but were never used by the device.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
tests/qtest/vhost-vdpa-test.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/tests/qtest/vhost-vdpa-test.c b/tests/qtest/vhost-vdpa-test.c
index 7b1c34aa415e..8dde7d95b167 100644
--- a/tests/qtest/vhost-vdpa-test.c
+++ b/tests/qtest/vhost-vdpa-test.c
@@ -40,10 +40,15 @@
#define QEMU_CMD_VDPA " -netdev type=vhost-vdpa,x-svq=on,vhostdev=%s,id=hs0"
#define VDUSE_RECONNECT_LOG "vduse_reconnect.log"
+static int NUM_RX_BUFS = 2;
+
typedef struct VdpaThread {
GThread *thread;
GMainLoop *loop;
GMainContext *context;
+
+ /* Guest memory that must be free at the end of the test */
+ uint64_t qemu_mem_to_free;
} VdpaThread;
static void *vhost_vdpa_thread_function(void *data)
@@ -82,6 +87,21 @@ static void vhost_vdpa_thread_add_source_fd(VdpaThread *t, int fd,
g_source_unref(src);
}
+static void vhost_vdpa_add_rx_pkts(QGuestAllocator *alloc, QVirtioNet *net,
+ VdpaThread *t)
+{
+ QTestState *qts = global_qtest;
+
+ t->qemu_mem_to_free = guest_alloc(alloc, 64);
+
+ for (int i = 0; i < NUM_RX_BUFS; i++) {
+ uint32_t head = qvirtqueue_add(qts, net->queues[0],
+ t->qemu_mem_to_free, 64,
+ /* write */ false, /* next */ false);
+ qvirtqueue_kick(qts, net->vdev, net->queues[0], head);
+ }
+}
+
/**
* Send a descriptor or a chain of descriptors to the device, and optionally
* and / or update the avail ring and avail_idx of the driver ring.
@@ -523,6 +543,9 @@ static void vhost_vdpa_tx_test(void *obj, void *arg, QGuestAllocator *alloc)
QVirtioNet *net = obj;
uint32_t free_head;
+ /* Add some rx packets so SVQ must clean them at the end of QEMU run */
+ vhost_vdpa_add_rx_pkts(alloc, net, &server->vdpa_thread);
+
free_head = vhost_vdpa_add_tx_pkt_descs(alloc, net, &server->vdpa_thread);
vhost_vdpa_kick_tx_desc(&server->vdpa_thread, net, free_head);
vhost_vdpa_get_tx_pkt(alloc, net, free_head, &server->vdpa_thread);
--
2.53.0
next prev parent reply other threads:[~2026-03-05 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 16:39 [RFC PATCH 0/8] Add vhost-vdpa and Shadow Virtqueue tests Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 1/8] tests: vhost-vdpa: add initial VDUSE-based vhost-vdpa tests Eugenio Pérez
2026-03-25 21:02 ` Fabiano Rosas
2026-03-05 16:39 ` [RFC PATCH 2/8] tests: vhost-vdpa: parameterize VDUSE operations Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 3/8] tests: vhost-vdpa: add TX packet transmission test Eugenio Pérez
2026-03-05 16:39 ` Eugenio Pérez [this message]
2026-03-05 16:39 ` [RFC PATCH 5/8] tests: vhost-vdpa: add descriptor chain tests Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 6/8] tests: vhost-vdpa: test out-of-order descriptor completion Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 7/8] tests: vhost-vdpa: introduce TestParameters struct Eugenio Pérez
2026-03-05 16:39 ` [RFC PATCH 8/8] tests: vhost-vdpa: add VIRTIO_F_IN_ORDER feature tests Eugenio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305163938.3200787-5-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=farosas@suse.de \
--cc=jasowang@redhat.com \
--cc=kdutta@redhat.com \
--cc=leiyang@redhat.com \
--cc=lvivier@redhat.com \
--cc=mcoqueli@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.