+ zram-use-gfp_kernel-for-post-processing-slot-allocation.patch added to mm-new branch

+ zram-use-gfp_kernel-for-post-processing-slot-allocation.patch added to mm-new branch

[Andrew Morton]

The patch titled
     Subject: zram: use GFP_KERNEL for post-processing slot allocation
has been added to the -mm mm-new branch.  Its filename is
     zram-use-gfp_kernel-for-post-processing-slot-allocation.patch

This patch will shortly appear at
     https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-use-gfp_kernel-for-post-processing-slot-allocation.patch

This patch will later appear in the mm-new branch at
    git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

Note, mm-new is a provisional staging ground for work-in-progress
patches, and acceptance into mm-new is a notification for others take
notice and to finish up reviews.  Please do not hesitate to respond to
review feedback and post updated versions to replace or incrementally
fixup patches in mm-new.

The mm-new branch of mm.git is not included in linux-next

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days

------------------------------------------------------
From: Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: zram: use GFP_KERNEL for post-processing slot allocation
Date: Thu, 5 Mar 2026 11:16:03 +0900

Post-processing slot allocation used to be performed under slot bit-lock,
so gfp was restricted, then we switched to a sleepable slot lock but gpf
still remained restricted.  Drop that restriction and use GFP_KERNEL
instead.

Link: https://lkml.kernel.org/r/20260305021619.617481-1-senozhatsky@chromium.org
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Acked-by: Brian Geffon <bgeffon@google.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/block/zram/zram_drv.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/block/zram/zram_drv.c~zram-use-gfp_kernel-for-post-processing-slot-allocation
+++ a/drivers/block/zram/zram_drv.c
@@ -297,7 +297,7 @@ static bool place_pp_slot(struct zram *z
 	struct zram_pp_slot *pps;
 	u32 bid;
 
-	pps = kmalloc_obj(*pps, GFP_NOIO | __GFP_NOWARN);
+	pps = kmalloc_obj(*pps, GFP_KERNEL | __GFP_NOWARN);
 	if (!pps)
 		return false;
 
_

Patches currently in -mm which might be from senozhatsky@chromium.org are

zram-do-not-autocorrect-bad-recompression-parameters.patch
zram-drop-num_active_comps.patch
zram-recompression-priority-param-should-override-algo.patch
zram-update-recompression-documentation.patch
zram-remove-chained-recompression.patch
zram-use-gfp_kernel-for-post-processing-slot-allocation.patch

Re: + zram-use-gfp_kernel-for-post-processing-slot-allocation.patch added to mm-new branch

[Sergey Senozhatsky]

On (26/03/05 17:49), Andrew Morton wrote:
> 
> The patch titled
>      Subject: zram: use GFP_KERNEL for post-processing slot allocation
> has been added to the -mm mm-new branch.  Its filename is
>      zram-use-gfp_kernel-for-post-processing-slot-allocation.patch
> 
> This patch will shortly appear at
>      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/zram-use-gfp_kernel-for-post-processing-slot-allocation.patch

[..]

> 
> Post-processing slot allocation used to be performed under slot bit-lock,
> so gfp was restricted, then we switched to a sleepable slot lock but gpf
> still remained restricted.  Drop that restriction and use GFP_KERNEL
> instead.
> 
> Link: https://lkml.kernel.org/r/20260305021619.617481-1-senozhatsky@chromium.org
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
> Acked-by: Brian Geffon <bgeffon@google.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: Minchan Kim <minchan@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/block/zram/zram_drv.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/block/zram/zram_drv.c~zram-use-gfp_kernel-for-post-processing-slot-allocation
> +++ a/drivers/block/zram/zram_drv.c
> @@ -297,7 +297,7 @@ static bool place_pp_slot(struct zram *z
>  	struct zram_pp_slot *pps;
>  	u32 bid;
>  
> -	pps = kmalloc_obj(*pps, GFP_NOIO | __GFP_NOWARN);
> +	pps = kmalloc_obj(*pps, GFP_KERNEL | __GFP_NOWARN);
>  	if (!pps)
>  		return false;

Right... that was silly.
Andrew, can you please drop this patch?  We cannot reclaim memory
in place_pp_slot(), because it's called under slot-lock, which is
IO lock for zram.  We cannot re-enter zram under IO lock, so we have
to keep using GFP_NOIO here.