* [PATCH] lib/uuid: fix typo "reversion" to "revision" in comment
@ 2026-03-06 16:12 Josh Law
2026-03-06 19:00 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Josh Law @ 2026-03-06 16:12 UTC (permalink / raw)
To: andriy.shevchenko, akpm; +Cc: linux-kernel, Josh Law
Fix a typo in __uuid_gen_common() where "reversion" (meaning to revert)
was used instead of "revision" when describing the UUID variant field.
Signed-off-by: Josh Law <objecting@objecting.org>
---
lib/uuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/uuid.c b/lib/uuid.c
index e8543c668dc7..128a51f1879b 100644
--- a/lib/uuid.c
+++ b/lib/uuid.c
@@ -54,7 +54,7 @@ EXPORT_SYMBOL(generate_random_guid);
static void __uuid_gen_common(__u8 b[16])
{
get_random_bytes(b, 16);
- /* reversion 0b10 */
+ /* revision 0b10 */
b[8] = (b[8] & 0x3F) | 0x80;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] lib/uuid: fix typo "reversion" to "revision" in comment
2026-03-06 16:12 [PATCH] lib/uuid: fix typo "reversion" to "revision" in comment Josh Law
@ 2026-03-06 19:00 ` Andy Shevchenko
2026-03-06 19:03 ` Josh Law
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2026-03-06 19:00 UTC (permalink / raw)
To: Josh Law; +Cc: akpm, linux-kernel, Josh Law
On Fri, Mar 06, 2026 at 04:12:50PM +0000, Josh Law wrote:
> Fix a typo in __uuid_gen_common() where "reversion" (meaning to revert)
> was used instead of "revision" when describing the UUID variant field.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] lib/uuid: fix typo "reversion" to "revision" in comment
2026-03-06 19:00 ` Andy Shevchenko
@ 2026-03-06 19:03 ` Josh Law
2026-03-06 19:07 ` Andy Shevchenko
2026-03-06 19:15 ` Andrew Morton
0 siblings, 2 replies; 5+ messages in thread
From: Josh Law @ 2026-03-06 19:03 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: akpm, linux-kernel, Josh Law
6 Mar 2026 19:00:09 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> On Fri, Mar 06, 2026 at 04:12:50PM +0000, Josh Law wrote:
>> Fix a typo in __uuid_gen_common() where "reversion" (meaning to revert)
>> was used instead of "revision" when describing the UUID variant field.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> --
> With Best Regards,
> Andy Shevchenko
Hello Andy, Andrew has already merged this patch, you will have to inquire with him to add your reviewed by
V/R
V/R
Josh law
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] lib/uuid: fix typo "reversion" to "revision" in comment
2026-03-06 19:03 ` Josh Law
@ 2026-03-06 19:07 ` Andy Shevchenko
2026-03-06 19:15 ` Andrew Morton
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2026-03-06 19:07 UTC (permalink / raw)
To: Josh Law; +Cc: akpm, linux-kernel, Josh Law
On Fri, Mar 06, 2026 at 07:03:57PM +0000, Josh Law wrote:
> 6 Mar 2026 19:00:09 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> > On Fri, Mar 06, 2026 at 04:12:50PM +0000, Josh Law wrote:
> >> Fix a typo in __uuid_gen_common() where "reversion" (meaning to revert)
> >> was used instead of "revision" when describing the UUID variant field.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Andrew has already merged this patch, you will have to inquire with him to
> add your reviewed by
It's up to his process. I know that it's possible. In any case I'm listed as
designated reviewer, this tag formally confirms that I agree with the change
and it is good code wise from my point of view.
Please, read Submitting Patches documentation to clarify this.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] lib/uuid: fix typo "reversion" to "revision" in comment
2026-03-06 19:03 ` Josh Law
2026-03-06 19:07 ` Andy Shevchenko
@ 2026-03-06 19:15 ` Andrew Morton
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2026-03-06 19:15 UTC (permalink / raw)
To: Josh Law; +Cc: Andy Shevchenko, linux-kernel, Josh Law
On Fri, 6 Mar 2026 19:03:57 +0000 Josh Law <hlcj1234567@gmail.com> wrote:
> 6 Mar 2026 19:00:09 Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
>
> > On Fri, Mar 06, 2026 at 04:12:50PM +0000, Josh Law wrote:
> >> Fix a typo in __uuid_gen_common() where "reversion" (meaning to revert)
> >> was used instead of "revision" when describing the UUID variant field.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >
> > --
> > With Best Regards,
> > Andy Shevchenko
>
> Hello Andy, Andrew has already merged this patch, you will have to inquire with him to add your reviewed by
I hold patches in quilt form for at least a few weeks before committing
them to non-rebasing git. One of the many reasons for this is make
changelog alterations super easy.
Btw, I rewrote all your patches to be From: objecting@objecting.org.
Please use an explicit From: line at the top-of-changelog to
communicate this. All receiving tools understand this convention.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-06 19:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-06 16:12 [PATCH] lib/uuid: fix typo "reversion" to "revision" in comment Josh Law
2026-03-06 19:00 ` Andy Shevchenko
2026-03-06 19:03 ` Josh Law
2026-03-06 19:07 ` Andy Shevchenko
2026-03-06 19:15 ` Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.