* Re: [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p @ 2026-03-08 14:44 kernel test robot 0 siblings, 0 replies; 4+ messages in thread From: kernel test robot @ 2026-03-08 14:44 UTC (permalink / raw) To: oe-kbuild :::::: :::::: Manual check reason: "high confidence checkpatch report" :::::: BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev In-Reply-To: <20260308132446.3320848-10-michal.grzelak@intel.com> References: <20260308132446.3320848-10-michal.grzelak@intel.com> TO: "Michał Grzelak" <michal.grzelak@intel.com> Hi Michał, [This is a private test report for your RFC patch.] kernel test robot noticed the following build warnings: [auto build test WARNING on drm-i915/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Micha-Grzelak/drm-i915-bios-search-for-Block-57-by-default/20260308-214619 base: https://gitlab.freedesktop.org/drm/i915/kernel.git for-linux-next patch link: https://lore.kernel.org/r/20260308132446.3320848-10-michal.grzelak%40intel.com patch subject: [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p :::::: branch date: 49 minutes ago :::::: commit date: 49 minutes ago reproduce: (https://download.01.org/0day-ci/archive/20260308/202603081552.dgEPyniE-lkp@intel.com/reproduce) # many are suggestions rather than must-fix WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #159: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:1878: + /* FIXME need to check correct parsing & table index should + * this ever trigger. -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC v1 00/11] support for vswing/preemphasis override @ 2026-03-08 13:24 Michał Grzelak 2026-03-08 13:24 ` [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p Michał Grzelak 0 siblings, 1 reply; 4+ messages in thread From: Michał Grzelak @ 2026-03-08 13:24 UTC (permalink / raw) To: intel-gfx, intel-xe; +Cc: Michał Grzelak This patch series aims to get initial feedback & CI coverage on adding support for Vswing / Preemphasis Override from VBT. Currently patchset covers all platforms from MTL onward. There is an additional patch covering platforms from ADL-P, but since it is still work-in-progress, it hasn't been included for now. BR, Michał Michał Grzelak (11): drm/i915/bios: search for Block 57 by default drm/i915/bios: cache V/P Override block drm/i915/bios: remove V/P Override warning drm/i915/bios: print V/P Override port info drm/i915/buf_trans: add intel_dp_above_hbr1() helper drm/i915/buf_trans: add intel_edp_above_hbr2() helper drm/i915/lt: align xe3plpd with V/P Override layout drm/i915/buf_trans: switch from u8 to u32 drm/i915/xe3p: add V/P Override support for xe3p drm/i915/dg2: warn on V/P Override request on dg2 drm/i915/mtl: add V/P Override support for mtl+ drivers/gpu/drm/i915/display/intel_bios.c | 33 +- drivers/gpu/drm/i915/display/intel_bios.h | 1 + .../drm/i915/display/intel_ddi_buf_trans.c | 323 ++++++++++++++---- .../drm/i915/display/intel_ddi_buf_trans.h | 16 +- .../gpu/drm/i915/display/intel_display_core.h | 2 + 5 files changed, 300 insertions(+), 75 deletions(-) -- 2.45.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p 2026-03-08 13:24 [RFC v1 00/11] support for vswing/preemphasis override Michał Grzelak @ 2026-03-08 13:24 ` Michał Grzelak 2026-03-09 0:11 ` kernel test robot 2026-03-10 8:40 ` kernel test robot 0 siblings, 2 replies; 4+ messages in thread From: Michał Grzelak @ 2026-03-08 13:24 UTC (permalink / raw) To: intel-gfx, intel-xe; +Cc: Michał Grzelak Add macros to reflect the layout of vswing/preemphasis override tables for xe3p. Add separate intel_ddi_buf_trans_entry to be overridden for xe3plpd. Set & return it when port requests to override default table. Set the value by extracting the lowest byte from entry from the table. There are no changes to intel_ddi_dp_level() since selection of correct row of intel_ddi_buf_trans_entry is same as when no override request has been done. Add FIXME & warning when EDP is requested to be overridden. beware of endianness: during VBT parsing, u32's were split into u8; read u32 from selected row to restore it; windows assumes u8, so extract the lowest byte. Signed-off-by: Michał Grzelak <michal.grzelak@intel.com> --- .../drm/i915/display/intel_ddi_buf_trans.c | 102 +++++++++++++++++- 1 file changed, 99 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c index 528a0ccfe8a2..632a5fe08381 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c +++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c @@ -12,6 +12,16 @@ #include "intel_dp.h" #include "intel_lt_phy.h" +#define XE3P_VS_PE_EDP 3 +#define XE3P_VS_PE_DP14 4 +#define XE3P_VS_PE_DP21 5 + +#define XE3P_VS_PE_COL 5 +#define XE3P_VS_PE_ROW 16 + +#define VS_PE_MASK 0x000000ff + +#define LOW(x) ((x) & (VS_PE_MASK)) /* HDMI/DVI modes ignore everything but the last 2 items. So we share * them for both DP and FDI transports, allowing those ports to * automatically adapt to HDMI connections as well @@ -1164,6 +1174,25 @@ static const union intel_ddi_buf_trans_entry _xe3plpd_lt_trans_edp[] = { { .lt = { 26, 0, 0, 1, 3 } }, }; +static union intel_ddi_buf_trans_entry _xe3plpd_lt_trans_override[] = { + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, + { .lt = { 0, 0, 0, 0, 0 } }, +}; + static const struct intel_ddi_buf_trans xe3plpd_lt_trans_dp14 = { .entries = _xe3plpd_lt_trans_dp14, .num_entries = ARRAY_SIZE(_xe3plpd_lt_trans_dp14), @@ -1179,11 +1208,29 @@ static const struct intel_ddi_buf_trans xe3plpd_lt_trans_edp = { .num_entries = ARRAY_SIZE(_xe3plpd_lt_trans_edp), }; +static struct intel_ddi_buf_trans xe3plpd_lt_trans_override = { + .entries = _xe3plpd_lt_trans_override, + .num_entries = ARRAY_SIZE(_xe3plpd_lt_trans_override), +}; + bool is_hobl_buf_trans(const struct intel_ddi_buf_trans *table) { return table == &tgl_combo_phy_trans_edp_hbr2_hobl; } +static const u32 *find_row(const u32 *tables, + int idx, + int row, + int row_no, + int col_no) +{ + size_t ent_sz = sizeof(*tables); + size_t row_sz = col_no * ent_sz; + size_t tbl_sz = row_no * row_sz; + size_t offset = idx * tbl_sz + row * row_sz; + return &tables[offset]; +} + static bool intel_dp_above_hbr1(const struct intel_crtc_state *crtc_state) { if (crtc_state->port_clock > 270000) @@ -1785,17 +1832,66 @@ mtl_get_c20_buf_trans(struct intel_encoder *encoder, return intel_get_buf_trans(&mtl_c20_trans_dp14, n_entries); } +static const struct intel_ddi_buf_trans * +xe3plpd_set_lt_buf_trans(struct intel_encoder *encoder, + int idx, + int *n_entries) +{ + struct intel_display *display = to_intel_display(encoder); + struct intel_ddi_buf_trans *buf_trans = &xe3plpd_lt_trans_override; + union intel_ddi_buf_trans_entry *entries, *entry; + const u32 *tables = display->vbt.override_vswing; + const u32 *vals; + + entries = (union intel_ddi_buf_trans_entry *) buf_trans->entries; + for (int row = 0; row < XE3P_VS_PE_ROW; row++) { + entry = &entries[row]; + vals = find_row(tables, + idx, + row, + XE3P_VS_PE_ROW, + XE3P_VS_PE_COL); + + entry->lt.main_cursor = LOW(vals[0]); + entry->lt.pre_cursor = LOW(vals[1]); + entry->lt.post_cursor = LOW(vals[2]); + entry->lt.txswing = LOW(vals[3]); + entry->lt.txswing_level = LOW(vals[4]); + } + + return intel_get_buf_trans(&xe3plpd_lt_trans_override, n_entries); +} + static const struct intel_ddi_buf_trans * xe3plpd_get_lt_buf_trans(struct intel_encoder *encoder, const struct intel_crtc_state *crtc_state, int *n_entries) { - if (intel_crtc_has_dp_encoder(crtc_state) && intel_dp_is_uhbr(crtc_state)) + if (intel_crtc_has_dp_encoder(crtc_state) && intel_dp_is_uhbr(crtc_state)) { + if (intel_bios_encoder_overrides_vswing(encoder->devdata)) + return xe3plpd_set_lt_buf_trans(encoder, + XE3P_VS_PE_DP21, + n_entries); return intel_get_buf_trans(&xe3plpd_lt_trans_uhbr, n_entries); - else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP)) + } else if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_EDP)) { + /* FIXME need to check correct parsing & table index should + * this ever trigger. + * return xe3plpd_set_lt_buf_trans(encoder, + * XE3P_VS_PE_EDP, + * n_entries); + */ + drm_WARN(to_intel_display(encoder)->drm, + intel_bios_encoder_overrides_vswing(encoder->devdata), + "Port %s asks to override EDP's vswing/preemph tables\n", + port_name(intel_bios_encoder_port(encoder->devdata))); return intel_get_buf_trans(&xe3plpd_lt_trans_edp, n_entries); - else + } else { + if (intel_bios_encoder_overrides_vswing(encoder->devdata)) + return xe3plpd_set_lt_buf_trans(encoder, + XE3P_VS_PE_DP14, + n_entries); return intel_get_buf_trans(&xe3plpd_lt_trans_dp14, n_entries); + } } void intel_ddi_buf_trans_init(struct intel_encoder *encoder) -- 2.45.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p 2026-03-08 13:24 ` [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p Michał Grzelak @ 2026-03-09 0:11 ` kernel test robot 2026-03-10 8:40 ` kernel test robot 1 sibling, 0 replies; 4+ messages in thread From: kernel test robot @ 2026-03-09 0:11 UTC (permalink / raw) To: Michał Grzelak; +Cc: oe-kbuild-all Hi Michał, [This is a private test report for your RFC patch.] kernel test robot noticed the following build warnings: [auto build test WARNING on drm-i915/for-linux-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Micha-Grzelak/drm-i915-bios-search-for-Block-57-by-default/20260308-214619 base: https://gitlab.freedesktop.org/drm/i915/kernel.git for-linux-next patch link: https://lore.kernel.org/r/20260308132446.3320848-10-michal.grzelak%40intel.com patch subject: [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p reproduce: (https://download.01.org/0day-ci/archive/20260308/202603081552.dgEPyniE-lkp@intel.com/reproduce) # many are suggestions rather than must-fix WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #159: FILE: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:1878: + /* FIXME need to check correct parsing & table index should + * this ever trigger. -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p 2026-03-08 13:24 ` [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p Michał Grzelak 2026-03-09 0:11 ` kernel test robot @ 2026-03-10 8:40 ` kernel test robot 1 sibling, 0 replies; 4+ messages in thread From: kernel test robot @ 2026-03-10 8:40 UTC (permalink / raw) To: Michał Grzelak; +Cc: oe-kbuild-all Hi Michał, [This is a private test report for your RFC patch.] kernel test robot noticed the following build warnings: [auto build test WARNING on drm-i915/for-linux-next] [also build test WARNING on drm-i915/for-linux-next-fixes drm-tip/drm-tip linus/master v7.0-rc3 next-20260309] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Micha-Grzelak/drm-i915-bios-search-for-Block-57-by-default/20260308-214619 base: https://gitlab.freedesktop.org/drm/i915/kernel.git for-linux-next patch link: https://lore.kernel.org/r/20260308132446.3320848-10-michal.grzelak%40intel.com patch subject: [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p config: parisc-allmodconfig (https://download.01.org/0day-ci/archive/20260310/202603101623.t8tVjYsz-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 15.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260310/202603101623.t8tVjYsz-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202603101623.t8tVjYsz-lkp@intel.com/ All warnings (new ones prefixed by >>): In file included from arch/parisc/include/asm/bug.h:97, from include/linux/bug.h:5, from include/linux/thread_info.h:13, from include/linux/sched.h:14, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/drm/drm_print.h:31, from drivers/gpu/drm/i915/display/intel_de.h:9, from drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:9: drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c: In function 'xe3plpd_get_lt_buf_trans': >> include/drm/drm_print.h:779:25: warning: format '%s' expects argument of type 'char *', but argument 4 has type 'int' [-Wformat=] 779 | WARN(condition, "%s %s: [drm] " format, \ | ^~~~~~~~~~~~~~~ include/asm-generic/bug.h:133:31: note: in definition of macro '__WARN_printf' 133 | __warn_printk(arg); \ | ^~~ include/drm/drm_print.h:779:9: note: in expansion of macro 'WARN' 779 | WARN(condition, "%s %s: [drm] " format, \ | ^~~~ drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:1883:17: note: in expansion of macro 'drm_WARN' 1883 | drm_WARN(to_intel_display(encoder)->drm, | ^~~~~~~~ vim +779 include/drm/drm_print.h 3bf149bd3fe12a Jani Nikula 2019-10-28 760 20f5583dd7a510 Nirmoy Das 2023-12-06 761 #define drm_dbg_ratelimited(drm, fmt, ...) \ 20f5583dd7a510 Nirmoy Das 2023-12-06 762 __DRM_DEFINE_DBG_RATELIMITED(DRIVER, drm, fmt, ## __VA_ARGS__) 20f5583dd7a510 Nirmoy Das 2023-12-06 763 c5261e93758a6b Lyude Paul 2021-03-26 764 #define drm_dbg_kms_ratelimited(drm, fmt, ...) \ c5261e93758a6b Lyude Paul 2021-03-26 765 __DRM_DEFINE_DBG_RATELIMITED(KMS, drm, fmt, ## __VA_ARGS__) c5261e93758a6b Lyude Paul 2021-03-26 766 dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 767 /* dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 768 * struct drm_device based WARNs dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 769 * dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 770 * drm_WARN*() acts like WARN*(), but with the key difference of dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 771 * using device specific information so that we know from which device dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 772 * warning is originating from. dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 773 * dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 774 * Prefer drm_device based drm_WARN* over regular WARN* dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 775 */ dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 776 dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 777 /* Helper for struct drm_device based WARNs */ dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 778 #define drm_WARN(drm, condition, format, arg...) \ 0d11307022978f Michal Wajdeczko 2024-05-23 @779 WARN(condition, "%s %s: [drm] " format, \ d05386a3fdf373 Jani Nikula 2025-01-23 780 dev_driver_string(__drm_to_dev(drm)), \ d05386a3fdf373 Jani Nikula 2025-01-23 781 dev_name(__drm_to_dev(drm)), ## arg) dc1a73e50f9c63 Pankaj Bharadiya 2020-01-15 782 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-10 8:41 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-08 14:44 [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p kernel test robot -- strict thread matches above, loose matches on Subject: below -- 2026-03-08 13:24 [RFC v1 00/11] support for vswing/preemphasis override Michał Grzelak 2026-03-08 13:24 ` [RFC v1 09/11] drm/i915/xe3p: add V/P Override support for xe3p Michał Grzelak 2026-03-09 0:11 ` kernel test robot 2026-03-10 8:40 ` kernel test robot
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.