All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yixun Lan <dlan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Rob Herring <robh@kernel.org>, Paul Walmsley <pjw@kernel.org>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor+dt@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, spacemit@lists.linux.dev
Subject: Re: [PATCH v2 1/1] riscv: dts: spacemit: Add 'linux,pci-domain' to PCIe nodes for K1
Date: Mon, 9 Mar 2026 18:51:56 +0800	[thread overview]
Message-ID: <20260309105156-GKD302167@kernel.org> (raw)
In-Reply-To: <20260309030000.1157040-1-amadeus@jmu.edu.cn>

Hi Chukun,

On 11:00 Mon 09 Mar     , Chukun Pan wrote:
> The SpacemiT K1 SoC has 3 PCIe EP controller nodes. Add the
> 'linux,pci-domain' property to assign a PCI domain number to
> each of the controllers instead of assigning it randomly.
> 
> This creates a stable sysfs path, allowing userspace scripts
> to reliably target specific PCIe devices (such as PCIe NICs).
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Looks good to me

Reviewed-by: Yixun Lan <dlan@kernel.org>

> ---
> Changes in v2:
> - Improve the commit messages
> ---
>  arch/riscv/boot/dts/spacemit/k1.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
> index 529ec68e9c23..d2015201f8e5 100644
> --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
> @@ -1033,6 +1033,7 @@ pcie-bus {
>  			#size-cells = <2>;
>  			dma-ranges = <0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>,
>  				     <0x0 0xb8000000 0x1 0x38000000 0x3 0x48000000>;
> +
>  			pcie0: pcie@ca000000 {
>  				device_type = "pci";
>  				compatible = "spacemit,k1-pcie";
> @@ -1044,6 +1045,7 @@ pcie0: pcie@ca000000 {
>  					    "atu",
>  					    "config",
>  					    "link";
> +				linux,pci-domain = <0>;
>  				#address-cells = <3>;
>  				#size-cells = <2>;
>  				ranges = <0x01000000 0x0 0x00000000 0x0 0x8f002000 0x0 0x00100000>,
> @@ -1087,6 +1089,7 @@ pcie1: pcie@ca400000 {
>  					    "atu",
>  					    "config",
>  					    "link";
> +				linux,pci-domain = <1>;
>  				#address-cells = <3>;
>  				#size-cells = <2>;
>  				ranges = <0x01000000 0x0 0x00000000 0x0 0x9f002000 0x0 0x00100000>,
> @@ -1130,6 +1133,7 @@ pcie2: pcie@ca800000 {
>  					    "atu",
>  					    "config",
>  					    "link";
> +				linux,pci-domain = <2>;
>  				#address-cells = <3>;
>  				#size-cells = <2>;
>  				ranges = <0x01000000 0x0 0x00000000 0x0 0xb7002000 0x0 0x00100000>,
> -- 
> 2.25.1
> 

-- 
Yixun Lan (dlan)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Yixun Lan <dlan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Rob Herring <robh@kernel.org>, Paul Walmsley <pjw@kernel.org>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Conor Dooley <conor+dt@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, spacemit@lists.linux.dev
Subject: Re: [PATCH v2 1/1] riscv: dts: spacemit: Add 'linux,pci-domain' to PCIe nodes for K1
Date: Mon, 9 Mar 2026 18:51:56 +0800	[thread overview]
Message-ID: <20260309105156-GKD302167@kernel.org> (raw)
In-Reply-To: <20260309030000.1157040-1-amadeus@jmu.edu.cn>

Hi Chukun,

On 11:00 Mon 09 Mar     , Chukun Pan wrote:
> The SpacemiT K1 SoC has 3 PCIe EP controller nodes. Add the
> 'linux,pci-domain' property to assign a PCI domain number to
> each of the controllers instead of assigning it randomly.
> 
> This creates a stable sysfs path, allowing userspace scripts
> to reliably target specific PCIe devices (such as PCIe NICs).
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Looks good to me

Reviewed-by: Yixun Lan <dlan@kernel.org>

> ---
> Changes in v2:
> - Improve the commit messages
> ---
>  arch/riscv/boot/dts/spacemit/k1.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/spacemit/k1.dtsi
> index 529ec68e9c23..d2015201f8e5 100644
> --- a/arch/riscv/boot/dts/spacemit/k1.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi
> @@ -1033,6 +1033,7 @@ pcie-bus {
>  			#size-cells = <2>;
>  			dma-ranges = <0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>,
>  				     <0x0 0xb8000000 0x1 0x38000000 0x3 0x48000000>;
> +
>  			pcie0: pcie@ca000000 {
>  				device_type = "pci";
>  				compatible = "spacemit,k1-pcie";
> @@ -1044,6 +1045,7 @@ pcie0: pcie@ca000000 {
>  					    "atu",
>  					    "config",
>  					    "link";
> +				linux,pci-domain = <0>;
>  				#address-cells = <3>;
>  				#size-cells = <2>;
>  				ranges = <0x01000000 0x0 0x00000000 0x0 0x8f002000 0x0 0x00100000>,
> @@ -1087,6 +1089,7 @@ pcie1: pcie@ca400000 {
>  					    "atu",
>  					    "config",
>  					    "link";
> +				linux,pci-domain = <1>;
>  				#address-cells = <3>;
>  				#size-cells = <2>;
>  				ranges = <0x01000000 0x0 0x00000000 0x0 0x9f002000 0x0 0x00100000>,
> @@ -1130,6 +1133,7 @@ pcie2: pcie@ca800000 {
>  					    "atu",
>  					    "config",
>  					    "link";
> +				linux,pci-domain = <2>;
>  				#address-cells = <3>;
>  				#size-cells = <2>;
>  				ranges = <0x01000000 0x0 0x00000000 0x0 0xb7002000 0x0 0x00100000>,
> -- 
> 2.25.1
> 

-- 
Yixun Lan (dlan)

  reply	other threads:[~2026-03-09 10:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09  3:00 [PATCH v2 1/1] riscv: dts: spacemit: Add 'linux,pci-domain' to PCIe nodes for K1 Chukun Pan
2026-03-09  3:00 ` Chukun Pan
2026-03-09 10:51 ` Yixun Lan [this message]
2026-03-09 10:51   ` Yixun Lan
2026-03-10  9:41 ` Yixun Lan
2026-03-10  9:41   ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309105156-GKD302167@kernel.org \
    --to=dlan@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=amadeus@jmu.edu.cn \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.