All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Albershteyn <aalbersh@kernel.org>
To: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
	linux-fsdevel@vger.kernel.org, ebiggers@kernel.org
Cc: Andrey Albershteyn <aalbersh@kernel.org>,
	hch@lst.de, linux-ext4@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-btrfs@vger.kernel.org, djwong@kernel.org
Subject: [PATCH v4 03/25] fsverity: generate and store zero-block hash
Date: Mon,  9 Mar 2026 20:23:18 +0100	[thread overview]
Message-ID: <20260309192355.176980-4-aalbersh@kernel.org> (raw)
In-Reply-To: <20260309192355.176980-1-aalbersh@kernel.org>

Compute the hash of one filesystem block's worth of zeros. A filesystem
implementation can decide to elide merkle tree blocks containing only
this hash and synthesize the contents at read time.

Let's pretend that there's a file containing six data blocks and whose
merkle tree looks roughly like this:

root
 +--leaf0
 |   +--data0
 |   +--data1
 |   `--data2
 `--leaf1
     +--data3
     +--data4
     `--data5

If data[0-2] are sparse holes, then leaf0 will contain a repeating
sequence of @zero_digest.  Therefore, leaf0 need not be written to disk
because its contents can be synthesized.

A subsequent xfs patch will use this to reduce the size of the merkle
tree when dealing with sparse gold master disk images and the like.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
 fs/verity/fsverity_private.h | 3 +++
 fs/verity/open.c             | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/fs/verity/fsverity_private.h b/fs/verity/fsverity_private.h
index 6e6854c19078..35636c1e2c41 100644
--- a/fs/verity/fsverity_private.h
+++ b/fs/verity/fsverity_private.h
@@ -53,6 +53,9 @@ struct merkle_tree_params {
 	u64 tree_size;			/* Merkle tree size in bytes */
 	unsigned long tree_pages;	/* Merkle tree size in pages */
 
+	/* the hash of a merkle block-sized buffer of zeroes */
+	u8 zero_digest[FS_VERITY_MAX_DIGEST_SIZE];
+
 	/*
 	 * Starting block index for each tree level, ordered from leaf level (0)
 	 * to root level ('num_levels - 1')
diff --git a/fs/verity/open.c b/fs/verity/open.c
index 0483db672526..94407a37aa08 100644
--- a/fs/verity/open.c
+++ b/fs/verity/open.c
@@ -153,6 +153,9 @@ int fsverity_init_merkle_tree_params(struct merkle_tree_params *params,
 		goto out_err;
 	}
 
+	fsverity_hash_block(params, page_address(ZERO_PAGE(0)),
+			    params->zero_digest);
+
 	params->tree_size = offset << log_blocksize;
 	params->tree_pages = PAGE_ALIGN(params->tree_size) >> PAGE_SHIFT;
 	return 0;
-- 
2.51.2


WARNING: multiple messages have this Message-ID (diff)
From: Andrey Albershteyn via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev,
	linux-fsdevel@vger.kernel.org, ebiggers@kernel.org
Cc: Andrey Albershteyn <aalbersh@kernel.org>,
	djwong@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	linux-ext4@vger.kernel.org, hch@lst.de,
	linux-btrfs@vger.kernel.org
Subject: [f2fs-dev] [PATCH v4 03/25] fsverity: generate and store zero-block hash
Date: Mon,  9 Mar 2026 20:23:18 +0100	[thread overview]
Message-ID: <20260309192355.176980-4-aalbersh@kernel.org> (raw)
In-Reply-To: <20260309192355.176980-1-aalbersh@kernel.org>

Compute the hash of one filesystem block's worth of zeros. A filesystem
implementation can decide to elide merkle tree blocks containing only
this hash and synthesize the contents at read time.

Let's pretend that there's a file containing six data blocks and whose
merkle tree looks roughly like this:

root
 +--leaf0
 |   +--data0
 |   +--data1
 |   `--data2
 `--leaf1
     +--data3
     +--data4
     `--data5

If data[0-2] are sparse holes, then leaf0 will contain a repeating
sequence of @zero_digest.  Therefore, leaf0 need not be written to disk
because its contents can be synthesized.

A subsequent xfs patch will use this to reduce the size of the merkle
tree when dealing with sparse gold master disk images and the like.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
---
 fs/verity/fsverity_private.h | 3 +++
 fs/verity/open.c             | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/fs/verity/fsverity_private.h b/fs/verity/fsverity_private.h
index 6e6854c19078..35636c1e2c41 100644
--- a/fs/verity/fsverity_private.h
+++ b/fs/verity/fsverity_private.h
@@ -53,6 +53,9 @@ struct merkle_tree_params {
 	u64 tree_size;			/* Merkle tree size in bytes */
 	unsigned long tree_pages;	/* Merkle tree size in pages */
 
+	/* the hash of a merkle block-sized buffer of zeroes */
+	u8 zero_digest[FS_VERITY_MAX_DIGEST_SIZE];
+
 	/*
 	 * Starting block index for each tree level, ordered from leaf level (0)
 	 * to root level ('num_levels - 1')
diff --git a/fs/verity/open.c b/fs/verity/open.c
index 0483db672526..94407a37aa08 100644
--- a/fs/verity/open.c
+++ b/fs/verity/open.c
@@ -153,6 +153,9 @@ int fsverity_init_merkle_tree_params(struct merkle_tree_params *params,
 		goto out_err;
 	}
 
+	fsverity_hash_block(params, page_address(ZERO_PAGE(0)),
+			    params->zero_digest);
+
 	params->tree_size = offset << log_blocksize;
 	params->tree_pages = PAGE_ALIGN(params->tree_size) >> PAGE_SHIFT;
 	return 0;
-- 
2.51.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2026-03-09 19:24 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 19:23 [PATCH v4 00/25] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-03-09 19:23 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 01/25] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  0:46   ` Darrick J. Wong
2026-03-10  0:46     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-11 11:47     ` Andrey Albershteyn
2026-03-11 11:47       ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 02/25] fsverity: expose ensure_fsverity_info() Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` Andrey Albershteyn [this message]
2026-03-09 19:23   ` [f2fs-dev] [PATCH v4 03/25] fsverity: generate and store zero-block hash Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 04/25] fsverity: introduce fsverity_folio_zero_hash() Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  0:47   ` Darrick J. Wong
2026-03-10  0:47     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 05/25] fsverity: pass digest size and hash of the empty block to ->write Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  0:49   ` Darrick J. Wong
2026-03-10  0:49     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 06/25] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  0:49   ` Darrick J. Wong
2026-03-10  0:49     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 07/25] iomap: introduce IOMAP_F_FSVERITY and teach writeback to handle fsverity Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  0:54   ` Darrick J. Wong
2026-03-10  0:54     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-10  8:44   ` Christoph Hellwig
2026-03-10  8:44     ` [f2fs-dev] " Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 08/25] iomap: obtain fsverity info for read path Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  0:57   ` Darrick J. Wong
2026-03-10  0:57     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-10  8:44   ` Christoph Hellwig
2026-03-10  8:44     ` [f2fs-dev] " Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 09/25] iomap: issue readahead for fsverity merkle tree Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  0:57   ` Darrick J. Wong
2026-03-10  0:57     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-10  8:45   ` Christoph Hellwig
2026-03-10  8:45     ` [f2fs-dev] " Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 10/25] iomap: teach iomap to handle fsverity holes and verify data holes Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  1:05   ` Darrick J. Wong
2026-03-10  1:05     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-10 14:42     ` Andrey Albershteyn
2026-03-10 14:42       ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  9:14   ` Christoph Hellwig
2026-03-10  9:14     ` [f2fs-dev] " Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 11/25] iomap: introduce iomap_fsverity_write() for writing fsverity metadata Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  1:02   ` Darrick J. Wong
2026-03-10  1:02     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 12/25] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  1:05   ` Darrick J. Wong
2026-03-10  1:05     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 13/25] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 14/25] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 15/25] xfs: disable direct read path for fs-verity files Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 16/25] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  1:17   ` Darrick J. Wong
2026-03-10  1:17     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 17/25] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  1:21   ` Darrick J. Wong
2026-03-10  1:21     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-11 11:40     ` Andrey Albershteyn
2026-03-11 11:40       ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  9:11   ` Christoph Hellwig
2026-03-10  9:11     ` [f2fs-dev] " Christoph Hellwig
2026-03-09 19:23 ` [PATCH v4 18/25] xfs: add fs-verity support Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  1:26   ` Darrick J. Wong
2026-03-10  1:26     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-10 15:26     ` Andrey Albershteyn
2026-03-10 15:26       ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 19/25] xfs: remove unwritten extents after preallocations in fsverity metadata Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-10  1:29   ` Darrick J. Wong
2026-03-10  1:29     ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-12 13:50     ` Andrey Albershteyn
2026-03-12 13:50       ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-12 14:52       ` Darrick J. Wong
2026-03-12 14:52         ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-13 11:17         ` Andrey Albershteyn
2026-03-13 11:17           ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-13 14:55           ` Darrick J. Wong
2026-03-13 14:55             ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 20/25] xfs: add fs-verity ioctls Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 21/25] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 22/25] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 23/25] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 24/25] xfs: add fsverity traces Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-03-09 19:23 ` [PATCH v4 25/25] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
2026-03-09 19:23   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309192355.176980-4-aalbersh@kernel.org \
    --to=aalbersh@kernel.org \
    --cc=djwong@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=fsverity@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.