All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: konradybcio@kernel.org, andersson@kernel.org
Cc: linux-kernel@vger.kernel.org, Alex Elder <elder@kernel.org>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jeff Johnson <jjohnson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Srinivas Kandagatla <srini@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Kees Cook <kees@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
	Wesley Cheng <quic_wcheng@quicinc.com>,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org, ath11k@lists.infradead.org,
	ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org
Subject: [PATCH v1 2/8] net: ipa: Use the unified QMI service ID instead of defining it locally
Date: Tue, 10 Mar 2026 00:03:31 +0100	[thread overview]
Message-ID: <20260309230346.3584252-3-daniel.lezcano@oss.qualcomm.com> (raw)
In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com>

Instead of defining a local macro with a custom name for the QMI
service identifier, use the one provided in qmi.h and remove the
locally defined macro.

Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
---
 drivers/net/ipa/ipa_qmi.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ipa/ipa_qmi.c b/drivers/net/ipa/ipa_qmi.c
index d771f3a71f94..37936ad132a2 100644
--- a/drivers/net/ipa/ipa_qmi.c
+++ b/drivers/net/ipa/ipa_qmi.c
@@ -66,11 +66,9 @@
  *   determination of when things are "ready"
  */
 
-#define IPA_HOST_SERVICE_SVC_ID		0x31
 #define IPA_HOST_SVC_VERS		1
 #define IPA_HOST_SERVICE_INS_ID		1
 
-#define IPA_MODEM_SERVICE_SVC_ID	0x31
 #define IPA_MODEM_SERVICE_INS_ID	2
 #define IPA_MODEM_SVC_VERS		1
 
@@ -484,7 +482,7 @@ int ipa_qmi_setup(struct ipa *ipa)
 	if (ret)
 		return ret;
 
-	ret = qmi_add_server(&ipa_qmi->server_handle, IPA_HOST_SERVICE_SVC_ID,
+	ret = qmi_add_server(&ipa_qmi->server_handle, QMI_SERVICE_ID_IPA,
 			     IPA_HOST_SVC_VERS, IPA_HOST_SERVICE_INS_ID);
 	if (ret)
 		goto err_server_handle_release;
@@ -501,7 +499,7 @@ int ipa_qmi_setup(struct ipa *ipa)
 	/* We need this ready before the service lookup is added */
 	INIT_WORK(&ipa_qmi->init_driver_work, ipa_client_init_driver_work);
 
-	ret = qmi_add_lookup(&ipa_qmi->client_handle, IPA_MODEM_SERVICE_SVC_ID,
+	ret = qmi_add_lookup(&ipa_qmi->client_handle, QMI_SERVICE_ID_IPA,
 			     IPA_MODEM_SVC_VERS, IPA_MODEM_SERVICE_INS_ID);
 	if (ret)
 		goto err_client_handle_release;
-- 
2.43.0



  parent reply	other threads:[~2026-03-09 23:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
2026-03-09 23:03 ` [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI Daniel Lezcano
2026-03-10  0:04   ` Dmitry Baryshkov
2026-03-10  9:57   ` Konrad Dybcio
2026-03-10 10:06     ` Daniel Lezcano
2026-03-10 13:23     ` Daniel Lezcano
2026-03-09 23:03 ` Daniel Lezcano [this message]
2026-03-10  0:04   ` [PATCH v1 2/8] net: ipa: Use the unified QMI service ID instead of defining it locally Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 3/8] net: drivers: wireless: ath: " Daniel Lezcano
2026-03-10  0:05   ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 4/8] remoteproc: qcom: " Daniel Lezcano
2026-03-10  0:05   ` Dmitry Baryshkov
2026-03-16  2:09   ` (subset) " Bjorn Andersson
2026-03-19  9:02     ` Daniel Lezcano
2026-03-09 23:03 ` [PATCH v1 5/8] slimbus: qcom-ngd-ctrl: " Daniel Lezcano
2026-03-10  0:06   ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 6/8] soc: qcom: pdr: " Daniel Lezcano
2026-03-10  0:06   ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 7/8] ALSA: usb-audio: qcom: " Daniel Lezcano
2026-03-10  0:07   ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 8/8] samples: qmi: " Daniel Lezcano
2026-03-10  0:07   ` Dmitry Baryshkov
2026-03-09 23:50 ` [PATCH v1 0/8] Group QMI service IDs into the QMI header Jeff Johnson
2026-03-10  0:09   ` Daniel Lezcano
2026-03-16  2:02     ` Bjorn Andersson
2026-03-10  0:11 ` Dmitry Baryshkov
2026-03-16  2:02 ` (subset) " Bjorn Andersson
2026-03-18 13:50 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309230346.3584252-3-daniel.lezcano@oss.qualcomm.com \
    --to=daniel.lezcano@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=ath10k@lists.infradead.org \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=elder@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jjohnson@kernel.org \
    --cc=kees@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=perex@perex.cz \
    --cc=quic_wcheng@quicinc.com \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.