From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
konradybcio@kernel.org, andersson@kernel.org
Cc: linux-kernel@vger.kernel.org, Alex Elder <elder@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jeff Johnson <jjohnson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Srinivas Kandagatla <srini@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kees Cook <kees@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
Wesley Cheng <quic_wcheng@quicinc.com>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org, ath11k@lists.infradead.org,
ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v1 0/8] Group QMI service IDs into the QMI header
Date: Tue, 10 Mar 2026 01:09:08 +0100 [thread overview]
Message-ID: <3283cbae-4100-484c-9b00-1d7111c62456@oss.qualcomm.com> (raw)
In-Reply-To: <9cc7638f-1232-4cb7-b4d7-cdac66a2f4ba@oss.qualcomm.com>
On 3/10/26 00:50, Jeff Johnson wrote:
> On 3/9/2026 4:03 PM, Daniel Lezcano wrote:
>> The different subsystems implementing the QMI service protocol are
>> using their own definition of the service id. It is not a problem but
>> it results on having those duplicated with different names but the
>> same value and without consistency in their name.
>>
>> It makes more sense to unify their names and move the definitions in
[ ... ]
> prefix for wireless drivers is simply wifi: <driver>:
> so s/net: drivers: wireless:/wifi:/
Noted, thanks
>> remoteproc: qcom: Use the unified QMI service ID instead of defining
>> it locally
>> slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of
>> defining it locally
>> soc: qcom: pdr: Use the unified QMI service ID instead of defining it
>> locally
>> ALSA: usb-audio: qcom: Use the unified QMI service ID instead of
>> defining it locally
>> samples: qmi: Use the unified QMI service ID instead of defining it
>> locally
>>
>> drivers/net/ipa/ipa_qmi.c | 6 ++----
>> drivers/net/wireless/ath/ath10k/qmi.c | 2 +-
>> drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 -
>> drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
>> drivers/net/wireless/ath/ath11k/qmi.h | 1 -
>> drivers/net/wireless/ath/ath12k/qmi.c | 2 +-
>> drivers/net/wireless/ath/ath12k/qmi.h | 1 -
>> drivers/remoteproc/qcom_sysmon.c | 2 +-
>> drivers/slimbus/qcom-ngd-ctrl.c | 5 ++---
>> drivers/soc/qcom/pdr_interface.c | 4 ++--
>> drivers/soc/qcom/pdr_internal.h | 3 ---
>> drivers/soc/qcom/qcom_pd_mapper.c | 2 +-
>> include/linux/soc/qcom/qmi.h | 12 ++++++++++++
>> samples/qmi/qmi_sample_client.c | 2 +-
>> sound/usb/qcom/qc_audio_offload.c | 2 +-
>> sound/usb/qcom/usb_audio_qmi_v01.h | 1 -
>
> You are touching a lot of subsystems with a single series.
> How do you plan on having these land?
> Do you have a maintainer who will take all of these through their tree?
Yes I thought Bjorn or Konrad would take them with the acked-by from the
different subsystems
next prev parent reply other threads:[~2026-03-10 0:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 23:03 [PATCH v1 0/8] Group QMI service IDs into the QMI header Daniel Lezcano
2026-03-09 23:03 ` [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI Daniel Lezcano
2026-03-10 0:04 ` Dmitry Baryshkov
2026-03-10 9:57 ` Konrad Dybcio
2026-03-10 10:06 ` Daniel Lezcano
2026-03-10 13:23 ` Daniel Lezcano
2026-03-09 23:03 ` [PATCH v1 2/8] net: ipa: Use the unified QMI service ID instead of defining it locally Daniel Lezcano
2026-03-10 0:04 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 3/8] net: drivers: wireless: ath: " Daniel Lezcano
2026-03-10 0:05 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 4/8] remoteproc: qcom: " Daniel Lezcano
2026-03-10 0:05 ` Dmitry Baryshkov
2026-03-16 2:09 ` (subset) " Bjorn Andersson
2026-03-19 9:02 ` Daniel Lezcano
2026-03-09 23:03 ` [PATCH v1 5/8] slimbus: qcom-ngd-ctrl: " Daniel Lezcano
2026-03-10 0:06 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 6/8] soc: qcom: pdr: " Daniel Lezcano
2026-03-10 0:06 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 7/8] ALSA: usb-audio: qcom: " Daniel Lezcano
2026-03-10 0:07 ` Dmitry Baryshkov
2026-03-09 23:03 ` [PATCH v1 8/8] samples: qmi: " Daniel Lezcano
2026-03-10 0:07 ` Dmitry Baryshkov
2026-03-09 23:50 ` [PATCH v1 0/8] Group QMI service IDs into the QMI header Jeff Johnson
2026-03-10 0:09 ` Daniel Lezcano [this message]
2026-03-16 2:02 ` Bjorn Andersson
2026-03-10 0:11 ` Dmitry Baryshkov
2026-03-16 2:02 ` (subset) " Bjorn Andersson
2026-03-18 13:50 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3283cbae-4100-484c-9b00-1d7111c62456@oss.qualcomm.com \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=perex@perex.cz \
--cc=quic_wcheng@quicinc.com \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.