All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] configs: j722s_evm_a53_defconfig: Allow configurability of MMCSD speeds
@ 2026-02-20  7:25 Moteen Shah
  2026-02-20  8:35 ` Kumar, Udit
  0 siblings, 1 reply; 6+ messages in thread
From: Moteen Shah @ 2026-02-20  7:25 UTC (permalink / raw)
  To: u-boot
  Cc: trini, m-chawdhry, n-francis, vigneshr, u-kumar1, gehariprasath,
	m-shah

Add config to allow UHS support, in turn allowing to select
UHS speed modes for the SD card

Signed-off-by: Moteen Shah <m-shah@ti.com>
---
Test logs: https://gist.github.com/Jamm02/e8b8b8c95cb62a7145d73f7ef50b2d8e

 configs/j722s_evm_a53_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/j722s_evm_a53_defconfig b/configs/j722s_evm_a53_defconfig
index e84670c75ed..24ee293c803 100644
--- a/configs/j722s_evm_a53_defconfig
+++ b/configs/j722s_evm_a53_defconfig
@@ -107,6 +107,7 @@ CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_ADMA=y
 CONFIG_SPL_MMC_SDHCI_ADMA=y
 CONFIG_MMC_SDHCI_AM654=y
+CONFIG_MMC_UHS_SUPPORT=y
 CONFIG_MTD=y
 CONFIG_DM_MTD=y
 CONFIG_MTD_SPI_NAND=y
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] configs: j722s_evm_a53_defconfig: Allow configurability of MMCSD speeds
  2026-02-20  7:25 [PATCH] configs: j722s_evm_a53_defconfig: Allow configurability of MMCSD speeds Moteen Shah
@ 2026-02-20  8:35 ` Kumar, Udit
  2026-02-20  9:47   ` Moteen Shah
  0 siblings, 1 reply; 6+ messages in thread
From: Kumar, Udit @ 2026-02-20  8:35 UTC (permalink / raw)
  To: Moteen Shah, u-boot; +Cc: trini, m-chawdhry, n-francis, vigneshr, gehariprasath


On 2/20/2026 12:55 PM, Moteen Shah wrote:
> Add config to allow UHS support, in turn allowing to select
> UHS speed modes for the SD card
>
> Signed-off-by: Moteen Shah <m-shah@ti.com>
> ---
> Test logs: https://gist.github.com/Jamm02/e8b8b8c95cb62a7145d73f7ef50b2d8e
>
>   configs/j722s_evm_a53_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/configs/j722s_evm_a53_defconfig b/configs/j722s_evm_a53_defconfig
> index e84670c75ed..24ee293c803 100644
> --- a/configs/j722s_evm_a53_defconfig
> +++ b/configs/j722s_evm_a53_defconfig
> @@ -107,6 +107,7 @@ CONFIG_MMC_SDHCI=y
>   CONFIG_MMC_SDHCI_ADMA=y
>   CONFIG_SPL_MMC_SDHCI_ADMA=y
>   CONFIG_MMC_SDHCI_AM654=y
> +CONFIG_MMC_UHS_SUPPORT=y


you may need at A72/SPL stage as well,

and do you think , R5/SPL will need this too ?


>   CONFIG_MTD=y
>   CONFIG_DM_MTD=y
>   CONFIG_MTD_SPI_NAND=y

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] configs: j722s_evm_a53_defconfig: Allow configurability of MMCSD speeds
  2026-02-20  8:35 ` Kumar, Udit
@ 2026-02-20  9:47   ` Moteen Shah
  2026-03-09 23:15     ` Tom Rini
  0 siblings, 1 reply; 6+ messages in thread
From: Moteen Shah @ 2026-02-20  9:47 UTC (permalink / raw)
  To: Kumar, Udit, u-boot; +Cc: trini, m-chawdhry, n-francis, vigneshr, gehariprasath


On 20/02/26 14:05, Kumar, Udit wrote:
>
> On 2/20/2026 12:55 PM, Moteen Shah wrote:
>> Add config to allow UHS support, in turn allowing to select
>> UHS speed modes for the SD card
>>
>> Signed-off-by: Moteen Shah <m-shah@ti.com>
>> ---
>> Test logs: 
>> https://gist.github.com/Jamm02/e8b8b8c95cb62a7145d73f7ef50b2d8e
>>
>>   configs/j722s_evm_a53_defconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/configs/j722s_evm_a53_defconfig 
>> b/configs/j722s_evm_a53_defconfig
>> index e84670c75ed..24ee293c803 100644
>> --- a/configs/j722s_evm_a53_defconfig
>> +++ b/configs/j722s_evm_a53_defconfig
>> @@ -107,6 +107,7 @@ CONFIG_MMC_SDHCI=y
>>   CONFIG_MMC_SDHCI_ADMA=y
>>   CONFIG_SPL_MMC_SDHCI_ADMA=y
>>   CONFIG_MMC_SDHCI_AM654=y
>> +CONFIG_MMC_UHS_SUPPORT=y
>
>
> you may need at A72/SPL stage as well, 

Other J7 boards already have this config enabled in the a72 stage.
>
> and do you think , R5/SPL will need this too ?

Any of the K3 devices does not enables this in R5 SPL, though we do have 
HS400 enabled in the R5 stage.
Adding the config should result in a little performance gain I think.

Regards,
Moteen

>
>
>>   CONFIG_MTD=y
>>   CONFIG_DM_MTD=y
>>   CONFIG_MTD_SPI_NAND=y

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] configs: j722s_evm_a53_defconfig: Allow configurability of MMCSD speeds
  2026-02-20  9:47   ` Moteen Shah
@ 2026-03-09 23:15     ` Tom Rini
  2026-03-12  9:16       ` Moteen Shah
  0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2026-03-09 23:15 UTC (permalink / raw)
  To: Moteen Shah
  Cc: Kumar, Udit, u-boot, m-chawdhry, n-francis, vigneshr,
	gehariprasath

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

On Fri, Feb 20, 2026 at 03:17:37PM +0530, Moteen Shah wrote:
> 
> On 20/02/26 14:05, Kumar, Udit wrote:
> > 
> > On 2/20/2026 12:55 PM, Moteen Shah wrote:
> > > Add config to allow UHS support, in turn allowing to select
> > > UHS speed modes for the SD card
> > > 
> > > Signed-off-by: Moteen Shah <m-shah@ti.com>
> > > ---
> > > Test logs:
> > > https://gist.github.com/Jamm02/e8b8b8c95cb62a7145d73f7ef50b2d8e
> > > 
> > >   configs/j722s_evm_a53_defconfig | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/configs/j722s_evm_a53_defconfig
> > > b/configs/j722s_evm_a53_defconfig
> > > index e84670c75ed..24ee293c803 100644
> > > --- a/configs/j722s_evm_a53_defconfig
> > > +++ b/configs/j722s_evm_a53_defconfig
> > > @@ -107,6 +107,7 @@ CONFIG_MMC_SDHCI=y
> > >   CONFIG_MMC_SDHCI_ADMA=y
> > >   CONFIG_SPL_MMC_SDHCI_ADMA=y
> > >   CONFIG_MMC_SDHCI_AM654=y
> > > +CONFIG_MMC_UHS_SUPPORT=y
> > 
> > 
> > you may need at A72/SPL stage as well,
> 
> Other J7 boards already have this config enabled in the a72 stage.
> > 
> > and do you think , R5/SPL will need this too ?
> 
> Any of the K3 devices does not enables this in R5 SPL, though we do have
> HS400 enabled in the R5 stage.
> Adding the config should result in a little performance gain I think.

Is this a function of board design, or a SoC-level feature?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] configs: j722s_evm_a53_defconfig: Allow configurability of MMCSD speeds
  2026-03-09 23:15     ` Tom Rini
@ 2026-03-12  9:16       ` Moteen Shah
  2026-03-12 15:50         ` Tom Rini
  0 siblings, 1 reply; 6+ messages in thread
From: Moteen Shah @ 2026-03-12  9:16 UTC (permalink / raw)
  To: Tom Rini
  Cc: Kumar, Udit, u-boot, m-chawdhry, n-francis, vigneshr,
	gehariprasath

Hey Tom and Udit,

On 10/03/26 04:45, Tom Rini wrote:
> On Fri, Feb 20, 2026 at 03:17:37PM +0530, Moteen Shah wrote:
>> On 20/02/26 14:05, Kumar, Udit wrote:
>>> On 2/20/2026 12:55 PM, Moteen Shah wrote:
>>>> Add config to allow UHS support, in turn allowing to select
>>>> UHS speed modes for the SD card
>>>>
>>>> Signed-off-by: Moteen Shah <m-shah@ti.com>
>>>> ---
>>>> Test logs:
>>>> https://gist.github.com/Jamm02/e8b8b8c95cb62a7145d73f7ef50b2d8e
>>>>
>>>>    configs/j722s_evm_a53_defconfig | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/configs/j722s_evm_a53_defconfig
>>>> b/configs/j722s_evm_a53_defconfig
>>>> index e84670c75ed..24ee293c803 100644
>>>> --- a/configs/j722s_evm_a53_defconfig
>>>> +++ b/configs/j722s_evm_a53_defconfig
>>>> @@ -107,6 +107,7 @@ CONFIG_MMC_SDHCI=y
>>>>    CONFIG_MMC_SDHCI_ADMA=y
>>>>    CONFIG_SPL_MMC_SDHCI_ADMA=y
>>>>    CONFIG_MMC_SDHCI_AM654=y
>>>> +CONFIG_MMC_UHS_SUPPORT=y
>>>
>>> you may need at A72/SPL stage as well,
>> Other J7 boards already have this config enabled in the a72 stage.
>>> and do you think , R5/SPL will need this too ?
>> Any of the K3 devices does not enables this in R5 SPL, though we do have
>> HS400 enabled in the R5 stage.
>> Adding the config should result in a little performance gain I think.
> Is this a function of board design, or a SoC-level feature?

SOC level feature, thought it has dependency on the board to provide the 
right voltage to the card.

@udit, I did some profiling with UHS enabled at the R5 stage on 
J784s4-EVM but I see no performance gain there, likely due to the fact 
that the R5 stage takes up very minimal percentage of the boot time. 
This patch can go in as it is.

Regards,
Moteen

>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] configs: j722s_evm_a53_defconfig: Allow configurability of MMCSD speeds
  2026-03-12  9:16       ` Moteen Shah
@ 2026-03-12 15:50         ` Tom Rini
  0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2026-03-12 15:50 UTC (permalink / raw)
  To: Moteen Shah
  Cc: Kumar, Udit, u-boot, m-chawdhry, n-francis, vigneshr,
	gehariprasath

[-- Attachment #1: Type: text/plain, Size: 2129 bytes --]

On Thu, Mar 12, 2026 at 02:46:27PM +0530, Moteen Shah wrote:
> Hey Tom and Udit,
> 
> On 10/03/26 04:45, Tom Rini wrote:
> > On Fri, Feb 20, 2026 at 03:17:37PM +0530, Moteen Shah wrote:
> > > On 20/02/26 14:05, Kumar, Udit wrote:
> > > > On 2/20/2026 12:55 PM, Moteen Shah wrote:
> > > > > Add config to allow UHS support, in turn allowing to select
> > > > > UHS speed modes for the SD card
> > > > > 
> > > > > Signed-off-by: Moteen Shah <m-shah@ti.com>
> > > > > ---
> > > > > Test logs:
> > > > > https://gist.github.com/Jamm02/e8b8b8c95cb62a7145d73f7ef50b2d8e
> > > > > 
> > > > >    configs/j722s_evm_a53_defconfig | 1 +
> > > > >    1 file changed, 1 insertion(+)
> > > > > 
> > > > > diff --git a/configs/j722s_evm_a53_defconfig
> > > > > b/configs/j722s_evm_a53_defconfig
> > > > > index e84670c75ed..24ee293c803 100644
> > > > > --- a/configs/j722s_evm_a53_defconfig
> > > > > +++ b/configs/j722s_evm_a53_defconfig
> > > > > @@ -107,6 +107,7 @@ CONFIG_MMC_SDHCI=y
> > > > >    CONFIG_MMC_SDHCI_ADMA=y
> > > > >    CONFIG_SPL_MMC_SDHCI_ADMA=y
> > > > >    CONFIG_MMC_SDHCI_AM654=y
> > > > > +CONFIG_MMC_UHS_SUPPORT=y
> > > > 
> > > > you may need at A72/SPL stage as well,
> > > Other J7 boards already have this config enabled in the a72 stage.
> > > > and do you think , R5/SPL will need this too ?
> > > Any of the K3 devices does not enables this in R5 SPL, though we do have
> > > HS400 enabled in the R5 stage.
> > > Adding the config should result in a little performance gain I think.
> > Is this a function of board design, or a SoC-level feature?
> 
> SOC level feature, thought it has dependency on the board to provide the
> right voltage to the card.
> 
> @udit, I did some profiling with UHS enabled at the R5 stage on J784s4-EVM
> but I see no performance gain there, likely due to the fact that the R5
> stage takes up very minimal percentage of the boot time. This patch can go
> in as it is.

I think we should imply this under ARCH_K3 then, so that boards which do
not meet the design requirements can turn it off, as I am assuming most
do.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-03-12 15:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-20  7:25 [PATCH] configs: j722s_evm_a53_defconfig: Allow configurability of MMCSD speeds Moteen Shah
2026-02-20  8:35 ` Kumar, Udit
2026-02-20  9:47   ` Moteen Shah
2026-03-09 23:15     ` Tom Rini
2026-03-12  9:16       ` Moteen Shah
2026-03-12 15:50         ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.