* [linux-next:master /4750] drivers/gpu/drm/radeon/radeon_device.c:1592:22: error: implicit declaration of function 'drm_fb_helper_gem_is_fb'; did you mean 'drm_fb_helper_from_client'?
@ 2026-03-09 23:30 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-03-09 23:30 UTC (permalink / raw)
To: Alex Deucher; +Cc: oe-kbuild-all, Mark Brown
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 343f51842f4ed7143872f3aa116a214a5619a4b9
commit: 99ece3600fdb60fef87268c6c05c66e5d02dbeb4 [/4750] Merge branch 'drm-next' of https://gitlab.freedesktop.org/agd5f/linux.git
config: loongarch-randconfig-001-20260310 (https://download.01.org/0day-ci/archive/20260310/202603100745.tbDqpgNK-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260310/202603100745.tbDqpgNK-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603100745.tbDqpgNK-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/gpu/drm/radeon/radeon_device.c: In function 'radeon_suspend_kms':
>> drivers/gpu/drm/radeon/radeon_device.c:1592:22: error: implicit declaration of function 'drm_fb_helper_gem_is_fb'; did you mean 'drm_fb_helper_from_client'? [-Werror=implicit-function-declaration]
1592 | if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) {
| ^~~~~~~~~~~~~~~~~~~~~~~
| drm_fb_helper_from_client
cc1: some warnings being treated as errors
vim +1592 drivers/gpu/drm/radeon/radeon_device.c
771fe6b912fca5 Jerome Glisse 2009-06-05 1534
771fe6b912fca5 Jerome Glisse 2009-06-05 1535
771fe6b912fca5 Jerome Glisse 2009-06-05 1536 /*
771fe6b912fca5 Jerome Glisse 2009-06-05 1537 * Suspend & resume.
771fe6b912fca5 Jerome Glisse 2009-06-05 1538 */
f017853ee200d5 Lee Jones 2020-11-05 1539 /*
0c1951192a8855 Alex Deucher 2012-07-17 1540 * radeon_suspend_kms - initiate device suspend
0c1951192a8855 Alex Deucher 2012-07-17 1541 *
0c1951192a8855 Alex Deucher 2012-07-17 1542 * Puts the hw in the suspend state (all asics).
0c1951192a8855 Alex Deucher 2012-07-17 1543 * Returns 0 for success or an error on failure.
0c1951192a8855 Alex Deucher 2012-07-17 1544 * Called at driver suspend.
0c1951192a8855 Alex Deucher 2012-07-17 1545 */
274ad65c9d02bd Jérome Glisse 2016-03-18 1546 int radeon_suspend_kms(struct drm_device *dev, bool suspend,
88c79de8575c00 Thomas Zimmermann 2024-10-14 1547 bool notify_clients, bool freeze)
771fe6b912fca5 Jerome Glisse 2009-06-05 1548 {
875c186620e017 Darren Jenkins 2009-12-30 1549 struct radeon_device *rdev;
d86a41267b32e9 Thomas Zimmermann 2020-12-01 1550 struct pci_dev *pdev;
771fe6b912fca5 Jerome Glisse 2009-06-05 1551 struct drm_crtc *crtc;
d8dcaa1dc50f5a Alex Deucher 2010-06-02 1552 struct drm_connector *connector;
7465280c076d64 Alex Deucher 2011-08-25 1553 int i, r;
771fe6b912fca5 Jerome Glisse 2009-06-05 1554
875c186620e017 Darren Jenkins 2009-12-30 1555 if (dev == NULL || dev->dev_private == NULL) {
771fe6b912fca5 Jerome Glisse 2009-06-05 1556 return -ENODEV;
771fe6b912fca5 Jerome Glisse 2009-06-05 1557 }
7473e830c400b2 Dave Airlie 2012-09-13 1558
875c186620e017 Darren Jenkins 2009-12-30 1559 rdev = dev->dev_private;
d86a41267b32e9 Thomas Zimmermann 2020-12-01 1560 pdev = to_pci_dev(dev->dev);
875c186620e017 Darren Jenkins 2009-12-30 1561
f2aba352a954d9 Alex Deucher 2016-09-19 1562 if (dev->switch_power_state == DRM_SWITCH_POWER_OFF)
6a9ee8af344e3b Dave Airlie 2010-02-01 1563 return 0;
d8dcaa1dc50f5a Alex Deucher 2010-06-02 1564
86698c20f71d48 Seth Forshee 2012-01-31 1565 drm_kms_helper_poll_disable(dev);
86698c20f71d48 Seth Forshee 2012-01-31 1566
6adaed5bfe4f6f Simona Vetter 2015-09-23 1567 drm_modeset_lock_all(dev);
d8dcaa1dc50f5a Alex Deucher 2010-06-02 1568 /* turn off display hw */
d8dcaa1dc50f5a Alex Deucher 2010-06-02 1569 list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
d8dcaa1dc50f5a Alex Deucher 2010-06-02 1570 drm_helper_connector_dpms(connector, DRM_MODE_DPMS_OFF);
d8dcaa1dc50f5a Alex Deucher 2010-06-02 1571 }
6adaed5bfe4f6f Simona Vetter 2015-09-23 1572 drm_modeset_unlock_all(dev);
d8dcaa1dc50f5a Alex Deucher 2010-06-02 1573
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1574 /* unpin the front buffers and cursors */
771fe6b912fca5 Jerome Glisse 2009-06-05 1575 list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1576 struct radeon_crtc *radeon_crtc = to_radeon_crtc(crtc);
9a0f0c9d0c9de7 Daniel Stone 2018-03-30 1577 struct drm_framebuffer *fb = crtc->primary->fb;
771fe6b912fca5 Jerome Glisse 2009-06-05 1578
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1579 if (radeon_crtc->cursor_bo) {
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1580 struct radeon_bo *robj = gem_to_radeon_bo(radeon_crtc->cursor_bo);
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1581 r = radeon_bo_reserve(robj, false);
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1582 if (r == 0) {
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1583 radeon_bo_unpin(robj);
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1584 radeon_bo_unreserve(robj);
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1585 }
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1586 }
f3cbb17bcf676a Grigori Goronzy 2015-07-07 1587
9a0f0c9d0c9de7 Daniel Stone 2018-03-30 1588 if (fb == NULL || fb->obj[0] == NULL) {
771fe6b912fca5 Jerome Glisse 2009-06-05 1589 continue;
771fe6b912fca5 Jerome Glisse 2009-06-05 1590 }
386516744ba45d Dave Airlie 2010-03-30 1591 /* don't unpin kernel fb objects */
7ba5286aad4e67 Thomas Zimmermann 2026-03-04 @1592 if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) {
7ba5286aad4e67 Thomas Zimmermann 2026-03-04 1593 struct radeon_bo *robj = gem_to_radeon_bo(fb->obj[0]);
7ba5286aad4e67 Thomas Zimmermann 2026-03-04 1594
4c7886791264f0 Jerome Glisse 2009-11-20 1595 r = radeon_bo_reserve(robj, false);
386516744ba45d Dave Airlie 2010-03-30 1596 if (r == 0) {
4c7886791264f0 Jerome Glisse 2009-11-20 1597 radeon_bo_unpin(robj);
4c7886791264f0 Jerome Glisse 2009-11-20 1598 radeon_bo_unreserve(robj);
4c7886791264f0 Jerome Glisse 2009-11-20 1599 }
771fe6b912fca5 Jerome Glisse 2009-06-05 1600 }
771fe6b912fca5 Jerome Glisse 2009-06-05 1601 }
771fe6b912fca5 Jerome Glisse 2009-06-05 1602 /* evict vram memory */
4c7886791264f0 Jerome Glisse 2009-11-20 1603 radeon_bo_evict_vram(rdev);
8a47cc9ec1249e Christian König 2012-05-09 1604
771fe6b912fca5 Jerome Glisse 2009-06-05 1605 /* wait for gpu to finish processing current batch */
5f8f635edd8ad5 Jerome Glisse 2012-12-17 1606 for (i = 0; i < RADEON_NUM_RINGS; i++) {
37615527c5669f Christian König 2014-02-18 1607 r = radeon_fence_wait_empty(rdev, i);
5f8f635edd8ad5 Jerome Glisse 2012-12-17 1608 if (r) {
5f8f635edd8ad5 Jerome Glisse 2012-12-17 1609 /* delay GPU reset to resume */
eb98c709907c7a Christian König 2014-08-27 1610 radeon_fence_driver_force_completion(rdev, i);
d6c770d2050b26 Zhenneng Li 2022-08-11 1611 } else {
d6c770d2050b26 Zhenneng Li 2022-08-11 1612 /* finish executing delayed work */
d6c770d2050b26 Zhenneng Li 2022-08-11 1613 flush_delayed_work(&rdev->fence_drv[i].lockup_work);
5f8f635edd8ad5 Jerome Glisse 2012-12-17 1614 }
5f8f635edd8ad5 Jerome Glisse 2012-12-17 1615 }
771fe6b912fca5 Jerome Glisse 2009-06-05 1616
f657c2a7310ad5 Yang Zhao 2009-09-15 1617 radeon_save_bios_scratch_regs(rdev);
f657c2a7310ad5 Yang Zhao 2009-09-15 1618
3ce0a23d2d2531 Jerome Glisse 2009-09-08 1619 radeon_suspend(rdev);
d4877cf2293f54 Alex Deucher 2009-12-04 1620 radeon_hpd_fini(rdev);
ec9aaaff666682 Alex Deucher 2016-10-10 1621 /* evict remaining vram memory
ec9aaaff666682 Alex Deucher 2016-10-10 1622 * This second call to evict vram is to evict the gart page table
ec9aaaff666682 Alex Deucher 2016-10-10 1623 * using the CPU.
ec9aaaff666682 Alex Deucher 2016-10-10 1624 */
4c7886791264f0 Jerome Glisse 2009-11-20 1625 radeon_bo_evict_vram(rdev);
771fe6b912fca5 Jerome Glisse 2009-06-05 1626
10b06122afcc78 Jerome Glisse 2010-05-21 1627 radeon_agp_suspend(rdev);
10b06122afcc78 Jerome Glisse 2010-05-21 1628
d86a41267b32e9 Thomas Zimmermann 2020-12-01 1629 pci_save_state(pdev);
820608548737e3 Alex Deucher 2017-09-15 1630 if (freeze && rdev->family >= CHIP_CEDAR && !(rdev->flags & RADEON_IS_IGP)) {
274ad65c9d02bd Jérome Glisse 2016-03-18 1631 rdev->asic->asic_reset(rdev, true);
d86a41267b32e9 Thomas Zimmermann 2020-12-01 1632 pci_restore_state(pdev);
274ad65c9d02bd Jérome Glisse 2016-03-18 1633 } else if (suspend) {
771fe6b912fca5 Jerome Glisse 2009-06-05 1634 /* Shut down the device */
d86a41267b32e9 Thomas Zimmermann 2020-12-01 1635 pci_disable_device(pdev);
d86a41267b32e9 Thomas Zimmermann 2020-12-01 1636 pci_set_power_state(pdev, PCI_D3hot);
771fe6b912fca5 Jerome Glisse 2009-06-05 1637 }
10ebc0bc09344a Dave Airlie 2012-09-17 1638
612ec7c69d04cb Thomas Zimmermann 2025-07-15 1639 if (notify_clients)
7910d69376cde3 Thomas Zimmermann 2025-10-01 1640 drm_client_dev_suspend(dev);
612ec7c69d04cb Thomas Zimmermann 2025-07-15 1641
771fe6b912fca5 Jerome Glisse 2009-06-05 1642 return 0;
771fe6b912fca5 Jerome Glisse 2009-06-05 1643 }
771fe6b912fca5 Jerome Glisse 2009-06-05 1644
:::::: The code at line 1592 was first introduced by commit
:::::: 7ba5286aad4e670b64053d64c04dfdf575594692 drm/radeon: Test for fbdev GEM object with generic helper
:::::: TO: Thomas Zimmermann <tzimmermann@suse.de>
:::::: CC: Alex Deucher <alexander.deucher@amd.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-03-09 23:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-09 23:30 [linux-next:master /4750] drivers/gpu/drm/radeon/radeon_device.c:1592:22: error: implicit declaration of function 'drm_fb_helper_gem_is_fb'; did you mean 'drm_fb_helper_from_client'? kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.