[PATCH 5/8] tests/qtest/migration: Force exit-on-error=false when appropriate

[Fabiano Rosas <farosas@suse.de>]

Some tests can cause QEMU to exit(1) too early while the incoming
coroutine has not yielded for a first time yet. This trips ASAN
because resources related to dispatching the incoming process will
still be allocated in the io/channel.c layer without a
straight-forward way for the migration code to clean them up.

Since this is an issue only affecting testing and leak detection,
let's make sure tests only use MIG_TEST_FAIL_DEST_QUIT_ERR when
strictly necessary.

To make this process easier, force exit-on-error=false for precopy
whenever the expected test result is MIG_TEST_FAIL. The distinction
between the two return codes is exactly that, the latter should never
cause exit(1).

The affected tests for now are the TLS tests "no_hostname" and
"mismatch_host".

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 tests/qtest/migration/framework.c | 5 ++++-
 tests/qtest/migration/tls-tests.c | 6 ++++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c
index 4cc63bba7b..cfb8409d33 100644
--- a/tests/qtest/migration/framework.c
+++ b/tests/qtest/migration/framework.c
@@ -854,7 +854,10 @@ int test_precopy_common(MigrateCommon *args)
             in_channels = qobject_from_json(args->connect_channels,
                                             &error_abort);
         }
-        migrate_incoming_qmp(to, args->listen_uri, in_channels, "{}");
+
+        migrate_incoming_qmp(to, args->listen_uri, in_channels,
+                             args->result == MIG_TEST_FAIL ?
+                             "{ 'exit-on-error': false }" : "{}");
     }
 
     /* Wait for the first serial output from the source */
diff --git a/tests/qtest/migration/tls-tests.c b/tests/qtest/migration/tls-tests.c
index f636802642..6274906ad9 100644
--- a/tests/qtest/migration/tls-tests.c
+++ b/tests/qtest/migration/tls-tests.c
@@ -525,7 +525,8 @@ static void test_precopy_tcp_tls_no_hostname(char *name, MigrateCommon *args)
     args->listen_uri = "tcp:127.0.0.1:0";
     args->start_hook = migrate_hook_start_tls_x509_no_host;
     args->end_hook = migrate_hook_end_tls_x509;
-    args->result = MIG_TEST_FAIL_DEST_QUIT_ERR;
+    args->result = MIG_TEST_FAIL;
+    args->start.incoming_defer = true;
 
     args->start.hide_stderr = true;
 
@@ -559,7 +560,8 @@ static void test_precopy_tcp_tls_x509_mismatch_host(char *name,
     args->listen_uri = "tcp:127.0.0.1:0";
     args->start_hook = migrate_hook_start_tls_x509_mismatch_host;
     args->end_hook = migrate_hook_end_tls_x509;
-    args->result = MIG_TEST_FAIL_DEST_QUIT_ERR;
+    args->result = MIG_TEST_FAIL;
+    args->start.incoming_defer = true;
 
     args->start.hide_stderr = true;
 
-- 
2.51.0