Re: [PATCH 5/8] tests/qtest/migration: Force exit-on-error=false when appropriate

[Peter Xu <peterx@redhat.com>]

On Tue, Mar 10, 2026 at 06:14:30PM -0300, Fabiano Rosas wrote:
> Peter Xu <peterx@redhat.com> writes:
> 
> > On Tue, Mar 10, 2026 at 10:55:37AM -0300, Fabiano Rosas wrote:
> >> Some tests can cause QEMU to exit(1) too early while the incoming
> >> coroutine has not yielded for a first time yet. This trips ASAN
> >> because resources related to dispatching the incoming process will
> >> still be allocated in the io/channel.c layer without a
> >> straight-forward way for the migration code to clean them up.
> >> 
> >> Since this is an issue only affecting testing and leak detection,
> >> let's make sure tests only use MIG_TEST_FAIL_DEST_QUIT_ERR when
> >> strictly necessary.
> >> 
> >> To make this process easier, force exit-on-error=false for precopy
> >> whenever the expected test result is MIG_TEST_FAIL. The distinction
> >> between the two return codes is exactly that, the latter should never
> >> cause exit(1).
> >> 
> >> The affected tests for now are the TLS tests "no_hostname" and
> >> "mismatch_host".
> >> 
> >> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> >> ---
> >>  tests/qtest/migration/framework.c | 5 ++++-
> >>  tests/qtest/migration/tls-tests.c | 6 ++++--
> >>  2 files changed, 8 insertions(+), 3 deletions(-)
> >> 
> >> diff --git a/tests/qtest/migration/framework.c b/tests/qtest/migration/framework.c
> >> index 4cc63bba7b..cfb8409d33 100644
> >> --- a/tests/qtest/migration/framework.c
> >> +++ b/tests/qtest/migration/framework.c
> >> @@ -854,7 +854,10 @@ int test_precopy_common(MigrateCommon *args)
> >>              in_channels = qobject_from_json(args->connect_channels,
> >>                                              &error_abort);
> >>          }
> >> -        migrate_incoming_qmp(to, args->listen_uri, in_channels, "{}");
> >> +
> >> +        migrate_incoming_qmp(to, args->listen_uri, in_channels,
> >> +                             args->result == MIG_TEST_FAIL ?
> >> +                             "{ 'exit-on-error': false }" : "{}");
> >
> > Can we set exit-on-error unconditionally?
> >
> 
> Yeah, what about I just remove MIG_TEST_FAIL_DEST_QUIT_ERR entirely?
> Aside from the ones mentioned in this series, there's only one other TLS
> test using it. There are two tests setting qtest_set_expected_status(to,
> EXIT_FAILURE); after migrate_cancel, but we can just wait for FAILED and
> then qtest_quit(to);

Ah yes we have one left.. Sounds good, can also be done on top if you will
queue this.

-- 
Peter Xu