All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged] proc-fix-pointer-error-dereference.patch removed from -mm tree
@ 2026-03-10 20:12 Andrew Morton
  0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2026-03-10 20:12 UTC (permalink / raw)
  To: mm-commits, viro, rppt, oleg, neil, mingo, lorenzo.stoakes,
	liam.howlett, ebiederm, bvanassche, brauner, ethantidmore06, akpm


The quilt patch titled
     Subject: proc: fix pointer error dereference
has been removed from the -mm tree.  Its filename was
     proc-fix-pointer-error-dereference.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Ethan Tidmore <ethantidmore06@gmail.com>
Subject: proc: fix pointer error dereference
Date: Thu, 19 Feb 2026 16:10:01 -0600

The function try_lookup_noperm() can return an error pointer.  Add check
for error pointer.

Detected by Smatch:
fs/proc/base.c:2148 proc_fill_cache() error:
'child' dereferencing possible ERR_PTR()

Link: https://lkml.kernel.org/r/20260219221001.1117135-1-ethantidmore06@gmail.com
Fixes: 61a28784028e ("[PATCH] proc: Remove the hard coded inode numbers")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Bart van Assche <bvanassche@acm.org>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: NeilBrown <neil@brown.name>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/proc/base.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/fs/proc/base.c~proc-fix-pointer-error-dereference
+++ a/fs/proc/base.c
@@ -2128,6 +2128,9 @@ bool proc_fill_cache(struct file *file,
 	ino_t ino = 1;
 
 	child = try_lookup_noperm(&qname, dir);
+	if (IS_ERR(child))
+		goto end_instantiate;
+
 	if (!child) {
 		DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq);
 		child = d_alloc_parallel(dir, &qname, &wq);
_

Patches currently in -mm which might be from ethantidmore06@gmail.com are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-03-10 20:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-10 20:12 [merged] proc-fix-pointer-error-dereference.patch removed from -mm tree Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.