All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
	opensbi@lists.infradead.org
Subject: [kvm-unit-tests PATCH 1/2] riscv: sbi: dbtr: fix enable trigger return code check
Date: Fri, 13 Mar 2026 15:08:30 +1000	[thread overview]
Message-ID: <20260313050831.4016944-1-npiggin@gmail.com> (raw)

Enabling triggers that are not mapped to a HW debug trigger
should return SBI_ERR_INVALID_PARAM.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 riscv/sbi-dbtr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/riscv/sbi-dbtr.c b/riscv/sbi-dbtr.c
index 129f79b8..489242b0 100644
--- a/riscv/sbi-dbtr.c
+++ b/riscv/sbi-dbtr.c
@@ -744,7 +744,7 @@ static void dbtr_test_uninstall_enable(struct sbi_dbtr_shmem_entry *shmem, enum
 	dbtr_uninstall_trigger();
 
 	ret = sbi_debug_enable_triggers(0, 1);
-	sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_enable_triggers");
+	sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_enable_triggers");
 
 	install_exception_handler(EXC_BREAKPOINT, dbtr_exception_handler);
 
-- 
2.51.0


-- 
kvm-riscv mailing list
kvm-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
	opensbi@lists.infradead.org
Subject: [kvm-unit-tests PATCH 1/2] riscv: sbi: dbtr: fix enable trigger return code check
Date: Fri, 13 Mar 2026 15:08:30 +1000	[thread overview]
Message-ID: <20260313050831.4016944-1-npiggin@gmail.com> (raw)

Enabling triggers that are not mapped to a HW debug trigger
should return SBI_ERR_INVALID_PARAM.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 riscv/sbi-dbtr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/riscv/sbi-dbtr.c b/riscv/sbi-dbtr.c
index 129f79b8..489242b0 100644
--- a/riscv/sbi-dbtr.c
+++ b/riscv/sbi-dbtr.c
@@ -744,7 +744,7 @@ static void dbtr_test_uninstall_enable(struct sbi_dbtr_shmem_entry *shmem, enum
 	dbtr_uninstall_trigger();
 
 	ret = sbi_debug_enable_triggers(0, 1);
-	sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_enable_triggers");
+	sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_enable_triggers");
 
 	install_exception_handler(EXC_BREAKPOINT, dbtr_exception_handler);
 
-- 
2.51.0


WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: Nicholas Piggin <npiggin@gmail.com>,
	kvm-riscv@lists.infradead.org, kvm@vger.kernel.org,
	opensbi@lists.infradead.org
Subject: [kvm-unit-tests PATCH 1/2] riscv: sbi: dbtr: fix enable trigger return code check
Date: Fri, 13 Mar 2026 15:08:30 +1000	[thread overview]
Message-ID: <20260313050831.4016944-1-npiggin@gmail.com> (raw)

Enabling triggers that are not mapped to a HW debug trigger
should return SBI_ERR_INVALID_PARAM.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 riscv/sbi-dbtr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/riscv/sbi-dbtr.c b/riscv/sbi-dbtr.c
index 129f79b8..489242b0 100644
--- a/riscv/sbi-dbtr.c
+++ b/riscv/sbi-dbtr.c
@@ -744,7 +744,7 @@ static void dbtr_test_uninstall_enable(struct sbi_dbtr_shmem_entry *shmem, enum
 	dbtr_uninstall_trigger();
 
 	ret = sbi_debug_enable_triggers(0, 1);
-	sbiret_report_error(&ret, SBI_SUCCESS, "sbi_debug_enable_triggers");
+	sbiret_report_error(&ret, SBI_ERR_INVALID_PARAM, "sbi_debug_enable_triggers");
 
 	install_exception_handler(EXC_BREAKPOINT, dbtr_exception_handler);
 
-- 
2.51.0


-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

             reply	other threads:[~2026-03-13  5:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  5:08 Nicholas Piggin [this message]
2026-03-13  5:08 ` [kvm-unit-tests PATCH 1/2] riscv: sbi: dbtr: fix enable trigger return code check Nicholas Piggin
2026-03-13  5:08 ` Nicholas Piggin
2026-03-13  5:08 ` [kvm-unit-tests PATCH 2/2] riscv: dbtr: Add initial API corner case / error handling tests Nicholas Piggin
2026-03-13  5:08   ` Nicholas Piggin
2026-03-13  5:08   ` Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260313050831.4016944-1-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=andrew.jones@linux.dev \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.