From: Simon Horman <horms@kernel.org>
To: justin.chen@broadcom.com
Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch,
florian.fainelli@broadcom.com
Subject: Re: [PATCH net] net: bcmasp: fix double frees during remove
Date: Fri, 13 Mar 2026 16:55:33 +0000 [thread overview]
Message-ID: <20260313165533.GA1368619@kernel.org> (raw)
In-Reply-To: <20260312200814.1977164-1-justin.chen@broadcom.com>
On Thu, Mar 12, 2026 at 01:08:14PM -0700, justin.chen@broadcom.com wrote:
> From: Justin Chen <justin.chen@broadcom.com>
>
> We have two double frees during remove.
> - We do not need to free wol_irq since it was instantiated with
> devm_request_irq(). So devres will free for us.
Hi Justin,
The above seems clear enough.
> - Switch to devm_clk_get_optional() instead of
> devm_clk_get_optional_enabled() so we can manage the clock ourselves.
But it is unclear to me what problem this is solving.
Or how it relates to the first point - usually the aim
is to have one fix per patch.
Could you elaborate?
>
> Fixes: a2f0751206b0 ("net: bcmasp: Add support for WoL magic packet")
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
next prev parent reply other threads:[~2026-03-13 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 20:08 [PATCH net] net: bcmasp: fix double frees during remove justin.chen
2026-03-13 16:55 ` Simon Horman [this message]
2026-03-13 20:21 ` Justin Chen
2026-03-14 15:45 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313165533.GA1368619@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.